Page MenuHomePhabricator

TaWeiTu (Ta-Wei Tu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 30 2020, 1:14 PM (12 w, 3 d)

Recent Activity

Sun, Sep 20

TaWeiTu added a comment to D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.

Gentle ping.

Sun, Sep 20, 7:10 PM · Restricted Project

Tue, Sep 15

TaWeiTu added a comment to D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.
  • How about using PreservedAnalyses run(Loop &, LoopAnalysisManager &, LoopStandardAnalysisResults &, LPMUpdater &, LoopNest &); for the interface. I think it should work better because it is still a loop pass interface.

Sounds like a good idea to me. Let' see what @Whitney and @etiotto think about the new interface first, and I'll update the patch later if they agree on that. Thanks!

I am not strongly against it, however is not clear to me what the extra argument Loop & provide, as we can get the loop from LoopNest & by LN.getOutermostLoop().

Tue, Sep 15, 7:34 AM · Restricted Project
TaWeiTu added a comment to D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.

Gentle ping to @Whitney and @etiotto on the opinion about the new interface for loop-nest pass suggested above. Thanks!

Tue, Sep 15, 6:05 AM · Restricted Project
TaWeiTu added inline comments to D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.
Tue, Sep 15, 6:02 AM · Restricted Project

Mon, Sep 14

TaWeiTu added a comment to D87597: [TableGen] Fix invalid comparison function `SizeOrder` in `getMatchingSubClassWithSubRegs`.

Oh, I forgot about it. --author="Ta-Wei Tu <tu.da.wei@gmail.com>", thanks!

Mon, Sep 14, 10:39 AM · Restricted Project
TaWeiTu added a comment to D87597: [TableGen] Fix invalid comparison function `SizeOrder` in `getMatchingSubClassWithSubRegs`.

Hi @arsenm, thank you for the review! Can you commit this for me? Because I don't have the commit access yet. Thanks!

Mon, Sep 14, 8:54 AM · Restricted Project

Sun, Sep 13

TaWeiTu requested review of D87597: [TableGen] Fix invalid comparison function `SizeOrder` in `getMatchingSubClassWithSubRegs`.
Sun, Sep 13, 11:14 PM · Restricted Project

Fri, Sep 11

TaWeiTu updated the diff for D87531: [LoopNest] Extend `LPMUpdater` and adaptor to handle loop-nest passes.
Fri, Sep 11, 11:15 AM · Restricted Project
TaWeiTu updated the summary of D87531: [LoopNest] Extend `LPMUpdater` and adaptor to handle loop-nest passes.
Fri, Sep 11, 10:49 AM · Restricted Project
TaWeiTu requested review of D87531: [LoopNest] Extend `LPMUpdater` and adaptor to handle loop-nest passes.
Fri, Sep 11, 10:43 AM · Restricted Project

Thu, Sep 10

TaWeiTu updated the diff for D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.
Thu, Sep 10, 11:48 AM · Restricted Project
TaWeiTu updated the diff for D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.
Thu, Sep 10, 10:07 AM · Restricted Project
TaWeiTu added a comment to D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.
  • How about using PreservedAnalyses run(Loop &, LoopAnalysisManager &, LoopStandardAnalysisResults &, LPMUpdater &, LoopNest &); for the interface. I think it should work better because it is still a loop pass interface.
Thu, Sep 10, 6:52 AM · Restricted Project
TaWeiTu updated the diff for D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.
Thu, Sep 10, 6:47 AM · Restricted Project
TaWeiTu updated the diff for D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.

Add PassInstrumentation callback tests.

Thu, Sep 10, 6:46 AM · Restricted Project

Wed, Sep 9

TaWeiTu updated the diff for D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.

Replace SFINAE helper with llvm::is_detected.

Wed, Sep 9, 1:30 PM · Restricted Project
TaWeiTu added inline comments to D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.
Wed, Sep 9, 1:04 PM · Restricted Project
TaWeiTu updated the diff for D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.

Address (some) code review comments.

Wed, Sep 9, 12:58 PM · Restricted Project
TaWeiTu added a comment to D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.

ping :)

Wed, Sep 9, 2:22 AM · Restricted Project

Fri, Sep 4

TaWeiTu updated the diff for D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.
Fri, Sep 4, 11:15 AM · Restricted Project

Thu, Sep 3

TaWeiTu updated the diff for D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.

Add unit test.

Thu, Sep 3, 2:47 AM · Restricted Project

Wed, Sep 2

TaWeiTu added reviewers for D87045: [LoopNest] Handle loop-nest passes in LoopPassManager: Whitney, etiotto, ychen, fhahn.
Wed, Sep 2, 11:21 AM · Restricted Project
TaWeiTu added a comment to D84886: Create LoopNestPass.

Hi, thanks for your comments and suggestions!

Wed, Sep 2, 11:20 AM · Restricted Project, Restricted Project
TaWeiTu updated the summary of D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.
Wed, Sep 2, 11:03 AM · Restricted Project
TaWeiTu updated the diff for D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.
Wed, Sep 2, 10:59 AM · Restricted Project
TaWeiTu updated the summary of D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.
Wed, Sep 2, 10:19 AM · Restricted Project
TaWeiTu requested review of D87045: [LoopNest] Handle loop-nest passes in LoopPassManager.
Wed, Sep 2, 10:14 AM · Restricted Project

Mon, Aug 31

TaWeiTu updated the diff for D84886: Create LoopNestPass.
Mon, Aug 31, 8:02 AM · Restricted Project, Restricted Project

Aug 25 2020

TaWeiTu added a comment to D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.

Hi @etiotto, @Whitney thanks for your reviews!
Can you commit this for me? --author="Ta-Wei Tu <tu.da.wei@gmail.com>" as mentioned above looks good to me, thanks!

Sure. I am swamped with other work, finally have time to get to it today.

Aug 25 2020, 9:00 AM · Restricted Project
TaWeiTu added a comment to D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.

Hi @etiotto, @Whitney thanks for your reviews!
Can you commit this for me? --author="Ta-Wei Tu <tu.da.wei@gmail.com>" as mentioned above looks good to me, thanks!

Aug 25 2020, 8:48 AM · Restricted Project

Aug 20 2020

TaWeiTu updated the diff for D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.

Replace unnecessary [&] with [].

Aug 20 2020, 1:40 AM · Restricted Project

Aug 19 2020

TaWeiTu added a comment to D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.

--author="Ta-Wei Tu <tu.da.wei@gmail.com>" Good?

Aug 19 2020, 7:19 PM · Restricted Project
TaWeiTu updated the diff for D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.

Source -> IncomingBlock

Aug 19 2020, 7:17 PM · Restricted Project
TaWeiTu added a comment to D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.

Hi @Whitney, @fhahn, thanks for your review and comment!
Please let me know if there's any other problem with the patch.
Also, if the patch is ready to land, is it possible for you to commit it instead (I believe I don't have the commit access)?

Aug 19 2020, 8:18 AM · Restricted Project
TaWeiTu updated the diff for D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.

Rename variables. Use BasicBlock::phis(). Explain what "extra Phi block" means in the comment.

Aug 19 2020, 8:12 AM · Restricted Project

Aug 18 2020

TaWeiTu updated the diff for D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.

Check the existence of the extra block only when the inner loop is guarded and the inner loop exit contains LCSSA Phi instructions.

Aug 18 2020, 7:58 PM · Restricted Project
TaWeiTu added a comment to D84886: Create LoopNestPass.

Hi @Whitney, @fhahn, @ychen, thank you all for your comments and suggestions! Sorry for the late reply.
I was trying to convert the LoopInterchange pass into a loop-nest pass. However, there seems to be no corresponding loop pass for the NPM.
Any particular reason for this?

Aug 18 2020, 7:27 PM · Restricted Project, Restricted Project
TaWeiTu added inline comments to D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.
Aug 18 2020, 8:48 AM · Restricted Project
TaWeiTu added inline comments to D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.
Aug 18 2020, 6:52 AM · Restricted Project
TaWeiTu updated the diff for D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.

Fix LCSSA block checking. Rename loops in the test file.

Aug 18 2020, 6:50 AM · Restricted Project
TaWeiTu retitled D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops from [LoopNest] False negative of `arePerfectlyNested` with LCSSA to [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.
Aug 18 2020, 4:26 AM · Restricted Project
TaWeiTu retitled D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops from [LoopNest] False negative of `when LCSSA pass to [LoopNest] False negative of `arePerfectlyNested` with LCSSA.
Aug 18 2020, 4:25 AM · Restricted Project
TaWeiTu requested review of D86133: [LoopNest] False negative of `arePerfectlyNested` with LCSSA loops.
Aug 18 2020, 4:24 AM · Restricted Project

Aug 11 2020

TaWeiTu added a comment to D84886: Create LoopNestPass.

@ychen Again, thanks for your comment!

Aug 11 2020, 8:49 PM · Restricted Project, Restricted Project

Aug 10 2020

TaWeiTu added a comment to D84886: Create LoopNestPass.

@ychen Thank you for your comment! I've added some unittests. Please let me know if there's anything unclear about the intended usage.

Aug 10 2020, 1:53 AM · Restricted Project, Restricted Project

Aug 9 2020

TaWeiTu updated the diff for D84886: Create LoopNestPass.
Aug 9 2020, 4:02 AM · Restricted Project, Restricted Project

Aug 8 2020

TaWeiTu updated the diff for D84886: Create LoopNestPass.

Test the functionality of addNewLoopNests().
Fix LoopNestAnalysis invalidation bugs.

Aug 8 2020, 11:27 AM · Restricted Project, Restricted Project

Aug 4 2020

TaWeiTu updated the diff for D84886: Create LoopNestPass.

Fix bug of holding dangling LoopNest references.

Aug 4 2020, 6:56 AM · Restricted Project, Restricted Project

Aug 3 2020

TaWeiTu updated the diff for D84886: Create LoopNestPass.

Add tests about invalidating the analysis results and clearing the result cache.

Aug 3 2020, 1:20 PM · Restricted Project, Restricted Project
TaWeiTu updated the summary of D84886: Create LoopNestPass.
Aug 3 2020, 4:14 AM · Restricted Project, Restricted Project
TaWeiTu updated the diff for D84886: Create LoopNestPass.

Add basic unit-tests to test and demonstrate the functionality of loop-nest-pass-related infrastructure (LoopNestPassManagerTest.cpp). Still working on more tests.

Aug 3 2020, 3:43 AM · Restricted Project, Restricted Project

Aug 2 2020

TaWeiTu added a reviewer for D84886: Create LoopNestPass: ychen.
Aug 2 2020, 8:48 PM · Restricted Project, Restricted Project

Jul 30 2020

TaWeiTu updated the diff for D84886: Create LoopNestPass.

Fix LoopRotate/pr35210.ll (sync with commit b36c39260edcded47436f344e48f78cfbedac494).

Jul 30 2020, 11:45 PM · Restricted Project, Restricted Project
TaWeiTu added a reviewer for D84886: Create LoopNestPass: kbarton.
Jul 30 2020, 9:18 PM · Restricted Project, Restricted Project
TaWeiTu updated subscribers of D84886: Create LoopNestPass.
Jul 30 2020, 10:59 AM · Restricted Project, Restricted Project
TaWeiTu updated the diff for D84886: Create LoopNestPass.

Propagate the requirement of MemorySSA from loop passes to loop nest passes.

Jul 30 2020, 10:53 AM · Restricted Project, Restricted Project
TaWeiTu updated the diff for D84886: Create LoopNestPass.
Jul 30 2020, 10:49 AM · Restricted Project, Restricted Project
TaWeiTu updated the diff for D84886: Create LoopNestPass.

Fix loop deletion and rotation tests.

Jul 30 2020, 9:15 AM · Restricted Project, Restricted Project
TaWeiTu updated the diff for D84886: Create LoopNestPass.

Fix LOOP_NEST_ANALYSIS macro, clang-tidy warnings. Rebase.

Jul 30 2020, 6:18 AM · Restricted Project, Restricted Project
TaWeiTu updated the diff for D84886: Create LoopNestPass.

Fix several pre-merge checks.

Jul 30 2020, 4:54 AM · Restricted Project, Restricted Project

Jul 29 2020

TaWeiTu requested review of D84886: Create LoopNestPass.
Jul 29 2020, 12:39 PM · Restricted Project, Restricted Project