User Details
User Details
- User Since
- Jun 30 2020, 1:14 PM (41 w, 3 d)
Wed, Apr 7
Wed, Apr 7
TaWeiTu added a comment to D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
Wed, Apr 7, 8:50 PM · Restricted Project
TaWeiTu updated the diff for D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
- Skip loop-invariant-guarded blocks
Wed, Apr 7, 8:46 PM · Restricted Project
TaWeiTu added a comment to D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
Ping
Wed, Apr 7, 1:48 AM · Restricted Project
Mon, Apr 5
Mon, Apr 5
TaWeiTu committed rG6a82ace5f27f: [LoopFusion] Bails out if only the second candidate is guarded (PR48060) (authored by TaWeiTu).
[LoopFusion] Bails out if only the second candidate is guarded (PR48060)
Mon, Apr 5, 10:09 AM · Restricted Project
Thu, Apr 1
Thu, Apr 1
TaWeiTu requested review of D99716: [LoopFusion] Bails out if only the second candidate is guarded (PR48060).
Thu, Apr 1, 3:40 AM · Restricted Project
Thu, Apr 1, 12:37 AM · Restricted Project
Wed, Mar 31
Wed, Mar 31
TaWeiTu added a comment to D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
Ping
Wed, Mar 31, 1:56 AM · Restricted Project
Tue, Mar 30
Tue, Mar 30
TaWeiTu committed rG99fd06622784: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous… (authored by TaWeiTu).
[clang][Sema] Don't try to initialize implicit variable of invalid anonymous…
TaWeiTu closed D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct.
Tue, Mar 30, 6:05 PM · Restricted Project
Sun, Mar 28
Sun, Mar 28
TaWeiTu added a comment to D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct.
ping.
Sun, Mar 28, 5:51 AM · Restricted Project
Wed, Mar 24
Wed, Mar 24
TaWeiTu added a comment to D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
Gentle ping
Wed, Mar 24, 9:12 PM · Restricted Project
TaWeiTu added a comment to D99252: [LoopFlatten] Fix invalid assertion (PR49571).
The debug message and test description are improved in rG4d9d7368759
Wed, Mar 24, 3:23 AM · Restricted Project
TaWeiTu committed rG4d9d7368759c: [NFC] Improve debug message and test description in 4c1f74a (authored by TaWeiTu).
[NFC] Improve debug message and test description in 4c1f74a
TaWeiTu added a comment to D99252: [LoopFlatten] Fix invalid assertion (PR49571).
Hi Florian,
Wed, Mar 24, 3:11 AM · Restricted Project
TaWeiTu committed rG4c1f74a76ce8: [LoopFlatten] Fix invalid assertion (PR49571) (authored by TaWeiTu).
[LoopFlatten] Fix invalid assertion (PR49571)
Wed, Mar 24, 3:08 AM · Restricted Project
TaWeiTu added a comment to D99252: [LoopFlatten] Fix invalid assertion (PR49571).
Wed, Mar 24, 3:07 AM · Restricted Project
[NFC] Remove redundant `struct` prefix
Wed, Mar 24, 2:58 AM · Restricted Project
TaWeiTu added a comment to D99251: [NFC] Remove redundant `struct` prefix.
Thanks for the review!
Wed, Mar 24, 2:58 AM · Restricted Project
TaWeiTu requested review of D99252: [LoopFlatten] Fix invalid assertion (PR49571).
Wed, Mar 24, 2:55 AM · Restricted Project
TaWeiTu updated the summary of D99251: [NFC] Remove redundant `struct` prefix.
Wed, Mar 24, 2:51 AM · Restricted Project
TaWeiTu requested review of D99251: [NFC] Remove redundant `struct` prefix.
Wed, Mar 24, 2:51 AM · Restricted Project
Mon, Mar 22
Mon, Mar 22
TaWeiTu added a comment to D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct.
Mon, Mar 22, 12:47 AM · Restricted Project
Sun, Mar 21
Sun, Mar 21
TaWeiTu added a comment to D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
Sun, Mar 21, 11:40 PM · Restricted Project
TaWeiTu updated the diff for D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
Consider instructions that are indirectly affected by the control flow
Sun, Mar 21, 11:39 PM · Restricted Project
Mar 14 2021
Mar 14 2021
TaWeiTu added a comment to D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
ping
Mar 14 2021, 7:57 AM · Restricted Project
Mar 12 2021
Mar 12 2021
TaWeiTu added a comment to D98144: [CodeGenPrepare] Fix isIVIncrement (PR49466).
Mar 12 2021, 2:11 PM · Restricted Project
TaWeiTu added a comment to D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct.
I'm not familiar with this code and clang/sema in general, so not sure if the fix makes sense.
Mar 12 2021, 12:39 PM · Restricted Project
TaWeiTu requested review of D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct.
Mar 12 2021, 12:38 PM · Restricted Project
Mar 10 2021
Mar 10 2021
TaWeiTu added a comment to D98263: [LoopInterchange] fix tightlyNested() in LoopInterchange legality.
Hi @congzhe, thanks for the fix!
Mar 10 2021, 6:53 PM · Restricted Project
TaWeiTu added a comment to D98263: [LoopInterchange] fix tightlyNested() in LoopInterchange legality.
Mar 10 2021, 9:25 AM · Restricted Project
TaWeiTu committed rG7ff2768be14f: Revert "[LoopInterchange] Replace tightly-nesting-ness check with the one from… (authored by TaWeiTu).
Revert "[LoopInterchange] Replace tightly-nesting-ness check with the one from…
TaWeiTu added a reverting change for D97290: [LoopInterchange] Replace tightly-nesting-ness check with the one from `LoopNest`: rG7ff2768be14f: Revert "[LoopInterchange] Replace tightly-nesting-ness check with the one from….
Mar 10 2021, 9:25 AM · Restricted Project
Mar 8 2021
Mar 8 2021
TaWeiTu committed rGcf82700af8c6: [CodeGenPrepare] Fix isIVIncrement (PR49466) (authored by TaWeiTu).
[CodeGenPrepare] Fix isIVIncrement (PR49466)
Mar 8 2021, 9:32 PM · Restricted Project
TaWeiTu updated the diff for D98144: [CodeGenPrepare] Fix isIVIncrement (PR49466).
- Fix test
Mar 8 2021, 9:30 PM · Restricted Project
TaWeiTu added a comment to D98144: [CodeGenPrepare] Fix isIVIncrement (PR49466).
Thanks for the review!
Mar 8 2021, 8:26 PM · Restricted Project
TaWeiTu updated the diff for D98144: [CodeGenPrepare] Fix isIVIncrement (PR49466).
- Fix nits
Mar 8 2021, 8:26 PM · Restricted Project
TaWeiTu added inline comments to D97847: Use LoopNest as the primary object on which LoopInterchange operates.
Mar 8 2021, 6:58 AM · Restricted Project
TaWeiTu updated the diff for D97847: Use LoopNest as the primary object on which LoopInterchange operates.
- Add TODOs
Mar 8 2021, 6:57 AM · Restricted Project
TaWeiTu added inline comments to D97847: Use LoopNest as the primary object on which LoopInterchange operates.
Mar 8 2021, 6:51 AM · Restricted Project
TaWeiTu added inline comments to D97847: Use LoopNest as the primary object on which LoopInterchange operates.
Mar 8 2021, 6:24 AM · Restricted Project
TaWeiTu updated the diff for D98144: [CodeGenPrepare] Fix isIVIncrement (PR49466).
- Fix typo
Mar 8 2021, 3:24 AM · Restricted Project
Mar 7 2021
Mar 7 2021
TaWeiTu committed rGdf9158c9a45a: [LoopInterchange] Replace tightly-nesting-ness check with the one from… (authored by TaWeiTu).
[LoopInterchange] Replace tightly-nesting-ness check with the one from…
TaWeiTu closed D97290: [LoopInterchange] Replace tightly-nesting-ness check with the one from `LoopNest`.
Mar 7 2021, 7:36 PM · Restricted Project
TaWeiTu updated the diff for D98144: [CodeGenPrepare] Fix isIVIncrement (PR49466).
- Add testcase
Mar 7 2021, 7:23 PM · Restricted Project
TaWeiTu added inline comments to D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
Mar 7 2021, 8:41 AM · Restricted Project
TaWeiTu updated the diff for D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
- Only check basic blocks in the inner loop
Mar 7 2021, 8:41 AM · Restricted Project
TaWeiTu added inline comments to D97290: [LoopInterchange] Replace tightly-nesting-ness check with the one from `LoopNest`.
Mar 7 2021, 8:19 AM · Restricted Project
TaWeiTu updated the diff for D97290: [LoopInterchange] Replace tightly-nesting-ness check with the one from `LoopNest`.
- Remove isTotallyNested
Mar 7 2021, 8:17 AM · Restricted Project
TaWeiTu requested review of D98144: [CodeGenPrepare] Fix isIVIncrement (PR49466).
Mar 7 2021, 7:56 AM · Restricted Project
TaWeiTu updated the diff for D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
- Use LoopInfo::getLoopFor
Mar 7 2021, 7:32 AM · Restricted Project
TaWeiTu added inline comments to D97290: [LoopInterchange] Replace tightly-nesting-ness check with the one from `LoopNest`.
Mar 7 2021, 7:31 AM · Restricted Project
Mar 6 2021
Mar 6 2021
TaWeiTu committed rG8a003861a31a: [NPM] Add -enable-loopinterchange option to NPM (authored by TaWeiTu).
[NPM] Add -enable-loopinterchange option to NPM
Mar 6 2021, 10:39 AM · Restricted Project
TaWeiTu updated the diff for D98116: [NPM] Add -enable-loopinterchange option to NPM.
- Fix nits
Mar 6 2021, 10:06 AM · Restricted Project
TaWeiTu updated the diff for D98116: [NPM] Add -enable-loopinterchange option to NPM.
- Add LoopInterchange for O1 as well
Mar 6 2021, 9:32 AM · Restricted Project
TaWeiTu requested review of D98116: [NPM] Add -enable-loopinterchange option to NPM.
Mar 6 2021, 8:45 AM · Restricted Project
Mar 5 2021
Mar 5 2021
TaWeiTu updated the diff for D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
- Add testcase of PR47523
Mar 5 2021, 11:44 AM · Restricted Project
TaWeiTu added a comment to D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
The following test in lcssa.ll is failing:
Mar 5 2021, 10:37 AM · Restricted Project
TaWeiTu added a comment to D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
Mar 5 2021, 10:26 AM · Restricted Project
Mar 3 2021
Mar 3 2021
TaWeiTu updated the diff for D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
- Remove unnecessary lines in the test case
Mar 3 2021, 9:52 AM · Restricted Project
TaWeiTu updated the diff for D97290: [LoopInterchange] Replace tightly-nesting-ness check with the one from `LoopNest`.
- Remove unnecessary lines in the test case
Mar 3 2021, 9:44 AM · Restricted Project
TaWeiTu requested review of D97847: Use LoopNest as the primary object on which LoopInterchange operates.
Mar 3 2021, 3:03 AM · Restricted Project
Mar 2 2021
Mar 2 2021
TaWeiTu retitled D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057) from [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow to [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
Mar 2 2021, 9:06 PM · Restricted Project
TaWeiTu updated the diff for D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
Mar 2 2021, 8:42 PM · Restricted Project
TaWeiTu updated the diff for D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
Mar 2 2021, 8:32 PM · Restricted Project
TaWeiTu requested review of D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
Mar 2 2021, 8:29 PM · Restricted Project
Mar 1 2021
Mar 1 2021
[NFC] Use std::swap in LoopInterchange
TaWeiTu added inline comments to D97290: [LoopInterchange] Replace tightly-nesting-ness check with the one from `LoopNest`.
Mar 1 2021, 9:45 AM · Restricted Project
Feb 28 2021
Feb 28 2021
TaWeiTu added a comment to D97290: [LoopInterchange] Replace tightly-nesting-ness check with the one from `LoopNest`.
Gentle ping.
Feb 28 2021, 11:08 AM · Restricted Project
Feb 23 2021
Feb 23 2021
TaWeiTu committed rG98c6110d9bdd: [LoopNest] Use `getUniqueSuccessor()` instead when checking empty blocks (authored by TaWeiTu).
[LoopNest] Use `getUniqueSuccessor()` instead when checking empty blocks
Feb 23 2021, 5:53 PM · Restricted Project
TaWeiTu added inline comments to D97290: [LoopInterchange] Replace tightly-nesting-ness check with the one from `LoopNest`.
Feb 23 2021, 5:03 PM · Restricted Project
TaWeiTu updated the diff for D97290: [LoopInterchange] Replace tightly-nesting-ness check with the one from `LoopNest`.
Trigger rebuild
Feb 23 2021, 8:19 AM · Restricted Project
TaWeiTu requested review of D97290: [LoopInterchange] Replace tightly-nesting-ness check with the one from `LoopNest`.
Feb 23 2021, 7:07 AM · Restricted Project
TaWeiTu updated the summary of D97286: [LoopNest] Use `getUniqueSuccessor()` instead when checking empty blocks.
Feb 23 2021, 6:57 AM · Restricted Project
TaWeiTu requested review of D97286: [LoopNest] Use `getUniqueSuccessor()` instead when checking empty blocks.
Feb 23 2021, 6:56 AM · Restricted Project
Feb 18 2021
Feb 18 2021
Remove redundent types in pr49185.ll
TaWeiTu committed rGf70cdc5b5c7c: [NPM] Properly reset parent loop after loop passes (authored by TaWeiTu).
[NPM] Properly reset parent loop after loop passes
Feb 18 2021, 10:51 AM · Restricted Project
TaWeiTu updated the diff for D96727: [NPM] Properly reset parent loop after loop passes.
- Move #ifndef NDEBUG guard
- Reduce bug reproducer
Feb 18 2021, 12:02 AM · Restricted Project
Feb 17 2021
Feb 17 2021
TaWeiTu committed rG0eeaec2a6d5f: [NFC] Refactor LoopInterchange into a loop-nest pass (authored by TaWeiTu).
[NFC] Refactor LoopInterchange into a loop-nest pass
Feb 17 2021, 8:55 AM · Restricted Project
TaWeiTu updated the diff for D96644: [NFC] Refactor LoopInterchange into a loop-nest pass.
Rebase
Feb 17 2021, 8:17 AM · Restricted Project
Feb 16 2021
Feb 16 2021
TaWeiTu committed rG6b612a7baf8e: [NFC][LoopInterchange] Explicitly pass both `InnerLoop` and `OuterLoop` to… (authored by TaWeiTu).
[NFC][LoopInterchange] Explicitly pass both `InnerLoop` and `OuterLoop` to…
TaWeiTu closed D96650: [NFC][LoopInterchange] Explicitly pass both `InnerLoop` and `OuterLoop` to `processLoop`.
Feb 16 2021, 6:18 AM · Restricted Project
TaWeiTu added inline comments to D96727: [NPM] Properly reset parent loop after loop passes.
Feb 16 2021, 12:45 AM · Restricted Project
Feb 15 2021
Feb 15 2021
TaWeiTu added reviewers for D96727: [NPM] Properly reset parent loop after loop passes: asbirlea, ychen.
Feb 15 2021, 1:23 PM · Restricted Project
TaWeiTu updated the diff for D96727: [NPM] Properly reset parent loop after loop passes.
Copy reproducer from bugzilla.
Will try to minimize it later.
Feb 15 2021, 12:30 PM · Restricted Project
TaWeiTu requested review of D96727: [NPM] Properly reset parent loop after loop passes.
Feb 15 2021, 12:23 PM · Restricted Project
TaWeiTu updated the diff for D96644: [NFC] Refactor LoopInterchange into a loop-nest pass.
Feb 15 2021, 10:22 AM · Restricted Project
TaWeiTu added inline comments to D96644: [NFC] Refactor LoopInterchange into a loop-nest pass.
Feb 15 2021, 10:16 AM · Restricted Project
TaWeiTu updated the diff for D96644: [NFC] Refactor LoopInterchange into a loop-nest pass.
Replace LoopNest::getHeader() with LoopNest::getParent()
Feb 15 2021, 10:10 AM · Restricted Project
Feb 14 2021
Feb 14 2021
TaWeiTu updated the summary of D96650: [NFC][LoopInterchange] Explicitly pass both `InnerLoop` and `OuterLoop` to `processLoop`.
Feb 14 2021, 10:11 AM · Restricted Project
TaWeiTu updated the summary of D96644: [NFC] Refactor LoopInterchange into a loop-nest pass.
Feb 14 2021, 10:05 AM · Restricted Project
TaWeiTu updated the diff for D96644: [NFC] Refactor LoopInterchange into a loop-nest pass.
Rebase on top of D96650
Feb 14 2021, 10:02 AM · Restricted Project