Page MenuHomePhabricator

TG908 (Tim Gymnich)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Apr 12 2019, 2:29 PM (30 w, 5 d)

Recent Activity

Sat, Nov 2

TG908 added inline comments to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Sat, Nov 2, 8:25 AM · Restricted Project
TG908 updated the diff for D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Sat, Nov 2, 7:57 AM · Restricted Project

Fri, Nov 1

TG908 added inline comments to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Fri, Nov 1, 4:35 PM · Restricted Project
TG908 added a comment to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Fri, Nov 1, 4:25 PM · Restricted Project

Thu, Oct 31

TG908 added a comment to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].

I am still looking for a better solution for checking if the types are legal and the optimization can be applied.
Right now I get an integer type VT for the rem operation and I check if a type twice as wide (FVT) is legal.

// Check to see if we can do this.
 if (IsAfterLegalization && !isTypeLegal(FVT))
   return SDValue();

On RISCV the first iteration of a 32 bit rem operation will not cause an optimization. After the next round of legalization the operations gets expanded to 64 bit and the the optimization gets applied.
Checking for both VT and FVT at the same time doesn't work since RISCV only has i64 and not i32. Thus VT and FVT are never legal at the same time.

Thu, Oct 31, 5:26 AM · Restricted Project

Wed, Oct 30

TG908 added inline comments to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Wed, Oct 30, 10:12 AM · Restricted Project
TG908 updated the diff for D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Wed, Oct 30, 10:12 AM · Restricted Project

Oct 10 2019

TG908 updated the diff for D68557: PR41162 Implement LKK remainder and divisibility algorithms [srem].
Oct 10 2019, 2:06 PM · Restricted Project
TG908 updated the diff for D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Oct 10 2019, 6:09 AM · Restricted Project

Oct 9 2019

TG908 added inline comments to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Oct 9 2019, 9:03 AM · Restricted Project
TG908 added a comment to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].

I tested loops containing a rem operation on AArch64.
With LKK the loop body contains 3 fewer instructions.

Oct 9 2019, 6:13 AM · Restricted Project

Oct 8 2019

TG908 added a comment to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].

ARM performance could still be good in loops once the constant has been loaded.
Need to tests that.

Oct 8 2019, 4:33 AM · Restricted Project
TG908 updated the diff for D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Oct 8 2019, 4:33 AM · Restricted Project

Oct 7 2019

TG908 added a comment to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Oct 7 2019, 6:04 PM · Restricted Project
TG908 added inline comments to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Oct 7 2019, 3:18 PM · Restricted Project

Oct 6 2019

TG908 retitled D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem] from PR41162 Implement LKK remainder and divisibility algorithms [UREM] to PR41162 Implement LKK remainder and divisibility algorithms [urem].
Oct 6 2019, 3:54 PM · Restricted Project
TG908 added a child revision for D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem]: D68557: PR41162 Implement LKK remainder and divisibility algorithms [srem].
Oct 6 2019, 3:54 PM · Restricted Project
TG908 added a parent revision for D68557: PR41162 Implement LKK remainder and divisibility algorithms [srem]: D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Oct 6 2019, 3:54 PM · Restricted Project
TG908 retitled D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem] from PR41162 Implement LKK remainder and divisibility algorithms to PR41162 Implement LKK remainder and divisibility algorithms [UREM].
Oct 6 2019, 3:49 PM · Restricted Project
TG908 created D68557: PR41162 Implement LKK remainder and divisibility algorithms [srem].
Oct 6 2019, 3:48 PM · Restricted Project
TG908 updated the diff for D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Oct 6 2019, 3:43 PM · Restricted Project
TG908 added inline comments to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Oct 6 2019, 5:32 AM · Restricted Project
TG908 added inline comments to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Oct 6 2019, 5:24 AM · Restricted Project
TG908 added inline comments to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Oct 6 2019, 5:24 AM · Restricted Project
TG908 added a comment to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].

A C implementation of LKK suggests that it should be possible to generate better code on AArch64.

Oct 6 2019, 3:34 AM · Restricted Project
TG908 added a comment to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].

We've got some mixed results here:

Oct 6 2019, 3:23 AM · Restricted Project
TG908 updated the diff for D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Oct 6 2019, 3:07 AM · Restricted Project

Oct 5 2019

TG908 added a comment to D68421: Add tests for LKK algorithm.

thank you

Oct 5 2019, 7:38 AM · Restricted Project
TG908 added a comment to D68421: Add tests for LKK algorithm.

I don't have commit access. This is my first patch.

Oct 5 2019, 6:56 AM · Restricted Project
TG908 added a parent revision for D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem]: D68421: Add tests for LKK algorithm.
Oct 5 2019, 6:46 AM · Restricted Project
TG908 added a child revision for D68421: Add tests for LKK algorithm: D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Oct 5 2019, 6:46 AM · Restricted Project

Oct 3 2019

TG908 added a comment to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].

done

Oct 3 2019, 1:56 PM · Restricted Project
TG908 created D68421: Add tests for LKK algorithm.
Oct 3 2019, 1:56 PM · Restricted Project
TG908 updated the diff for D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
  • put tests in separate commit
  • ran tests
  • fixed comment error
  • updated tests
Oct 3 2019, 4:28 AM · Restricted Project
TG908 added inline comments to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Oct 3 2019, 2:52 AM · Restricted Project
TG908 updated the diff for D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].

put new tests in a separate commit

Oct 3 2019, 1:39 AM · Restricted Project
TG908 updated the summary of D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Oct 3 2019, 12:43 AM · Restricted Project

Oct 2 2019

TG908 created D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Oct 2 2019, 4:32 PM · Restricted Project