Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Sinitax (Louis Burda)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 3 2023, 2:32 PM (16 w, 2 d)

Recent Activity

Jun 15 2023

Sinitax retitled D152083: [clang] Warning for incomplete array initializer lists from [clang] Warning for uninitialized elements in fixed-size arrays to [clang] Warning for incomplete array initializer lists.
Jun 15 2023, 8:20 AM · Restricted Project, Restricted Project

Jun 12 2023

Sinitax updated the diff for D152083: [clang] Warning for incomplete array initializer lists.

Fix test.

Jun 12 2023, 5:17 PM · Restricted Project, Restricted Project
Sinitax updated the diff for D152083: [clang] Warning for incomplete array initializer lists.

Rebase patch against branch main.

Jun 12 2023, 7:26 AM · Restricted Project, Restricted Project

Jun 8 2023

Sinitax added a comment to D152083: [clang] Warning for incomplete array initializer lists.

Why do you make this a new warning group instead of just adding it to -Wuninitialized?

I think a separate group is best, since the warning emits false positives: an intentional empty-initialization (such as char buf[BUF_SIZ] = { 0 }) is indistinguishable from unintentionally incomplete initialization (such as int pair[2] = { ENUM_A /*, ENUM_B */ }).

Jun 8 2023, 10:32 AM · Restricted Project, Restricted Project
Sinitax updated the diff for D152083: [clang] Warning for incomplete array initializer lists.

Rebased changes onto commit tagged 'llvmorg-17-init', and added release notes.

Jun 8 2023, 10:32 AM · Restricted Project, Restricted Project
Sinitax updated the diff for D152083: [clang] Warning for incomplete array initializer lists.

Rename warning to -Wincomplete-array-initializer-list for clarity, and add test case.

Jun 8 2023, 10:15 AM · Restricted Project, Restricted Project

Jun 5 2023

Sinitax updated the diff for D152083: [clang] Warning for incomplete array initializer lists.

Apply git-clang-format.

Jun 5 2023, 5:51 AM · Restricted Project, Restricted Project

Jun 4 2023

Sinitax updated the diff for D152083: [clang] Warning for incomplete array initializer lists.

Add new warning to its own group.

Jun 4 2023, 6:22 PM · Restricted Project, Restricted Project

Jun 3 2023

Sinitax updated the diff for D152083: [clang] Warning for incomplete array initializer lists.

Remove new warning from -Wuninitialized group for backwards-compatibility.

Jun 3 2023, 4:28 PM · Restricted Project, Restricted Project
Sinitax retitled D152083: [clang] Warning for incomplete array initializer lists from Warning for uninitialized elements in fixed-size arrays to [clang] Warning for uninitialized elements in fixed-size arrays.
Jun 3 2023, 2:50 PM · Restricted Project, Restricted Project
Sinitax requested review of D152083: [clang] Warning for incomplete array initializer lists.
Jun 3 2023, 2:45 PM · Restricted Project, Restricted Project