Page MenuHomePhabricator

Saldivarcher (Miguel Saldivar)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 24 2020, 10:09 PM (36 w, 2 d)

Recent Activity

Sep 12 2020

Saldivarcher added a comment to D86581: [clang-format] Handle shifts within conditions.

@MyDeveloperDay looks like it's in master, thanks for committing for me!

Sep 12 2020, 9:04 PM · Restricted Project, Restricted Project

Aug 27 2020

Saldivarcher added a comment to D86581: [clang-format] Handle shifts within conditions.

@MyDeveloperDay thanks for the kind words, it's much appreciated! I'm just glad I was able to help. Nope, I don't have commit access, can you do me the favor of commiting for me?

Aug 27 2020, 8:00 AM · Restricted Project, Restricted Project

Aug 26 2020

Saldivarcher added a comment to D86581: [clang-format] Handle shifts within conditions.

MyDeveloperDay, I added your tests. Sorry to step on your toes, I didn't know there was a patch open for this already :(. Yeah, JakeMerdichAMD, it's kinda tough to handle those types of cases without some sort of parsing. I'm glad you're working on that, and my code doesn't get in the way.

Aug 26 2020, 9:45 AM · Restricted Project, Restricted Project
Saldivarcher updated the diff for D86581: [clang-format] Handle shifts within conditions.

Added some more tests.

Aug 26 2020, 9:42 AM · Restricted Project, Restricted Project

Aug 25 2020

Saldivarcher added a reviewer for D86581: [clang-format] Handle shifts within conditions: Restricted Project.
Aug 25 2020, 9:19 PM · Restricted Project, Restricted Project
Saldivarcher updated the summary of D86581: [clang-format] Handle shifts within conditions.
Aug 25 2020, 5:15 PM · Restricted Project, Restricted Project
Saldivarcher requested review of D86581: [clang-format] Handle shifts within conditions.
Aug 25 2020, 5:14 PM · Restricted Project, Restricted Project