Page MenuHomePhabricator

Rot127 (Rot127)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 26 2022, 4:18 PM (14 w, 3 d)

Recent Activity

Thu, Jan 19

Rot127 added a comment to D138323: [TableGen] RegisterInfo backend - Add abstraction layer between code generation logic and syntax output.

Thank you for the feedback!
Its my first time with LLVM so your critique is very valuable for me.

Thu, Jan 19, 12:04 PM · Restricted Project, Restricted Project

Wed, Jan 18

Rot127 requested review of D142054: [TableGen] Add high level DecoderEmitter documentation..
Wed, Jan 18, 1:28 PM · Restricted Project, Restricted Project

Sat, Jan 14

Rot127 added a comment to D138323: [TableGen] RegisterInfo backend - Add abstraction layer between code generation logic and syntax output.

I'd rather see smaller, more specific classes, e.g. a RegEmitterPrinter abstract base class which can then be inherited by a RegEmitterCPPPrinter(*) and other similar RegEmitter<Lang>Printer.

Sat, Jan 14, 2:15 PM · Restricted Project, Restricted Project

Dec 30 2022

Rot127 updated the diff for D138323: [TableGen] RegisterInfo backend - Add abstraction layer between code generation logic and syntax output.

Removes the PrinterInterface. New language printer should simply inherit from PrinterLLVM.

Dec 30 2022, 9:48 AM · Restricted Project, Restricted Project

Nov 24 2022

Rot127 added a comment to D138323: [TableGen] RegisterInfo backend - Add abstraction layer between code generation logic and syntax output.

Wouldn't this break the 'open-close principle' and 'Interface segregation principle' ?

Nov 24 2022, 7:02 AM · Restricted Project, Restricted Project

Nov 22 2022

Rot127 retitled D138323: [TableGen] RegisterInfo backend - Add abstraction layer between code generation logic and syntax output from {TableGen] RegisterInfo backend - Add abstraction layer between code generation logic and syntax output to [TableGen] RegisterInfo backend - Add abstraction layer between code generation logic and syntax output.
Nov 22 2022, 8:16 AM · Restricted Project, Restricted Project

Nov 18 2022

Rot127 added a comment to D138323: [TableGen] RegisterInfo backend - Add abstraction layer between code generation logic and syntax output.

To test the output after the refactor I used the following simple scripts:

Nov 18 2022, 1:48 PM · Restricted Project, Restricted Project
Rot127 abandoned D136808: Refactor Tblgen DecoderEmitter to allow multiple language output.

There is now an implementation open for review: https://reviews.llvm.org/D138323

Nov 18 2022, 12:38 PM · Restricted Project, Restricted Project
Rot127 requested review of D138323: [TableGen] RegisterInfo backend - Add abstraction layer between code generation logic and syntax output.
Nov 18 2022, 12:37 PM · Restricted Project, Restricted Project

Oct 27 2022

Rot127 added a comment to D136808: Refactor Tblgen DecoderEmitter to allow multiple language output.
Oct 27 2022, 7:51 PM · Restricted Project, Restricted Project
Rot127 added a comment to D136808: Refactor Tblgen DecoderEmitter to allow multiple language output.

Thanks for this patch !

It is difficult to see the changes you made. Could you separate this into two patches -- the first one contains the all the changes except the functional change; the second one contains the functional change you made.

Oct 27 2022, 7:34 PM · Restricted Project, Restricted Project
Rot127 updated the diff for D136808: Refactor Tblgen DecoderEmitter to allow multiple language output.

Add diff of Printer implementation.

Oct 27 2022, 7:26 PM · Restricted Project, Restricted Project
Rot127 updated the diff for D136808: Refactor Tblgen DecoderEmitter to allow multiple language output.

Adds the decoder split up/refactor as single diff. separated from the Printer implementation.

Oct 27 2022, 7:04 PM · Restricted Project, Restricted Project

Oct 26 2022

Rot127 requested review of D136808: Refactor Tblgen DecoderEmitter to allow multiple language output.
Oct 26 2022, 6:11 PM · Restricted Project, Restricted Project