Thanks, it was essential. I have updated the patch.

@bmahjour thanks for the reviews, I will update the patch soon.

@Whitney thanks for the reviews, I have added the test case.

Thanks for the reviews @Whitney , I have updated the patch with the changes.

Many thanks for you reviews @hiraditya , acknowledged and updated.

In D84589#2180220, @fhahn wrote:

Are there plans on moving some transforms to use this with AA? I think it would be good to have a concrete plan to make use of this, otherwise I am worried that the code will miss out on large real-world test coverage.

Acknowledged, updated.

Many thanks, I have updated the diff.

Many thanks, updated the parent revision.

In D82293#2118122, @asbirlea wrote:

The issue with this change is that there is a lot of unnecessary work done now. Before, we could exit early to decide an instruction could never be hoisted/sunk. Now, we're removing all those early checks and only when actually trying to move get the "actually, you can't". I expect this to get a big compile-time penalty.
Could you do some testing and include results in the patch summary?

Many thanks @asbirlea and @fhahn for the review, it surely makes more sense to keep CodeMoverUtils flexible with the required analysis. I've made all the analysis in CodeMotionUtils optional so now we need not add them in LICM.

This update fixes the existing errors in the patch.

This update removes localDominates which is not required, only one OrderedInstructions is required which is domTreeLevelBefore which is now a part of CodeMoverUtils.cpp

This update removes the OrderedInstructions class from CodeMoverUtils and also removes it's exposure to other transformation passes, both localDominates and domTreeLevelBefore is made as static functions and are present in CodeMoverUtils.cpp. OrderedInstructions::dominates() has been removed from CodeMoverUtils.cpp due to it's existance in DominatorTree::dominates(), the dominance test moved from OrderedInstructionsTest.cpp to CodeMoverUtilsTest.cpp is also removed.

In D80643#2057673, @nikic wrote:

You don't need an actual OrderedInstructions class. You can simply make domTreeLevelBefore() a static function in CodeMoverUtils.cpp. Replace the localDominates() call with Instruction::comesBefore().

This update changes OrderedInstructions.cpp to Clang-format and fixes errors in function description of domTreeLevelBefore.

This update changes bfsLevelBefore to domTreeLevelBefore, the new name adds more details about the function and makes it more descriptive.

In D80084#2040795, @fhahn wrote:

It looks like the only user of OrderedInstructions.h is CodeMoverUtils now. At this point I think it would be good to remove OrderedInstructions and move the new code directly to CodeMoverUtils

Added function description to bfsLevelBefore and made some optimization changes in the dominance checks.