Razer6 (Robert Schilling)
User

Projects

User does not belong to any projects.

User Details

User Since: Jan 31 2017, 5:57 AM (207 w, 1 d)

Recent Activity
View All

Apr 20 2020

Razer6 accepted D78364: [MC][Bugfix] Remove redundant parameter for relaxInstruction.

LGTM. Tested the patch for RISC-V.

Apr 20 2020, 6:59 AM · Restricted Project

Apr 17 2020

Razer6 added a comment to D77851: [X86][MC] Make -x86-pad-max-prefix-size compatible with --mc-relax-all.

In D77851#1988191, @MaskRay wrote:

Which way do you think is better? Personally, I prefer the second one, since getAssembler().getBackend().relaxInstruction(Relaxed, STI, Relaxed) is called in a loop, the assumption that third argument of relaxInstruction is a fresh uninitialized MCInst is very strange.

Special casing RISC-V looks good to me.

Apr 17 2020, 1:02 AM · Restricted Project

Apr 16 2020

Razer6 updated subscribers of D77851: [X86][MC] Make -x86-pad-max-prefix-size compatible with --mc-relax-all.

It seems that this change breaks the RISCV backend. RISCVAsmBackend::relaxInstruction assumes that the Relaxed parameter is a fresh uninitialized MCInst. With this change, invalid instructions with too many operands are generated. A similar problem probably happens for the Hexagon and for the AMDGPU backend.

Apr 16 2020, 5:36 AM · Restricted Project