Page MenuHomePhabricator

RIscRIpt (Richard Dzenis)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 17 2019, 1:13 AM (155 w, 1 d)

Recent Activity

Oct 2 2022

RIscRIpt added a comment to D134475: Add C++11 attribute msvc::constexpr.

TODO: I think, I'll need to read more about constexpr for functions in standard (and LLVM code), to add relevant restrictions here.

Oct 2 2022, 9:00 AM · Restricted Project, Restricted Project

Oct 1 2022

RIscRIpt planned changes to D134475: Add C++11 attribute msvc::constexpr.
Oct 1 2022, 1:56 PM · Restricted Project, Restricted Project
RIscRIpt updated the diff for D134475: Add C++11 attribute msvc::constexpr.

Add more tests, don't alter constexprKind of [[msvc::constexpr]] functions - instead change implementation of isConstexpr

Oct 1 2022, 1:56 PM · Restricted Project, Restricted Project

Sep 23 2022

RIscRIpt updated the summary of D134458: [AST] Add C++11 attribute 'msvc::no_unique_address'.
Sep 23 2022, 1:56 AM · Restricted Project, Restricted Project

Sep 22 2022

RIscRIpt planned changes to D134458: [AST] Add C++11 attribute 'msvc::no_unique_address'.

TODO: add proper ABI tests of [[msvc::no_unique_address]]

Sep 22 2022, 2:44 PM · Restricted Project, Restricted Project
RIscRIpt updated the diff for D134458: [AST] Add C++11 attribute 'msvc::no_unique_address'.

Add naive implementation ABI of [[msvc::no_unique_address]]

Sep 22 2022, 2:43 PM · Restricted Project, Restricted Project
RIscRIpt planned changes to D134458: [AST] Add C++11 attribute 'msvc::no_unique_address'.
Sep 22 2022, 2:20 PM · Restricted Project, Restricted Project
RIscRIpt added a comment to D134458: [AST] Add C++11 attribute 'msvc::no_unique_address'.

Can you split this out into two separate reviews?

Sep 22 2022, 1:50 PM · Restricted Project, Restricted Project
RIscRIpt requested review of D134475: Add C++11 attribute msvc::constexpr.
Sep 22 2022, 1:48 PM · Restricted Project, Restricted Project
RIscRIpt updated the diff for D134458: [AST] Add C++11 attribute 'msvc::no_unique_address'.

Remove msvc::constexpr commit

Sep 22 2022, 1:09 PM · Restricted Project, Restricted Project
RIscRIpt abandoned D133853: [AST] Add msvc-specific C++11 attributes.

Closing in favor of https://reviews.llvm.org/D134475

Sep 22 2022, 1:07 PM · Restricted Project, Restricted Project
RIscRIpt updated the diff for D134458: [AST] Add C++11 attribute 'msvc::no_unique_address'.

Add msvc::constexpr commit

Sep 22 2022, 10:37 AM · Restricted Project, Restricted Project
RIscRIpt added a comment to D133853: [AST] Add msvc-specific C++11 attributes.

I am new to arc, I tried arc diff --edit --verbatim as it's said in the docs, but it still created a new revision: https://reviews.llvm.org/D134458

Sep 22 2022, 10:35 AM · Restricted Project, Restricted Project
RIscRIpt requested review of D134458: [AST] Add C++11 attribute 'msvc::no_unique_address'.
Sep 22 2022, 10:34 AM · Restricted Project, Restricted Project
RIscRIpt added a comment to D133853: [AST] Add msvc-specific C++11 attributes.

It's a conforming extension in older language modes like C++98, where we couldn't steal the constexpr keyword because it's not reserved, which is one benefit to it. Does MSVC support this as far back as C++98?

Sep 22 2022, 8:18 AM · Restricted Project, Restricted Project

Sep 17 2022

RIscRIpt added a comment to D133853: [AST] Add msvc-specific C++11 attributes.

but my suggestion is to only support [[msvc::constexpr]] with the semantic meaning of constexpr

Sep 17 2022, 6:34 AM · Restricted Project, Restricted Project

Sep 15 2022

RIscRIpt added a comment to D133853: [AST] Add msvc-specific C++11 attributes.

I'm wondering what the goal is for these changes. ... Are you intending to add semantics for these attributes in follow-up patches?

Sep 15 2022, 1:51 PM · Restricted Project, Restricted Project

Sep 14 2022

RIscRIpt requested review of D133853: [AST] Add msvc-specific C++11 attributes.
Sep 14 2022, 5:23 AM · Restricted Project, Restricted Project