Rebase onto main. Run lit clang/test. Bump.

Looks good. Thanks!

In D158591#4636814, @cor3ntin wrote:

Hum. before I do

• I think the commit message could be more explicit as to what the patch does ("Add support of Windows Trace Logging macros" is a bit vague)
• Do we need a release note ?

@cor3ntin, thanks for asking. No, I do not have access. Please merge. Commits should have correct email and name.

I found a way to implement __LPREFIX-macros-family in Clang. I need some more time to finish and polish it. Going to post it a couple of weeks later.

Rebased onto main, fixed commit messages, fixed formatting, re-run lit for clang/test

In D158591#4616728, @RIscRIpt wrote:

And it seems that BasePtr points to a different object, not the one which corresponds to StringLiteral (at step 2).

Regarding new interpreter.

Address review comments

The current implementation of getPredefinedExprDeclContext could be easily moved to a static function inside clang/lib/Sema/SemaExpr.cpp as it depends only on Sema::CurContext WDYT?

I missed this comment

Use isa<...> in getPredefinedExprDeclContext

Rebase onto main, address review comments

While I work at __LPREFIX, I remove this revision from review queue.

This implementation preserves support for identifiers L__FUNCSIG__ and L__FUNCTION__ (which have never been supported by MSVC), and adds other identifiers for all supported encodings: L, u8, u, U.

Rebase onto main (bump)

Updated comment; rebased onto main

In D153914#4570148, @cor3ntin wrote:

We will commit on your behalf, what name/email do you want us to use?
Thanks!

Address review comments, rebase onto main

Rebased onto main, run local lit clang/tests. (bump for @cor3ntin)
As far as I understand this shall be merged into main by maintainers.
Please let me know if something else is expected from me.

Thank you for the review! I apologize for missing the small details; I should have noticed and addressed them myself.

Rename MicrosoftStringLiteralFromPredefined

Rename diagnostic messages constants

Removed irrelevant changes

Addressed review comments, rebased onto main

Thanks to your suggestion of testing different types, I realized clang does not support MSVC macros with u, u8, and U prefixes in addition to L__FUNCDNAME. By the way, clang replicates MSVC behavior a little bit incorrectly: L__FUNCTION__ is not a valid token for MSVC, however it becomes valid if used via macro concatenation (see #define WIDE).
I think addition of support of new macros as well as bug fix (if possible) should be submitted separately. I'll open-up an issue, and submit a PR later.

Address review comments, rebase onto main

Fix clang/test/SemaCXX/ms-constexpr.cpp

add HEAD~2 patch

Addressed review comments and rebased onto main.

Addressed review comments, rebased onto main

Thank you for your quick response.

According to git blame @rsmith has done lots of changes in clang/lib/AST/ExprConstant.cpp; added as reviewer.

Renamed clang/test/AST/msvc-* to ms-*
Tried to improve doc note.
Rebased onto one of stable commits from main.

Addressed review comments, rebased onto main

Addressed review comments, rebased onto main.

Rebased onto main

Addressed review comments.

Added @aaron.ballman as reviewer, because he was reviewer of related patch: 878e590503dff

Rebased onto main

Rebased onto main

GitHub issue: https://github.com/llvm/llvm-project/issues/63563

Added diagnostics for [[msvc::constexpr]] virtual

I think it went unnoticed, because AFAICS lpStartEncoding is omit most of the times, which resulted MaybeLPStart == std::nullopt, and LPStart = 0.

LPStart = 0
LPOffset = LPStart + LandingPad;
LPAddress = Address + LPOffset; // == Address + 0 + LandingPad == Address + LandingPad
LPAddress < Address == false // OK, fragment is not skipped

Does it prohibit the inverse? I think this documentation overall needs a much better description of what the semantics are here, particularly anything that you found in experimentation on the MS implementation.

A proper implementation

This had to be submitted to https://reviews.llvm.org/D134475

I am sorry for protracting implementation. I am still interested to finish this (if no volunteer takes over sooner).

I asked MSFT to comment, let's see if they can share the spec for this attribute.

TODO: I think, I'll need to read more about constexpr for functions in standard (and LLVM code), to add relevant restrictions here.

Add more tests, don't alter constexprKind of [[msvc::constexpr]] functions - instead change implementation of isConstexpr

TODO: add proper ABI tests of [[msvc::no_unique_address]]

Add naive implementation ABI of [[msvc::no_unique_address]]

In D134458#3809570, @aaron.ballman wrote:

Can you split this out into two separate reviews?

Remove msvc::constexpr commit

Closing in favor of https://reviews.llvm.org/D134475

Add msvc::constexpr commit

I am new to arc, I tried arc diff --edit --verbatim as it's said in the docs, but it still created a new revision: https://reviews.llvm.org/D134458

In D133853#3799344, @aaron.ballman wrote:

It's a conforming extension in older language modes like C++98, where we couldn't steal the constexpr keyword because it's not reserved, which is one benefit to it. Does MSVC support this as far back as C++98?

In D133853#3795579, @aaron.ballman wrote:

but my suggestion is to only support [[msvc::constexpr]] with the semantic meaning of constexpr

In D133853#3792518, @aaron.ballman wrote:

I'm wondering what the goal is for these changes. ... Are you intending to add semantics for these attributes in follow-up patches?