Page MenuHomePhabricator

Qix- (Josh Junon)
Research

Projects

User does not belong to any projects.

User Details

User Since
Apr 22 2017, 11:02 PM (211 w, 2 d)

Recent Activity

Thu, Apr 22

Qix- abandoned D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes.

Closing in favor of more complete plugin attribute changes discussed in IRC.

Thu, Apr 22, 6:35 AM · Restricted Project
Qix- abandoned D99877: [Clang] Allow processing of attributes on statements by plugins.

Closing in favor of more complete plugin attribute changes discussed in IRC.

Thu, Apr 22, 6:35 AM · Restricted Project

Sun, Apr 18

Qix- added a comment to D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes.

I'm not sure exactly how to continue after the last few comments - what should the approach be for this patch? Or are these things we can shoot for in later patches?

Sun, Apr 18, 12:32 PM · Restricted Project

Apr 10 2021

Qix- added a comment to D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes.

@aaron.ballman updated with comments.

Apr 10 2021, 7:40 AM · Restricted Project
Qix- updated the diff for D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes.
Apr 10 2021, 7:38 AM · Restricted Project

Apr 9 2021

Qix- updated Qix-.
Apr 9 2021, 1:27 PM
Qix- added inline comments to D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes.
Apr 9 2021, 1:23 PM · Restricted Project
Qix- added a comment to D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes.

So I went back and checked and I remember why I didn't add explicit support for GNU/declspec attributes - they actually perform symbol lookups in the surrounding scope. I believe there's an issue right now with plugins that GNU-style attributes parser assumes that they're being parsed from the Tablegen stuff and thus expect the attribute classes to be parameterized as e.g. taking arguments or not. Therefore, putting arbitrary tokens in GNU-style and (as far as I can tell) declspec-style attributes is expressely not supported by the compiler. Also I believe this makes sense, too, because those syntaxes aren't spec'd to allow arbitrary tokens like C2x and C++ attributes are.

Apr 9 2021, 1:20 PM · Restricted Project
Qix- planned changes to D99877: [Clang] Allow processing of attributes on statements by plugins.
Apr 9 2021, 11:05 AM · Restricted Project
Qix- planned changes to D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes.
Apr 9 2021, 11:04 AM · Restricted Project

Apr 8 2021

Qix- updated the diff for D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes.

Updated the diff to include a lot more context (-U9999). Thanks again for the tip :)

Apr 8 2021, 11:10 AM · Restricted Project
Qix- updated the diff for D99877: [Clang] Allow processing of attributes on statements by plugins.
Apr 8 2021, 11:05 AM · Restricted Project

Apr 5 2021

Qix- updated the summary of D99877: [Clang] Allow processing of attributes on statements by plugins.
Apr 5 2021, 1:57 AM · Restricted Project
Qix- requested review of D99877: [Clang] Allow processing of attributes on statements by plugins.
Apr 5 2021, 1:56 AM · Restricted Project

Apr 4 2021

Qix- updated the summary of D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes.
Apr 4 2021, 12:37 PM · Restricted Project
Qix- updated the summary of D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes.
Apr 4 2021, 9:56 AM · Restricted Project
Qix- requested review of D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes.
Apr 4 2021, 9:48 AM · Restricted Project

Jan 25 2019

Qix- added a comment to D32635: [libcxx] regex: fix backreferences in forward assertions.

Ping @EricWF - few years but this is still an issue, rendering ECMAscript regex backreferences almost entirely broken in libcxx :/ Would be great to get a champion for it. OP has indicated on Github that they'd be happy to rebase.

Jan 25 2019, 2:39 PM

Aug 25 2018

Qix- added inline comments to D51265: Headers: fix collisions with .h files of other projects.
Aug 25 2018, 8:10 PM · Restricted Project