Page MenuHomePhabricator

Prince781 (Princeton Ferro)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2019, 8:28 AM (67 w, 6 d)

Recent Activity

Aug 22 2019

Prince781 added a comment to D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes.

The more I think about this, the more I have doubts about whether this should be supported. For example, what happens in cases like this?:

Aug 22 2019, 7:56 AM · Restricted Project, Restricted Project
Prince781 added a comment to D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes.

But given that, I think we should submit a core issue, and hold off on merging this until we hear back from the committee.

I agree here. There does appear to be some previous discussion on this matter, but the spec itself still doesn't contain any language addressing this issue. I will submit a core issue.

Aug 22 2019, 7:01 AM · Restricted Project, Restricted Project

Aug 20 2019

Prince781 added a project to D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes: Restricted Project.
Aug 20 2019, 11:25 PM · Restricted Project, Restricted Project
Prince781 added inline comments to D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes.
Aug 20 2019, 11:22 PM · Restricted Project, Restricted Project
Prince781 updated the diff for D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes.

Use SourceManager to order inits.

Aug 20 2019, 11:14 PM · Restricted Project, Restricted Project
Prince781 added inline comments to D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes.
Aug 20 2019, 4:10 PM · Restricted Project, Restricted Project

Aug 19 2019

Prince781 added a comment to D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes.

I think we should send a defect report to the C++ standards committee to clarify the ambiguity here.

Aug 19 2019, 9:27 AM · Restricted Project, Restricted Project
Prince781 updated the diff for D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes.

I think this should order the initializers deterministically according to their var declaration order. Let me know if there's something I haven't considered.

Aug 19 2019, 9:00 AM · Restricted Project, Restricted Project

Aug 17 2019

Prince781 added a reviewer for D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes: efriedma.
Aug 17 2019, 10:18 AM · Restricted Project, Restricted Project

Aug 16 2019

Prince781 updated the diff for D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes.

Use range-based version of llvm::sort

Aug 16 2019, 4:22 PM · Restricted Project, Restricted Project
Prince781 updated the diff for D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes.

I've updated the patch to initialize, in the proper order, all foreign static TLS variables and the variables they depend on for initialization. I've also cleaned up the patch a bit.

Aug 16 2019, 3:39 PM · Restricted Project, Restricted Project

Aug 13 2019

Prince781 added a comment to D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes.

If variable A's initializer references variable B, then it will call B's initializer.

I don't think this patch adds any code that would address that, although I could be missing something.

Aug 13 2019, 9:42 AM · Restricted Project, Restricted Project

Aug 12 2019

Prince781 added a comment to D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes.

This might be a silly question, but what happens if the initializer for a thread-local variable refers to another thread-local variable? Do you need to initialize both variables? In what order?

Aug 12 2019, 7:41 PM · Restricted Project, Restricted Project
Prince781 updated the summary of D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes.
Aug 12 2019, 5:09 PM · Restricted Project, Restricted Project
Prince781 created D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes.
Aug 12 2019, 5:05 PM · Restricted Project, Restricted Project

Jul 18 2019

Prince781 added a comment to D64585: [OpenMP] With nested parallelism, threadprivate variables become shared on outer parallel when appearing in inner parallel copyin clause.

Fixed this bug myself to be sure it will be merged with 9.0 release, sorry.

Jul 18 2019, 12:50 PM · Restricted Project, Restricted Project

Jul 17 2019

Prince781 updated the diff for D64889: [OPENMP] getDSA(): handle loop control variables.

Added a lit test.

Jul 17 2019, 4:45 PM · Restricted Project, Restricted Project
Prince781 created D64889: [OPENMP] getDSA(): handle loop control variables.
Jul 17 2019, 3:20 PM · Restricted Project, Restricted Project

Jul 11 2019

Prince781 added inline comments to D64585: [OpenMP] With nested parallelism, threadprivate variables become shared on outer parallel when appearing in inner parallel copyin clause.
Jul 11 2019, 1:33 PM · Restricted Project, Restricted Project
Prince781 created D64585: [OpenMP] With nested parallelism, threadprivate variables become shared on outer parallel when appearing in inner parallel copyin clause.
Jul 11 2019, 1:19 PM · Restricted Project, Restricted Project