Page MenuHomePhabricator

PriMee (Pawel Maciocha)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 25 2017, 5:16 AM (120 w, 2 d)

Recent Activity

Sep 15 2017

PriMee added a comment to D37846: [clang-tidy] Fixed misc-unused-parameters omitting parameters square brackets.

Thank you!

Sep 15 2017, 4:12 AM · Restricted Project
PriMee added a comment to D37845: [clang-format] New flag - BraceWrapping.AfterExternBlock.

I would be grateful, thank you!

Sep 15 2017, 1:58 AM
PriMee updated the diff for D37846: [clang-tidy] Fixed misc-unused-parameters omitting parameters square brackets.

Done :)

Sep 15 2017, 1:17 AM · Restricted Project

Sep 14 2017

PriMee updated the diff for D37845: [clang-format] New flag - BraceWrapping.AfterExternBlock.

Thank you for noticing! Done.

Sep 14 2017, 10:21 AM
PriMee added a comment to D37846: [clang-tidy] Fixed misc-unused-parameters omitting parameters square brackets.

Diff will be updated as soon as possible.

Sep 14 2017, 5:51 AM · Restricted Project
PriMee updated the diff for D37845: [clang-format] New flag - BraceWrapping.AfterExternBlock.

Sorry, forgot again...

Sep 14 2017, 5:35 AM
PriMee retitled D37845: [clang-format] New flag - BraceWrapping.AfterExternBlock from [clang-format] New flag - BraceWrapping.AfterExternC to [clang-format] New flag - BraceWrapping.AfterExternBlock.
Sep 14 2017, 3:39 AM
PriMee updated the summary of D37845: [clang-format] New flag - BraceWrapping.AfterExternBlock.
Sep 14 2017, 3:13 AM
PriMee updated the diff for D37845: [clang-format] New flag - BraceWrapping.AfterExternBlock.

Done :)

Sep 14 2017, 3:11 AM
PriMee added a comment to D37846: [clang-tidy] Fixed misc-unused-parameters omitting parameters square brackets.

It turned out that removal range has to be even shorter than in https://reviews.llvm.org/D37566

Sep 14 2017, 1:49 AM · Restricted Project
PriMee created D37846: [clang-tidy] Fixed misc-unused-parameters omitting parameters square brackets.
Sep 14 2017, 1:48 AM · Restricted Project
PriMee created D37845: [clang-format] New flag - BraceWrapping.AfterExternBlock.
Sep 14 2017, 1:09 AM

Sep 12 2017

PriMee abandoned D37260: [clang-format] Fixed extern C brace wrapping.
Sep 12 2017, 2:17 AM
PriMee added a comment to D37260: [clang-format] Fixed extern C brace wrapping.

Great! I will work on it :)

Sep 12 2017, 2:16 AM
PriMee added a comment to D37260: [clang-format] Fixed extern C brace wrapping.

A new style, e.g. BraceWrapping.AfterExternC option is what we are considering right now. It would probably handle the problem. Leaving the line break as is might be indeed a bad idea :)

Sep 12 2017, 2:08 AM

Sep 11 2017

PriMee added a comment to D37260: [clang-format] Fixed extern C brace wrapping.

ping

Sep 11 2017, 3:19 AM
PriMee updated the diff for D37566: [clang-tidy] fixed misc-unused-parameters omitting parameters default value.

Done :) Could you please commit this for me?

Sep 11 2017, 12:32 AM · Restricted Project

Sep 8 2017

PriMee added a comment to D37140: [clang-format] Fixed one-line if statement .

Yes, would be great :) Thank you!

Sep 8 2017, 7:42 AM

Sep 7 2017

PriMee created D37566: [clang-tidy] fixed misc-unused-parameters omitting parameters default value.
Sep 7 2017, 6:00 AM · Restricted Project

Sep 6 2017

PriMee added inline comments to D37140: [clang-format] Fixed one-line if statement .
Sep 6 2017, 3:31 AM
PriMee updated the diff for D37140: [clang-format] Fixed one-line if statement .

Diff file again updated. Created against the newest commit.

Sep 6 2017, 3:26 AM

Sep 1 2017

PriMee added a reviewer for D37260: [clang-format] Fixed extern C brace wrapping: krasimir.

@krasimir Could you please tell me what did you mean in the comment:

I am still not convinced about the extern part: some clients might prefer the other style.

Do you suggest adding a new option, new style, like BraceWrapping.AfterExtern flag?

Sep 1 2017, 2:34 AM

Aug 31 2017

PriMee added a comment to D37140: [clang-format] Fixed one-line if statement .

Sorry for wrong formatting before. Some inline comments added.

Aug 31 2017, 3:32 AM
PriMee updated the diff for D37140: [clang-format] Fixed one-line if statement .

Diff file updated. Some tests added. Some new bugs fixed as well :)

Aug 31 2017, 3:18 AM

Aug 29 2017

PriMee added a comment to D37143: [clang-format] Fixed typedef enum brace wrapping.
Aug 29 2017, 6:42 AM
PriMee updated the diff for D37140: [clang-format] Fixed one-line if statement .

Unit tests added.

Aug 29 2017, 6:11 AM
PriMee added a comment to D37143: [clang-format] Fixed typedef enum brace wrapping.

I am glad to hear that. Would be great if someone could commit it. Thank You :)

Aug 29 2017, 5:47 AM
PriMee updated the diff for D37143: [clang-format] Fixed typedef enum brace wrapping.

Done.
Extern C part moved to: https://reviews.llvm.org/D37260

Aug 29 2017, 4:43 AM
PriMee retitled D37143: [clang-format] Fixed typedef enum brace wrapping from [clang-format] Fixed missing enter before bracket in typedef enum and extern to [clang-format] Fixed typedef enum brace wrapping.
Aug 29 2017, 4:42 AM
PriMee created D37260: [clang-format] Fixed extern C brace wrapping.
Aug 29 2017, 4:41 AM
PriMee updated the diff for D37143: [clang-format] Fixed typedef enum brace wrapping.

Unit tests added. If there is indeed a necessity to separate these two cases just inform me :)

Aug 29 2017, 1:24 AM

Aug 26 2017

PriMee added a comment to D37143: [clang-format] Fixed typedef enum brace wrapping.

I merged them just because of their presence in the same bug report... As to the unit tests, I'll add them as soon as possible.

Aug 26 2017, 2:01 AM

Aug 25 2017

PriMee updated the summary of D37143: [clang-format] Fixed typedef enum brace wrapping.
Aug 25 2017, 6:24 AM
PriMee created D37143: [clang-format] Fixed typedef enum brace wrapping.
Aug 25 2017, 6:03 AM
PriMee created D37140: [clang-format] Fixed one-line if statement .
Aug 25 2017, 5:42 AM