- User Since
- Aug 25 2017, 5:16 AM (120 w, 2 d)
Sep 15 2017
I would be grateful, thank you!
Sep 14 2017
Thank you for noticing! Done.
Diff will be updated as soon as possible.
Sorry, forgot again...
It turned out that removal range has to be even shorter than in https://reviews.llvm.org/D37566
Sep 12 2017
Great! I will work on it :)
A new style, e.g. BraceWrapping.AfterExternC option is what we are considering right now. It would probably handle the problem. Leaving the line break as is might be indeed a bad idea :)
Sep 11 2017
Done :) Could you please commit this for me?
Sep 8 2017
Yes, would be great :) Thank you!
Sep 7 2017
Sep 6 2017
Diff file again updated. Created against the newest commit.
Sep 1 2017
@krasimir Could you please tell me what did you mean in the comment:
I am still not convinced about the extern part: some clients might prefer the other style.
Do you suggest adding a new option, new style, like BraceWrapping.AfterExtern flag?
Aug 31 2017
Sorry for wrong formatting before. Some inline comments added.
Diff file updated. Some tests added. Some new bugs fixed as well :)
Aug 29 2017
Unit tests added.
I am glad to hear that. Would be great if someone could commit it. Thank You :)
Extern C part moved to: https://reviews.llvm.org/D37260
Unit tests added. If there is indeed a necessity to separate these two cases just inform me :)
Aug 26 2017
I merged them just because of their presence in the same bug report... As to the unit tests, I'll add them as soon as possible.