Page MenuHomePhabricator

Praetonus (Benoit Vey)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 22 2017, 2:30 PM (120 w, 3 d)

Recent Activity

Jul 11 2017

Praetonus added a comment to D35180: Expose the Clang::QualType to llvm::Type conversion functions.

I forgot to mention that I don't have commit access. If you or somebody else could commit this it would be great.

Jul 11 2017, 10:36 AM

Jul 9 2017

Praetonus updated the diff for D35180: Expose the Clang::QualType to llvm::Type conversion functions.

Patch updated to adhere to the coding style based on @majnemer's comments.

Jul 9 2017, 7:52 PM
Praetonus updated the diff for D35180: Expose the Clang::QualType to llvm::Type conversion functions.

Patch updated. I've made the convertFreeFunctionType return null on failure.

Jul 9 2017, 3:59 PM
Praetonus updated the diff for D35180: Expose the Clang::QualType to llvm::Type conversion functions.

Patch updated based on @rjmccall's comments. I removed the wrapper for the ConvertType function, after giving it some thoughts I don't see any use case for it, I guess I added it by default. I left the convertFreeFunction function as returning an llvm::Type instead of an llvm::FunctionType as ConvertFunctionType represents incomplete function types as empty aggregate types.

Jul 9 2017, 1:27 PM
Praetonus created D35180: Expose the Clang::QualType to llvm::Type conversion functions.
Jul 9 2017, 6:24 AM

Jul 5 2017

Praetonus added a comment to D34538: Handle ConstantExpr correctly in SelectionDAGBuilder.

Sorry, I forgot to mention that I don't have commit access. Could somebody commit this on my behalf?

Jul 5 2017, 10:09 AM

Jun 26 2017

Praetonus updated the diff for D34538: Handle ConstantExpr correctly in SelectionDAGBuilder.

I've added a comment describing the test case.

Jun 26 2017, 8:51 AM

Jun 22 2017

Praetonus updated the diff for D34538: Handle ConstantExpr correctly in SelectionDAGBuilder.

A test case has been added and the patch has been updated based on @efriedma's comments.

Jun 22 2017, 4:26 PM
Praetonus added a comment to D34538: Handle ConstantExpr correctly in SelectionDAGBuilder.

@efriedma Sorry for the test case, I did write one based on the reduced case from the PR, I'm not sure why SVN didn't include it in the diff. Anyway, I'll update to include it.

Jun 22 2017, 4:13 PM
Praetonus created D34538: Handle ConstantExpr correctly in SelectionDAGBuilder.
Jun 22 2017, 3:00 PM