Page MenuHomePhabricator

PatriosTheGreat (Levon Ter-Grigoryan)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 22 2019, 4:57 AM (87 w, 4 d)

Recent Activity

Jun 23 2021

PatriosTheGreat updated the diff for D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime..

Hi everyone.
Thanks for review.
In order to move new method code to Debugger class I also had to move there SetInputFile(lldb::FileSP file) method.
After I did that -- the reproducer tests started to fail.
If I understand correctly there is a problem to deserialize SBStream object during the reply session. In previous patch the replay tests pass since I was calling SetInputFile API method from SetInputStream.
To fix that in this patch I replaced SetInputStream method with SetInputData (const char* data, size_t size); which takes a raw chat array instead of SBStream.

Jun 23 2021, 1:31 AM · Restricted Project

Jun 18 2021

PatriosTheGreat updated the diff for D103271: [lldb/Target] Select most relevant frame only in case of signal.

Thanks for the review feedback.
Looks like moving frame recognizer call to StackFrameList::GetFramesUpTo also fixes infinity recursion issue.

Jun 18 2021, 4:00 AM · Restricted Project

Jun 16 2021

PatriosTheGreat requested review of D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime..
Jun 16 2021, 12:12 PM · Restricted Project

Jun 8 2021

PatriosTheGreat updated the diff for D103271: [lldb/Target] Select most relevant frame only in case of signal.

Thanks for your suggestions.
I tried both of them, however the solution to patch assert recognizer doesn’t solve the original performance issue. Since the performance degradation doesn’t come from the recognizer. It appears since the LLDB needs to unwind at least one stack frame for each thread in order to determine does the LLDB even need to run recognizers (see this line: https://github.com/llvm/llvm-project/blob/main/lldb/source/Target/Thread.cpp#L587)

Jun 8 2021, 8:15 AM · Restricted Project

Jun 1 2021

PatriosTheGreat updated the diff for D103271: [lldb/Target] Select most relevant frame only in case of signal.

Select most related frame only in threads which were stopped with reason.
This diff is for further discussion.

Jun 1 2021, 2:56 AM · Restricted Project

May 31 2021

PatriosTheGreat requested review of D103271: [lldb/Target] Select most relevant frame only in case of signal.

Thanks for feedback.

May 31 2021, 3:37 AM · Restricted Project

May 27 2021

PatriosTheGreat requested review of D103271: [lldb/Target] Select most relevant frame only in case of signal.
May 27 2021, 11:06 AM · Restricted Project

May 12 2020

PatriosTheGreat added a comment to D78654: Moving executable module symbols parsing to target creation method..

Hi Pavel
Thank you for review.

May 12 2020, 6:57 AM · Restricted Project

May 11 2020

PatriosTheGreat updated the diff for D78654: Moving executable module symbols parsing to target creation method..

Hi Pavel.

May 11 2020, 2:06 AM · Restricted Project
PatriosTheGreat updated the diff for D78654: Moving executable module symbols parsing to target creation method..
May 11 2020, 2:06 AM · Restricted Project

May 4 2020

PatriosTheGreat updated the diff for D78654: Moving executable module symbols parsing to target creation method..

I re-checked the behavior with the executable and this solution works without re-parsing. It seems like I mismatched logs previously.

May 4 2020, 6:54 AM · Restricted Project

Apr 30 2020

PatriosTheGreat updated the diff for D78654: Moving executable module symbols parsing to target creation method..
Apr 30 2020, 10:08 AM · Restricted Project
PatriosTheGreat added inline comments to D78654: Moving executable module symbols parsing to target creation method..
Apr 30 2020, 10:08 AM · Restricted Project
PatriosTheGreat updated the diff for D78654: Moving executable module symbols parsing to target creation method..

Hi Pavel.

Apr 30 2020, 5:39 AM · Restricted Project

Apr 28 2020

PatriosTheGreat updated the diff for D78654: Moving executable module symbols parsing to target creation method..

Currently m_platform->ResolveExecutable will create new module.
Moreover this method will add new module to SharedModuleList.

Apr 28 2020, 11:17 AM · Restricted Project

Apr 24 2020

PatriosTheGreat updated the diff for D78654: Moving executable module symbols parsing to target creation method..

Hi Pavel.

Apr 24 2020, 4:17 AM · Restricted Project

Apr 22 2020

PatriosTheGreat created D78654: Moving executable module symbols parsing to target creation method..
Apr 22 2020, 10:19 AM · Restricted Project

Feb 19 2020

PatriosTheGreat added a comment to D74217: Add target.xml support for qXfer request..

Hi Muhammad,
Thank you for review.
Could you or Pavel commit this to master, since I don't have commit access?

Feb 19 2020, 6:12 AM · Restricted Project

Feb 18 2020

PatriosTheGreat updated the diff for D74217: Add target.xml support for qXfer request..

In this revision I fix value_regnums and invalidate_regnums serialization in target.xml.
However I'm not so sure that this is the cause of problem with ARM tests.

Feb 18 2020, 8:17 AM · Restricted Project
PatriosTheGreat added a comment to D74217: Add target.xml support for qXfer request..

Hi Muhammad,

Feb 18 2020, 1:19 AM · Restricted Project

Feb 15 2020

PatriosTheGreat added a comment to D74217: Add target.xml support for qXfer request..

Hi Pavel,
Thank you for review.
Could you also commit this to master, since I don't have commit access?

Feb 15 2020, 6:26 AM · Restricted Project

Feb 12 2020

PatriosTheGreat updated the diff for D74217: Add target.xml support for qXfer request..
Feb 12 2020, 6:13 AM · Restricted Project
PatriosTheGreat updated the diff for D74217: Add target.xml support for qXfer request..
Feb 12 2020, 4:14 AM · Restricted Project

Feb 11 2020

PatriosTheGreat updated the diff for D74217: Add target.xml support for qXfer request..
Feb 11 2020, 11:28 AM · Restricted Project
PatriosTheGreat updated the diff for D74217: Add target.xml support for qXfer request..
Feb 11 2020, 2:33 AM · Restricted Project

Feb 7 2020

PatriosTheGreat updated the summary of D74217: Add target.xml support for qXfer request..
Feb 7 2020, 6:29 AM · Restricted Project
PatriosTheGreat created D74217: Add target.xml support for qXfer request..
Feb 7 2020, 6:12 AM · Restricted Project
PatriosTheGreat set the repository for D74217: Add target.xml support for qXfer request. to rG LLVM Github Monorepo.
Feb 7 2020, 6:12 AM · Restricted Project

Jan 13 2020

PatriosTheGreat added a comment to D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions.

Made clang-format with last update of diff.

Jan 13 2020, 2:34 AM · Restricted Project
PatriosTheGreat updated the diff for D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions.
Jan 13 2020, 2:34 AM · Restricted Project
PatriosTheGreat added inline comments to D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions.
Jan 13 2020, 2:16 AM · Restricted Project

Dec 20 2019

PatriosTheGreat updated the diff for D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions.
Dec 20 2019, 7:48 AM · Restricted Project

Dec 9 2019

PatriosTheGreat added a comment to D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions.

It seems like with this CL find-basic-functions logic became inconsistent for macos target and pc-linux.
In cases of pc-linux it returns no function with --function-flags=full flag and in macos it returns 7 functions.

Dec 9 2019, 3:18 AM · Restricted Project

Nov 29 2019

PatriosTheGreat created D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions.
Nov 29 2019, 3:19 AM · Restricted Project