Page MenuHomePhabricator

Origami404 (Tao Liang)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 28 2022, 11:12 PM (13 w, 2 d)

Recent Activity

Mon, Jan 23

Origami404 updated the diff for D142280: Restrict vector.type_cast to only cast to aligned multi-dim vectors.

Adjust doc and diag

Mon, Jan 23, 4:16 AM · Restricted Project, Restricted Project

Sat, Jan 21

Origami404 published D142280: Restrict vector.type_cast to only cast to aligned multi-dim vectors for review.
Sat, Jan 21, 3:39 AM · Restricted Project, Restricted Project

Dec 17 2022

Origami404 updated subscribers of D137343: [clang] add -Wvla-stack-allocation.

Hello, I am back now and will be available anytime next week, so if anyone has any idea on this topic, please at me!

Dec 17 2022, 6:38 PM · Restricted Project, Restricted Project
Origami404 updated the diff for D137343: [clang] add -Wvla-stack-allocation.

[clang] add -Wvla-stack-allocation and divide different VLA warning

Dec 17 2022, 6:38 PM · Restricted Project, Restricted Project

Dec 10 2022

Origami404 added a comment to D137343: [clang] add -Wvla-stack-allocation.
int foo(void);

void bar(int a, int b[*]); // variable length array used, correct
void bar(int a, int b[a]) { variable length array used, correct
  int x[foo()]; // variable length array that may require stack allocation used, correct

  (void)sizeof(int[foo()]); // variable length array that may require stack allocation used, incorrect and the diagnostic triggers twice

  int (*y)[foo()]; // variable length array that may require stack allocation used, incorrect, this is a pointer to a VLA
}
Dec 10 2022, 4:50 AM · Restricted Project, Restricted Project

Nov 30 2022

Origami404 added inline comments to D137043: [clang] add implicit include for Linux/gnu compatibility.
Nov 30 2022, 9:17 AM · Restricted Project, Restricted Project
Origami404 updated the diff for D137043: [clang] add implicit include for Linux/gnu compatibility.

Improved comments and release notes

Nov 30 2022, 9:13 AM · Restricted Project, Restricted Project

Nov 23 2022

Origami404 updated the diff for D137343: [clang] add -Wvla-stack-allocation.

Update release notes.

Nov 23 2022, 6:00 AM · Restricted Project, Restricted Project
Origami404 updated the diff for D137043: [clang] add implicit include for Linux/gnu compatibility.

Change implements according reviews.

Nov 23 2022, 4:23 AM · Restricted Project, Restricted Project

Nov 17 2022

Origami404 added a comment to D137043: [clang] add implicit include for Linux/gnu compatibility.

This include-if-exists mechanism seems brittle to me.

Nov 17 2022, 6:19 PM · Restricted Project, Restricted Project
Origami404 added a comment to D137043: [clang] add implicit include for Linux/gnu compatibility.

ping :)

Nov 17 2022, 7:28 AM · Restricted Project, Restricted Project
Origami404 added a comment to D137343: [clang] add -Wvla-stack-allocation.

ping :)

Nov 17 2022, 7:27 AM · Restricted Project, Restricted Project

Nov 3 2022

Origami404 published D137343: [clang] add -Wvla-stack-allocation for review.
Nov 3 2022, 10:10 AM · Restricted Project, Restricted Project

Oct 31 2022

Origami404 added a comment to D137043: [clang] add implicit include for Linux/gnu compatibility.

After digging more deeply into tests, I found that if we decide to make clang include stdc-predef.h or other things, the behavior of many libtooling-related tools (e.g. clang-tidy, clangd, and python binding) will be affected.

Oct 31 2022, 1:57 AM · Restricted Project, Restricted Project

Oct 30 2022

Origami404 updated the diff for D137043: [clang] add implicit include for Linux/gnu compatibility.

I'm sorry that my patch can not pass the CI test, but I can not reproduce the CI
failure loaclly, including clang-format related problems. On my machine,
ninja check-clang shows:

Oct 30 2022, 1:39 PM · Restricted Project, Restricted Project
Origami404 published D137043: [clang] add implicit include for Linux/gnu compatibility for review.
Oct 30 2022, 11:34 AM · Restricted Project, Restricted Project

Oct 28 2022

Origami404 updated Origami404.
Oct 28 2022, 11:13 PM