Page MenuHomePhabricator

OfekShilon (Ofek Shilon)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 1 2022, 12:56 PM (9 w, 2 h)

Recent Activity

Aug 13 2022

OfekShilon updated the diff for D131518: Make opt-viewer more usable by general developers - part 1/N.

Added cpp-example and python requirements files (and not .gitignore) to the CMakeList installation.

Aug 13 2022, 9:59 AM · Restricted Project, Restricted Project
OfekShilon updated the diff for D131518: Make opt-viewer more usable by general developers - part 1/N.

@fhahn You're right of course. I trimmed this patch to include just the added example and the two-line python requirements file. Hopefully this would be an easy approval and I'll add more gradual patches to be reviewed.

Aug 13 2022, 9:36 AM · Restricted Project, Restricted Project

Aug 10 2022

OfekShilon added a comment to D130933: Add docs for function attributes hot/cold.

@aaron.ballman 'Ofek Shilon', ofekshilon@gmail.com is fine.
Thanks!

Aug 10 2022, 10:45 AM · Restricted Project, Restricted Project
OfekShilon added a comment to D131518: Make opt-viewer more usable by general developers - part 1/N.

(1) As far as I can see the debian build failure has nothing to do with this diff:

...
unsupported_code_directive	1
unsupported_compiler_option	0
unsupported_source_language	0
🚨 Error: The command exited with status 1

Perhaps the build can be invoked again?

Aug 10 2022, 10:22 AM · Restricted Project, Restricted Project
OfekShilon updated the diff for D130933: Add docs for function attributes hot/cold.

My apologies for the mess, hopefully the diff I just uploaded includes all the right fixes.

Aug 10 2022, 10:07 AM · Restricted Project, Restricted Project

Aug 9 2022

OfekShilon added a comment to D130933: Add docs for function attributes hot/cold.
Aug 9 2022, 1:38 PM · Restricted Project, Restricted Project
OfekShilon requested review of D131518: Make opt-viewer more usable by general developers - part 1/N.
Aug 9 2022, 1:24 PM · Restricted Project, Restricted Project
OfekShilon updated the diff for D130933: Add docs for function attributes hot/cold.

Addressed Aaron's comments (thanks!). Hope I got the update-diff procedure right.
I don't have commit permissions, would appreciate if someone could push this.

Aug 9 2022, 12:30 PM · Restricted Project, Restricted Project

Aug 1 2022

OfekShilon requested review of D130933: Add docs for function attributes hot/cold.
Aug 1 2022, 1:24 PM · Restricted Project, Restricted Project