Thanks, LGTM!

ping #3

Hello, can anyone help commit this patch? Thanks!

ping #2

A gentle ping :-)

Removed the AllowEmptyParameter parameter.

Thanks all for the inputs!

In D141650#4056383, @lebedev.ri wrote:

In D141650#4055313, @Nuullll wrote:

Thanks a lot for reviewing!

@lebedev.ri

1. Do we need that parameter? Is empty <parameters> list generally ill-formed and must be diagnosed?

There's one subtle difference in AArch64 and X86 VFABI documentations about Vector Function Name Mangling: the X86 doc explicitly allows an empty parameter list while the AArch64 doc doesn't -- so I think this is why we need a parameter to let users choose whatever standard to conform. In fact, our internal implementation has to remove the diagnostic on empty parameter from tryDemangleForVFABI to make sure we're conforming the X86 VFABI.

Nitpick: would it be possible to simply ask AArch64 for clarification, what is the intended behaviour for them?

Thanks a lot for reviewing!

Thanks for this. I planned something similar to turn string literal typo errors into compile errors as well.
The typos are really hard to identify :-P

Thanks all for leaving the comments. I agree with you.

Fix AMDGPU llc-pipeline test

Preserve analysis for new pass manager.

In D103678#2811302, @HazardyKnusperkeks wrote:

Do you need some one to commit this? If yes please state name and email, some one will chime in to commit it.

Yes, please someone help commit this.

Minor updates.

Pre-check failure: the github server is currently down.

Add more tests.

In D103589#2796032, @curdeius wrote:

LGTM. Thanks for fixing this!
Do you have commit rights or you need somebody to land it for you?

In D103589#2795447, @curdeius wrote:

Thanks for looking into this, but please add a test case that demonstrates the bug to FormatTests.cpp
Also, is there, by any chance, an associated bugzilla ticket?

Add test.

In D100446#2756430, @djtodoro wrote:

In D100446#2756413, @Nuullll wrote:

Ah, this is my first time trying to make a llvm contribution.
What shall I do next to get my patch landed?

Thanks for this!
I can commit this for you (with your name in the 'Patch by' sign) in the case you don't have commit access yet?

Ah, this is my first time trying to make a llvm contribution.
What shall I do next to get my patch landed?

Removed useless attributes in the test.