Page MenuHomePhabricator

Nicholas-Baron (Nicholas Baron)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 21 2020, 3:51 PM (37 w, 5 d)

Recent Activity

Jul 23 2020

Nicholas-Baron added inline comments to D84275: [Libcxx] Finish implementing Paper 0202R3.
Jul 23 2020, 3:47 PM · Restricted Project
Nicholas-Baron updated the diff for D84275: [Libcxx] Finish implementing Paper 0202R3.

Used TEST_CONSTEXPR on the merge and rotate_copy tests.

Jul 23 2020, 3:44 PM · Restricted Project
Nicholas-Baron updated the diff for D84275: [Libcxx] Finish implementing Paper 0202R3.

Decomposed asserts in tests

Jul 23 2020, 1:07 PM · Restricted Project
Nicholas-Baron updated the diff for D84275: [Libcxx] Finish implementing Paper 0202R3.

Applied constexpr testing conventions suggested by @zoecarver.

Jul 23 2020, 12:32 PM · Restricted Project

Jul 22 2020

Nicholas-Baron added a comment to D84275: [Libcxx] Finish implementing Paper 0202R3.

The builds are failing with this line standing out
ld.lld: error: unable to find library -lcxxabi_shared

Jul 22 2020, 8:37 PM · Restricted Project
Nicholas-Baron updated the diff for D84275: [Libcxx] Finish implementing Paper 0202R3.

Passed tests and made one internal function constexpr

Jul 22 2020, 5:18 PM · Restricted Project
Nicholas-Baron updated the diff for D84275: [Libcxx] Finish implementing Paper 0202R3.

Removed parts covered in https://reviews.llvm.org/D65721 and uncommented a test.

Jul 22 2020, 2:43 PM · Restricted Project
Nicholas-Baron added a comment to D84275: [Libcxx] Finish implementing Paper 0202R3.

[...]
Also, this appears to have some overlap with https://reviews.llvm.org/D65721. Perhaps you can coordinate with @zoecarver and pick up the work in D65721?

Jul 22 2020, 1:55 PM · Restricted Project

Jul 21 2020

Nicholas-Baron added a comment to D84275: [Libcxx] Finish implementing Paper 0202R3.

I see no tests.

Jul 21 2020, 6:20 PM · Restricted Project
Herald added a reviewer for D84275: [Libcxx] Finish implementing Paper 0202R3: Restricted Project.
Jul 21 2020, 4:29 PM · Restricted Project