Page MenuHomePhabricator

Nebiroth (William Enright)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 21 2017, 12:55 PM (95 w, 3 d)

Recent Activity

Jan 23 2018

Nebiroth added inline comments to D39571: [clangd] DidChangeConfiguration Notification.
Jan 23 2018, 12:36 PM

Dec 21 2017

Nebiroth updated the diff for D38639: [clangd] #include statements support for Open definition.
Minor code cleanup
Dec 21 2017, 9:11 AM

Dec 20 2017

Nebiroth added a comment to D41365: [clang] Add BeforeExecute method to PrecompiledPreamble.

Yes please land this.

Dec 20 2017, 7:05 AM
Nebiroth updated the diff for D41365: [clang] Add BeforeExecute method to PrecompiledPreamble.

Updated BeforeExecute comment

Dec 20 2017, 6:53 AM

Dec 19 2017

Nebiroth updated the diff for D41365: [clang] Add BeforeExecute method to PrecompiledPreamble.

Modified comment
Changed where BeforeExecute is called

Dec 19 2017, 4:06 PM
Nebiroth updated the diff for D38639: [clangd] #include statements support for Open definition.
Removed some useless inclusions
Removed superfluous check when inserting data in map
Moved addition to DeclarationLocations in finish() outside of DeclMacrosFinder
Merged with revision 321087 (moved findDefinitions and findDocumentHighlights
Dec 19 2017, 3:55 PM
Nebiroth added inline comments to D38639: [clangd] #include statements support for Open definition.
Dec 19 2017, 2:15 PM

Dec 18 2017

Nebiroth updated the diff for D35894: [clangd] Code hover for Clangd.
findHover properly returns an error
Removed many cases of bad merging
Separated getHover in two functions
Minor indenting and NIT fixes
Dec 18 2017, 2:13 PM
Nebiroth added inline comments to D35894: [clangd] Code hover for Clangd.
Dec 18 2017, 1:54 PM
Nebiroth created D41365: [clang] Add BeforeExecute method to PrecompiledPreamble.
Dec 18 2017, 11:29 AM
Nebiroth updated the diff for D38639: [clangd] #include statements support for Open definition.
CppFilePreambleCallbacks no longer extends PPCallbacks
CppFilePreambleCallbacks no longer needs SourceManager parameter
Removed temporary vector TempPreambleIncludeLocations
IncludeReferenceMap in ParsedAST no longer passed by reference
Code handling includes outside of preambles is now separated in IncludeRefsCollector class
Removed addLocation
Changed isSameLine function name and now checks if searched location is in range instead of verifying the line
Removed changes to findDefinitions interface
Dec 18 2017, 10:31 AM

Dec 15 2017

Nebiroth updated the diff for D38639: [clangd] #include statements support for Open definition.

inner class IncludeReferenceMap replaced by one map
fillRangeVector() and findPreambleIncludes() code moved into wrapper class
Open definition now returns an empty Range struct (line, character = 0)
Fixed unit tests
Minor code improvements

Dec 15 2017, 10:58 AM
Nebiroth updated the diff for D35894: [clangd] Code hover for Clangd.

Rebase on master

Dec 15 2017, 7:24 AM

Dec 14 2017

Nebiroth updated the diff for D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble..

Minor code cleanup

Dec 14 2017, 9:43 AM
Nebiroth updated the diff for D39571: [clangd] DidChangeConfiguration Notification.

Removed test file
Added mutex lock when changing CDB
Minor code cleanup

Dec 14 2017, 9:06 AM

Dec 11 2017

Nebiroth updated the diff for D39571: [clangd] DidChangeConfiguration Notification.

Removed some more empty lines

Dec 11 2017, 2:31 PM
Nebiroth updated the diff for D39571: [clangd] DidChangeConfiguration Notification.

Merged with latest llvm + clang
Minor code cleanup

Dec 11 2017, 2:25 PM
Nebiroth updated the diff for D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble..

Removed unique_ptr parameter in PrecompiledPreamble::Build
Added method createPPCallbacks() in PreambleCallback to be overriden

Dec 11 2017, 12:58 PM
Nebiroth updated the diff for D38639: [clangd] #include statements support for Open definition.
Creating unique_ptr for wrapper class now uses overriden method createPPCallbacks() from PrecompiledPreamble class
Moved wrapper class to inline inside createPPCallbacks()
Wrapper class now uses CppFilePreambleCallbacks as field
Dec 11 2017, 12:55 PM
Nebiroth added a comment to D38425: [clangd] Document highlights for clangd.

@ilya-biryukov Need someone to land this.

Dec 11 2017, 8:20 AM
Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.

Merged with latest llvm/clang
Minor code cleanup

Dec 11 2017, 8:19 AM

Dec 8 2017

Nebiroth added inline comments to D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble..
Dec 8 2017, 6:42 AM

Dec 7 2017

Nebiroth added inline comments to D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble..
Dec 7 2017, 11:32 AM

Dec 6 2017

Nebiroth updated the diff for D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble..

Reverted formatting changes to ASTUnit

Dec 6 2017, 2:19 PM
Nebiroth updated the diff for D38639: [clangd] #include statements support for Open definition.

Fixed re-added include

Dec 6 2017, 2:17 PM
Nebiroth updated the diff for D38639: [clangd] #include statements support for Open definition.

Using PPCallbacks interface to find non-preamble includes
Created inner class to store vectors in to find locations
Refactored methods to remove some unnecessary parameters
Refactored Unit tests
Merge with most recent master branch + clang

Dec 6 2017, 2:15 PM

Dec 5 2017

Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.

Added static_cast when unparsing

Dec 5 2017, 2:44 PM
Nebiroth added inline comments to D38639: [clangd] #include statements support for Open definition.
Dec 5 2017, 2:16 PM
Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.

Added error returns in findDocumentHighlights
Ran clang-format on ClangdUnit.h, .cpp and ClangdServer.cpp

Dec 5 2017, 6:59 AM

Dec 4 2017

Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.

Minor code cleanup
Refactored findDocumentHighlights() to make tests pass when assertions are enabled

Dec 4 2017, 8:11 AM

Dec 1 2017

Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.

Minor code cleanup
unparse and parse methods for JSON are updated

Dec 1 2017, 2:54 PM
Nebiroth updated the diff for D35894: [clangd] Code hover for Clangd.

Minor code cleanup
Merge with master

Dec 1 2017, 2:19 PM
Nebiroth added inline comments to D35894: [clangd] Code hover for Clangd.
Dec 1 2017, 1:42 PM
Nebiroth added inline comments to D35894: [clangd] Code hover for Clangd.
Dec 1 2017, 1:19 PM

Nov 30 2017

Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.
Minor code cleanup
getDeclarationLocation now returns llvm::Optional
operator< for DocumentHighlight struct now properly compares the kind field
Nov 30 2017, 8:51 AM
Nebiroth updated the diff for D35894: [clangd] Code hover for Clangd.
Simplified getHover() function
Proper usage of ErrorOr to return errors
Given range for Hover struct now only applies to the open file
Fixed crash on MacroExpansion
Nov 30 2017, 8:07 AM

Nov 29 2017

Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.

Fixed wrong content header making the test fail

Nov 29 2017, 3:30 PM
Nebiroth updated the diff for D35894: [clangd] Code hover for Clangd.

Invalid FileEntries now return llvm:ErrorOr

Nov 29 2017, 3:14 PM
Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.

Added verification for llvm::Expected in onDocumentHighlight
Removed unused variable in ClangdUnit

Nov 29 2017, 1:44 PM

Nov 27 2017

Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.

Minor code cleanup
Fixed highlights sometimes obtaining one too many characters inside range
Updated test

Nov 27 2017, 1:33 PM
Nebiroth added inline comments to D39571: [clangd] DidChangeConfiguration Notification.
Nov 27 2017, 10:20 AM
Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.

Removed temporary test file
Updated test to account for read-access symbol verification

Nov 27 2017, 8:37 AM

Nov 24 2017

Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.

Fixed test checking for values from an incorrect bit shift

Nov 24 2017, 1:04 PM
Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.

Fixed a few outstanding issues that were reported as completed

Nov 24 2017, 10:21 AM
Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.

Getting DocumentHighlightKind is now done in DocumentHighlightsFinder
Removed duplicated and unused code
Refactored method and variable names

Nov 24 2017, 9:43 AM
Nebiroth added inline comments to D38425: [clangd] Document highlights for clangd.
Nov 24 2017, 9:29 AM

Nov 23 2017

Nebiroth updated the diff for D35894: [clangd] Code hover for Clangd.

Minor code cleanup and improvements
getRawCommentForDeclNoCache() now called for every Decl and only once per Decl
getHover() now properly handles templates

Nov 23 2017, 3:01 PM

Nov 22 2017

Nebiroth added inline comments to D39571: [clangd] DidChangeConfiguration Notification.
Nov 22 2017, 4:35 PM
Nebiroth updated the diff for D39571: [clangd] DidChangeConfiguration Notification.

Fixed DraftStore thread-safe API being broken
Removed superfluous getCompilationDatabase call
Changed name of struct to ClangDConfigurationParamsChange
Removed operator ! overload for struct
Minor code cleanup

Nov 22 2017, 4:33 PM
Nebiroth updated the diff for D35894: [clangd] Code hover for Clangd.

Removed accidentally included files
Fixed some coding standard issues
Removed getDeclarationLocation declaration from header file
Replaced getFunctionComments with clang implementation
onCodeHover now follows error-reporting pattern

Nov 22 2017, 9:24 AM

Nov 21 2017

Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.

Removed some commented lines and temporary code
Streamlined and removed some code that overlaps/conflicts with code hover patch so it's easier to merge (patch D35894)

Nov 21 2017, 1:59 PM

Nov 20 2017

Nebiroth added a comment to D35894: [clangd] Code hover for Clangd.

Forgot to mention this last patch also added support for displaying function comments above the function definition displayed.

Nov 20 2017, 6:40 PM
Nebiroth updated the diff for D35894: [clangd] Code hover for Clangd.

Removed all std::pair objects
Fixed and updated all tests
findHover doesn't call findDefinitions anymore
DeclarationLocationsFinder fills two Decl and MacroInfos vectors instead of giving out Location objects
Removed constructors for structs MarkedString and Hover
Moved code modifying SourceRange for hover into getHover()

Nov 20 2017, 2:50 PM

Nov 17 2017

Nebiroth added inline comments to D35894: [clangd] Code hover for Clangd.
Nov 17 2017, 11:33 AM
Nebiroth added inline comments to D35894: [clangd] Code hover for Clangd.
Nov 17 2017, 10:03 AM

Nov 15 2017

Nebiroth updated the diff for D39571: [clangd] DidChangeConfiguration Notification.

Added test for didChangeConfiguration notification.
Compilation database and extra file flags are now properly reloaded when changing database path.
ClangdConfigurationParams now used instead of map.
changeConfiguration removed from ClangdServer. This class will now handle more specific settings.
Added more checks when parsing notification from client..

Nov 15 2017, 12:18 PM

Nov 14 2017

Nebiroth added inline comments to D39571: [clangd] DidChangeConfiguration Notification.
Nov 14 2017, 2:08 PM

Nov 10 2017

Nebiroth added a comment to D38425: [clangd] Document highlights for clangd.

This updated patch still does not handle highlighting macro references correctly. I will make another patch at a later time for this issue.

Nov 10 2017, 2:55 PM
Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.

Decls and MacroInfos vectors are now private and passed by reference instead of copied.
DeclarationLocationsFinder does not store Locations anymore, instead the vector is filled in their respective methods in ClangdUnit.cpp
Refactored if condition
Removed redundant newlines at end of test file.

Nov 10 2017, 2:16 PM
Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.
  • Decls and MacroInfos vectors are now private and passed by reference instead of copied.
Nov 10 2017, 2:16 PM

Nov 8 2017

Nebiroth added inline comments to D39571: [clangd] DidChangeConfiguration Notification.
Nov 8 2017, 2:15 PM

Nov 2 2017

Nebiroth created D39571: [clangd] DidChangeConfiguration Notification.
Nov 2 2017, 2:44 PM

Oct 30 2017

Nebiroth added a comment to D35894: [clangd] Code hover for Clangd.

I also have a quick patch that supports displaying comments preceding the declaration of a function. Once the review comments have been addressed for this revision I will submit it.

Oct 30 2017, 2:38 PM
Nebiroth updated the diff for D35894: [clangd] Code hover for Clangd.

Code hover now displays declaration of symbol instead of source code by default.
Code hover now displays context information such as namespace and class name.
Array of MarkedString objects is now sent as response in JSON.

Oct 30 2017, 2:34 PM

Oct 27 2017

Nebiroth added a parent revision for D38639: [clangd] #include statements support for Open definition: D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble..
Oct 27 2017, 2:09 PM
Nebiroth added a child revision for D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.: D38639: [clangd] #include statements support for Open definition.
Oct 27 2017, 2:09 PM
Nebiroth created D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble..
Oct 27 2017, 8:38 AM

Oct 26 2017

Nebiroth updated the diff for D38639: [clangd] #include statements support for Open definition.
  • Fixed adding incorrect test file.
Oct 26 2017, 2:00 PM
Nebiroth updated the diff for D38639: [clangd] #include statements support for Open definition.
  • Now overriding InclusionDirective as a callback to get proper includes information.
  • Fixed tests.
Oct 26 2017, 1:58 PM

Oct 23 2017

Nebiroth added a comment to D35894: [clangd] Code hover for Clangd.

I think he meant to have multiple sections in the hover, one C/C++ and one not. But we noticed you can have an array of MarkedString in Hover so it should be fine.

I totally misunderstood the question. Good to know it all works without changing the LSP.
Just to make sure I got it right this time: the use-case is to, e.g., return both a code snippet (having "language": cpp) and a documentation string (without language) as a result of hover request?

Oct 23 2017, 8:17 AM

Oct 16 2017

Nebiroth added inline comments to D38639: [clangd] #include statements support for Open definition.
Oct 16 2017, 1:51 PM

Oct 12 2017

Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.

Addressed review comments.
Fixed some tests not having updated providers.
Removed TargetDeclarationFinder for less code reuse.
DocumentHighlight struct is now unparsed correctly.

Oct 12 2017, 1:50 PM

Oct 11 2017

Nebiroth added inline comments to D38425: [clangd] Document highlights for clangd.
Oct 11 2017, 1:55 PM
Nebiroth added a comment to D35894: [clangd] Code hover for Clangd.

Bumping this.

Oct 11 2017, 11:47 AM
Nebiroth added inline comments to D38425: [clangd] Document highlights for clangd.
Oct 11 2017, 10:38 AM

Oct 10 2017

Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.

Rebased on master.

Oct 10 2017, 2:36 PM

Oct 6 2017

Nebiroth updated the diff for D38639: [clangd] #include statements support for Open definition.

Fixed accidental removal of CheckSourceHeaderSwitch test

Oct 6 2017, 11:19 AM
Nebiroth created D38639: [clangd] #include statements support for Open definition.
Oct 6 2017, 11:11 AM

Oct 2 2017

Nebiroth updated the diff for D38425: [clangd] Document highlights for clangd.

Addressed initial comments.
Formatted ClangdUnit.h

Oct 2 2017, 7:57 AM
Nebiroth added a comment to D37150: [clangd] Command line arg to specify compile_commands.json path.

Thanks for fixing the last comment.
Do you want me to land this for you?

Oct 2 2017, 7:19 AM
Nebiroth updated the diff for D37150: [clangd] Command line arg to specify compile_commands.json path.

Improved logging message when unable to find compilation database in specified overriden directory.

Oct 2 2017, 7:07 AM
Nebiroth updated the diff for D37150: [clangd] Command line arg to specify compile_commands.json path.

Changed placement of logging instruction to reduce logging output.

Oct 2 2017, 6:10 AM
Nebiroth updated the diff for D37150: [clangd] Command line arg to specify compile_commands.json path.

Fixed changes that were lost while merging with head.

Oct 2 2017, 5:09 AM

Sep 29 2017

Nebiroth updated the diff for D37150: [clangd] Command line arg to specify compile_commands.json path.

Fixed missed comments and suggstions.

Sep 29 2017, 2:01 PM
Nebiroth created D38425: [clangd] Document highlights for clangd.
Sep 29 2017, 1:28 PM

Sep 28 2017

Nebiroth added inline comments to D37150: [clangd] Command line arg to specify compile_commands.json path.
Sep 28 2017, 6:20 AM

Sep 25 2017

Nebiroth updated the diff for D37150: [clangd] Command line arg to specify compile_commands.json path.

Fixed inverted compile_commands check logic that made tests fail.
More readable command arg checks.

Sep 25 2017, 7:52 AM
Nebiroth added a comment to D36150: [clangd] LSP extension to switch between source/header file.

Looks good.
Do you want me to submit this patch for you?

Sep 25 2017, 6:25 AM

Sep 22 2017

Nebiroth updated the diff for D36150: [clangd] LSP extension to switch between source/header file.

Rebased on latest version.
Corrected code style issues in test file.

Sep 22 2017, 12:35 PM

Sep 21 2017

Nebiroth updated the diff for D37150: [clangd] Command line arg to specify compile_commands.json path.

More consistent logging in clangdmain.
Restructured argument checking in ClangdMain
Fixed empty compile-commands-dir triggering error messages.
Fixed failing standard tests.

Sep 21 2017, 8:35 AM

Sep 20 2017

Nebiroth updated the diff for D36150: [clangd] LSP extension to switch between source/header file.

Added unit test.

Sep 20 2017, 11:21 AM

Sep 19 2017

Nebiroth added a comment to D36150: [clangd] LSP extension to switch between source/header file.

Overall looks good, but still needs at least a few tests.

Sep 19 2017, 2:24 PM

Sep 15 2017

Nebiroth updated the diff for D37150: [clangd] Command line arg to specify compile_commands.json path.

Fixed a few comments.
Rebased on latest clangd version.

Sep 15 2017, 12:46 PM

Sep 11 2017

Nebiroth updated the diff for D37150: [clangd] Command line arg to specify compile_commands.json path.

Simpilified a pointer return value.

Sep 11 2017, 12:43 PM
Nebiroth updated the diff for D36150: [clangd] LSP extension to switch between source/header file.

Return value when no file is found is now an empty string instead of file://
Minor code style changes and cleanup.
Ran clang-format on ClangdServer.h

Sep 11 2017, 12:31 PM
Nebiroth added inline comments to D36150: [clangd] LSP extension to switch between source/header file.
Sep 11 2017, 12:04 PM

Sep 8 2017

Nebiroth updated the diff for D36150: [clangd] LSP extension to switch between source/header file.

Ran clang-format on modified files.
Minor refactoring.

Sep 8 2017, 1:18 PM
Nebiroth updated the diff for D37150: [clangd] Command line arg to specify compile_commands.json path.

Ran clang-format on modified files.
More minor refactoring.

Sep 8 2017, 8:59 AM

Sep 7 2017

Nebiroth updated the diff for D37150: [clangd] Command line arg to specify compile_commands.json path.

Modified CompileCommandsDir to only look in the specified path if the value is set.
Moved CompileCommandsDir field to DirectoryBasedGlobalCompilationDatabase class.
Minor refactoring.

Sep 7 2017, 10:09 AM

Sep 6 2017

Nebiroth updated the diff for D36150: [clangd] LSP extension to switch between source/header file.

Some more code cleanup.

Sep 6 2017, 12:42 PM