Page MenuHomePhabricator

NSProgrammer (Nolan O'Brien)


User does not belong to any projects.

User Details

User Since
Nov 7 2018, 8:17 AM (98 w, 9 h)

Recent Activity

May 10 2019

NSProgrammer accepted D61756: Add a __FILE_NAME__ macro..
May 10 2019, 4:12 PM · Restricted Project

May 8 2019

NSProgrammer added a comment to D17741: adds __FILE_BASENAME__ builtin macro.

If the author is still missing at the end of next week, any objections to me resubmitting a similar patch that just implements __FILE_NAME__ or __BASE_NAME__ (Need a few more opinions here I guess, personally I think __FILE_NAME__ makes more sense)?

I'll carve it out from my PP extension which simply looks for the last path separator (depending on the OS) and only renders the filename after it (or the whole path if there's no separator). No need for additional complications like depths etc. Since this idea was shot down last time, is it possible to get a few people to voice their opinion before I mark this as abandoned and carve out and clean up this from my PP extension and add proper tests for it?

Would be appreciated, as this sort of thing is very useful (IMO) so would like to know if anyone is really against this proposal.

May 8 2019, 9:20 AM

Feb 22 2019

NSProgrammer added a comment to D17741: adds __FILE_BASENAME__ builtin macro.

We would prefer a macro like __FILE_NAME__ over a build flag for code reading consistency (they would clearly do different things vs varying based on an obscure flag being present/absent). (This contradicts my previous statement of having no preference since discussing it more, the macro approach would actually be preferable, but either is acceptable).

Feb 22 2019, 9:49 AM

Jan 3 2019

NSProgrammer added a comment to D17741: adds __FILE_BASENAME__ builtin macro.

To throw in my 2 cents. I don’t really have a preference between a compiler flag vs a different macro that’s just for the file name sans path prefix. But I have a real need for this to get into clang: with 1.2 million lines of code, the regular placement of log statements and custom asserts leads to megabytes in binary size from all the FILE usages, and that could easily be a few hundred KB with this kind of support in clang.

Jan 3 2019, 7:41 AM

Nov 7 2018

NSProgrammer awarded D17741: adds __FILE_BASENAME__ builtin macro a Like token.
Nov 7 2018, 8:18 AM