Page MenuHomePhabricator

MuAlphaOmegaEpsilon (Tommaso Bonvicini)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 4 2022, 9:47 AM (19 w, 1 d)

Recent Activity

Jan 27 2022

MuAlphaOmegaEpsilon added a comment to D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions.

LGTM! The CI failure is finally down to just an unrelated one (yay?). Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution?

Great! 🎉
I've never committed on the LLVM repository, so I don't know the requirements. If it doesn't bother you, feel free to commit on my behalf using the following:
MuAlphaOmegaEpsilon <tommasobonvicini@gmail.com>

Thank you very much Aaron! 😀

Sorry about the delay in getting this landed (it slipped beneath my radar). I've commit on your behalf in ccce1a03c9ce9c3917b310097c89e39bb68527e2. Thank you for the fix!

Jan 27 2022, 11:08 AM · Restricted Project, Restricted Project

Jan 20 2022

MuAlphaOmegaEpsilon added a comment to D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions.

LGTM! The CI failure is finally down to just an unrelated one (yay?). Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution?

Jan 20 2022, 11:27 AM · Restricted Project, Restricted Project

Jan 16 2022

MuAlphaOmegaEpsilon added a comment to D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions.

Let me know if I should rebase this onto the latest main branch, at the moment the Windows build is passing but the Debian build is not, failing at compiler-rt/test/sanitizer_common/tsan-x86_64-Linux/Linux/Output/decorate_proc_maps.cpp for no immediately apparent reason.

Jan 16 2022, 3:49 AM · Restricted Project, Restricted Project

Jan 14 2022

MuAlphaOmegaEpsilon added inline comments to D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions.
Jan 14 2022, 2:15 PM · Restricted Project, Restricted Project
MuAlphaOmegaEpsilon updated the diff for D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions.

Update warning amount on CHECK-unused check

Jan 14 2022, 2:07 PM · Restricted Project, Restricted Project
MuAlphaOmegaEpsilon added a comment to D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions.

The warning would be correct if the compiler could actually tell the parameter is unused, but at the moment it cannot, as far as I know.

Jan 14 2022, 1:39 PM · Restricted Project, Restricted Project
MuAlphaOmegaEpsilon updated the diff for D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions.

Fix failing test by updating clang/test/Sema/warn-unused-parameters.c expected warnings amount

Jan 14 2022, 11:04 AM · Restricted Project, Restricted Project
MuAlphaOmegaEpsilon added a comment to D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions.

The changes look good aside from the precommit CI failing. Can you investigate?

Absolutely, I'm already giving a look at it! :)

Jan 14 2022, 10:34 AM · Restricted Project, Restricted Project

Jan 13 2022

MuAlphaOmegaEpsilon updated the diff for D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions.

Update code after review and add tests

Jan 13 2022, 2:38 PM · Restricted Project, Restricted Project

Jan 8 2022

MuAlphaOmegaEpsilon updated the summary of D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions.
Jan 8 2022, 3:08 PM · Restricted Project, Restricted Project
MuAlphaOmegaEpsilon added reviewers for D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions: alexfh, hokein, lebedev.ri, rsmith, pirama.
Jan 8 2022, 9:23 AM · Restricted Project, Restricted Project

Jan 7 2022

MuAlphaOmegaEpsilon updated the diff for D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions.

Rebased to more recent main branch, updated comment

Jan 7 2022, 9:50 AM · Restricted Project, Restricted Project

Jan 6 2022

MuAlphaOmegaEpsilon requested review of D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions.
Jan 6 2022, 4:23 PM · Restricted Project, Restricted Project