In D116778#3276421, @aaron.ballman wrote:

In D116778#3259189, @MuAlphaOmegaEpsilon wrote:

In D116778#3255414, @aaron.ballman wrote:

LGTM! The CI failure is finally down to just an unrelated one (yay?). Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution?

Great! 🎉
I've never committed on the LLVM repository, so I don't know the requirements. If it doesn't bother you, feel free to commit on my behalf using the following:
MuAlphaOmegaEpsilon <tommasobonvicini@gmail.com>

Thank you very much Aaron! 😀

Sorry about the delay in getting this landed (it slipped beneath my radar). I've commit on your behalf in ccce1a03c9ce9c3917b310097c89e39bb68527e2. Thank you for the fix!

In D116778#3255414, @aaron.ballman wrote:

LGTM! The CI failure is finally down to just an unrelated one (yay?). Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution?

Let me know if I should rebase this onto the latest main branch, at the moment the Windows build is passing but the Debian build is not, failing at compiler-rt/test/sanitizer_common/tsan-x86_64-Linux/Linux/Output/decorate_proc_maps.cpp for no immediately apparent reason.

Update warning amount on CHECK-unused check

The warning would be correct if the compiler could actually tell the parameter is unused, but at the moment it cannot, as far as I know.

Fix failing test by updating clang/test/Sema/warn-unused-parameters.c expected warnings amount

In D116778#3244233, @aaron.ballman wrote:

The changes look good aside from the precommit CI failing. Can you investigate?

Absolutely, I'm already giving a look at it! :)

Update code after review and add tests

Rebased to more recent main branch, updated comment