Rebased onto master

Some tests were failing, I'll try to fix that and then commit the changes.

Initialize bool flags

Rebased onto master, run tests again

In D94475#2493513, @jrtc27 wrote:

Looking at the original motivation for the patch I'm not convinced that llvm-readelf etc shouldn't just fall back on displaying the "normal" set of GNU extensions even for ELFOSABI_NONE (i.e. those that FreeBSD and GNU have in common). Things like that are really just part of de-facto generic ELF these days. What does binutils do?

In D94475#2493461, @MaskRay wrote:

This is known. GNU as by default emits ELFOSABI_NONE on Linux - if it does not use any GNU extensioin. If the assembly uses STT_GNU_IFUNC/STB_GNU_UNIQUE, GNU as will switch to ELFOSABI_GNU.

The patch improves the few cases but regresses other cases, so I am requesting changes. It is also unclear whether respecting the GNU behavior is strictly necessary (see gold https://sourceware.org/bugzilla/show_bug.cgi?id=17735). STT_GNU_IFUNC is GNU extension and it is adopted by some other OSes. I am not sure the readelf -S output is a justifying reason for this change.

Fixed clang-format error

Thanks for the review! Can you commit this for me, please?

Rebased onto master

Rebased onto master

ping

Another way to avoid UB in that case is to use value initialization, i.e. PathDiagnosticConsumerOptions options{};.

Rebased onto master

Can you commit this please? I don't have commit access.

Read tombstone value from a constexpr variable. The getTombstoneVal() function
is still necessary, though, as reinterpret_cast is not a constant expression.

• Added test case
• Use generator instead of iterator class

Rebased onto master

I don't have commit access, so please go ahead and commit it.

ping

Fixed build error

Yes, please commit this.