User Details
- User Since
- Dec 13 2017, 4:08 AM (286 w, 1 d)
Feb 8 2023
Dec 16 2022
Dec 13 2022
Thanks for the patch! I just tried it out and I think this enables many interesting use cases for WebAssembly when using C/C++.
To answer your questions in the comments about what to do about resolvers with arguments: At least glibc always calls ifunc resolvers without any arguments. It just reads the address of the resolver function from the ELF file, casts it to a pointer to a void-returning function with no arguments and calls it.
Nov 2 2022
Oct 20 2022
The only failing "test" is clang-format. Should I reformat the complete files? Because my additions are formatted correctly, but the rest of the file is not.
Use llvm::cantFail instead of just returning
Oct 12 2022
Fixed an unchecked Expected<T> which lead to several test failures. All tests should run now, hopefully.
Sep 27 2022
Fixed a failing test: In ELFObjectFile I added a case to set the symbol type to
ST_Function also for ifunc symbols. As far as I know, ifunc symbols can only be
functions, but even objdump from binutils doesn't print those symbols with the
function type. I removed that case again, ifunc symbols now have type ST_Other.
Sep 26 2022
Rebased onto main, let tests run again
Sep 23 2022
@lhames do you have any other comments? Can I merge this?
Aug 12 2022
Rebased again because of failing tests on main
Rebased onto main
Jul 18 2022
Fixed typos in comments
Jul 15 2022
Removed Indirect from JITSymbolFlags
Feb 17 2022
The test failures all seem to be unrelated to this change, lgtm.
Nov 16 2021
Sep 8 2021
Sep 6 2021
Aug 29 2021
Added NOLINT comments to avoid clang-tidy warning for the functions called that
have X86_64 in their name.
Aug 28 2021
Require x86_64-linux for the TLS test as the execution in llvm-rtdyld is
ifdef'd only for x86_64 and ELF.
Aug 27 2021
Refactored most of the relocation logic into separate functions.
Aug 18 2021
Thanks for looking at this!
Jul 8 2021
User::operator delete(Ptr) must not be called with any additional arguments. Fixed that.
Fixed variable names
Jul 7 2021
Jul 6 2021
This is now solved in D97898.
Rebased onto main
Rebased onto main
May 26 2021
Apr 26 2021
As part of a research project on a code-generating database system I am using LLVM to generate code and also link it with static libraries at runtime. I found a few bugs in RuntimeDyld most of which I submitted for a review. The biggest change that I haven't submitted yet is my implementation of TLS relocations (only for x86 for now) in RuntimeDyld. I know that long-term this will probably be replaced by JITLink but when I started working on that project, it didn't seem stable enough so I decided to extend RuntimeDyld.
Apr 14 2021
ping
Feb 18 2021
Rebased onto master
Jan 28 2021
Jan 27 2021
Jan 22 2021
Some tests were failing, I'll try to fix that and then commit the changes.
Initialize bool flags
Rebased onto master, run tests again
Jan 12 2021
Fixed clang-format error
Thanks for the review! Can you commit this for me, please?
Jan 11 2021
Dec 21 2020
Rebased onto master
Rebased onto master
Dec 10 2020
ping
Nov 30 2020
Another way to avoid UB in that case is to use value initialization, i.e. PathDiagnosticConsumerOptions options{};.
Nov 27 2020
Nov 26 2020
Rebased onto master
Nov 18 2020
Can you commit this please? I don't have commit access.
Nov 17 2020
Read tombstone value from a constexpr variable. The getTombstoneVal() function
is still necessary, though, as reinterpret_cast is not a constant expression.
Nov 12 2020
Nov 10 2020
- Added test case
- Use generator instead of iterator class
Rebased onto master
Nov 5 2020
I don't have commit access, so please go ahead and commit it.
Nov 3 2020
Oct 26 2020
ping
Oct 14 2020
Fixed build error
Dec 22 2017
Yes, please commit this.