Page MenuHomePhabricator

MitalAshok (Mital Ashok)
User

Projects

User does not belong to any projects.

User Details

User Since
May 17 2022, 4:46 AM (6 w, 3 h)

Recent Activity

Thu, Jun 2

MitalAshok planned changes to D126937: Fix memleak in VarTemplateSpecializationDecl.

Appears that more things need to be changed, I'll get that done soon

Thu, Jun 2, 9:54 PM · Restricted Project, Restricted Project, Restricted Project
MitalAshok added inline comments to D126937: Fix memleak in VarTemplateSpecializationDecl.
Thu, Jun 2, 7:33 PM · Restricted Project, Restricted Project, Restricted Project
MitalAshok published D126937: Fix memleak in VarTemplateSpecializationDecl for review.

VarTemplateSpecializationDecl held a TemplateArgumentListInfo which holds a SmallVector<TemplateArgumentLoc, 8>, so in this test case https://github.com/llvm/llvm-project/blob/ee1cf1f64519c815025d962bdf9c9bb3d09d7699/clang/test/SemaCXX/has_unique_object_reps_bitint.cpp#L27 where there was a variable template with more than 8 template arguments, it leaked

Thu, Jun 2, 7:28 PM · Restricted Project, Restricted Project, Restricted Project

May 28 2022

MitalAshok added a comment to D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits.

@aaron.ballman yes, with the author "Mital Ashok <mital.vaja[AT]googlemail.com>". (replacing the [AT]) Thanks!

May 28 2022, 10:38 AM · Restricted Project, Restricted Project

May 27 2022

MitalAshok updated the diff for D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits.

Rebase release notes

May 27 2022, 11:40 PM · Restricted Project, Restricted Project

May 18 2022

MitalAshok updated the diff for D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits.

Removed useless isReferenceType check

May 18 2022, 7:21 AM · Restricted Project, Restricted Project

May 17 2022

MitalAshok updated the diff for D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits.

Added release note and missing test for struct with reference member

May 17 2022, 2:27 PM · Restricted Project, Restricted Project
MitalAshok added inline comments to D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits.
May 17 2022, 9:42 AM · Restricted Project, Restricted Project
MitalAshok published D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits for review.
May 17 2022, 9:19 AM · Restricted Project, Restricted Project