- User Since
- Jul 19 2022, 11:51 AM (61 w, 4 d)
May 11 2023
I don't see anything in here that would block later extension for supporting offloading, so LGTM from my POV.
LGTM, but I don't feel like I have the experience to "formally" approve. I left a nice-to have suggestion too, but feel free to ignore, if you feel its out of scope.
Jan 21 2023
Fixed by D142249.
Looks good, also works for my original program, thank you! Just one nit and a question:
Jan 20 2023
This change avoids the deadlock, but now library registration happens before (during) the device runtimes are loaded essentially skipping the registration.
Jan 19 2023
Replace thread local with class member + atomic thread Id. Also factor out the delayed handling into member functions.
The reason the thread id checks are necessary is 1. avoiding race conditions. 2. not returning before the library is registered in threads that are not doing loadRtls.
Jan 18 2023
I think you're missing some of the changes, I should have added a loop around the registration of the library to the plugins that goes over DelayedDescs and registers each, maybe it did not upload right?
Oct 25 2022
Sep 18 2022
Sep 15 2022
Remove inline elements from the map. Add tests. With the tests I now consider this complete, so removed the draft from the title.
Sep 13 2022
Sep 11 2022
Aug 10 2022
Sorry, I somehow missed the big obvious checkbox to mark the comments, fixed now.
I don't have commit access could you commit if the last change seems okay to you?
Aug 9 2022
Address formatting and stylistic comments.
Aug 8 2022
Aug 6 2022
Jul 29 2022
Updated to add missing comma after 'git ls-tree'. It broke normal (non staged) operation.