Sorry, I haven't investigated.

In D124563#3479990, @aaronpuchert wrote:

In D124563#3478625, @smeenai wrote:

I *think* this would mean that if you're on Windows and have core.autocrlf set to input, when you commit changes to this files, Git will convert them back to LF line endings. Not 100% sure of that though.

Which convinced me that D97625 was right: we do want the line endings to remain CRLF, and not have them accidentally destroyed. With -text we say that we don't care, which is not true.

In D124563#3479405, @MForster wrote:

It also seems weird to me that a file that relies on CRLF line endings is checked in explicitly with LF line endings. A better approach IMHO would be to check it in as binary.

These are all text files though, not binaries. Checking it in as binary will not show any diffs.

In D124606#3479805, @MForster wrote:

In D124606#3479798, @ilya-biryukov wrote:

NIT: change the commit message to say -text instead of binary

Ah, sorry, saw this too late...

In D124606#3479798, @ilya-biryukov wrote:

NIT: change the commit message to say -text instead of binary

Use -text instead of binary.

I'm proposing this: D124606.

Force-add crlf.cpp(.expected) with CRLF line endings.

I've reverted this because symbol-offset.test fails under MSAN:

It also seems weird to me that a file that relies on CRLF line endings is checked in explicitly with LF line endings. A better approach IMHO would be to check it in as binary.

The backtrace is pretty much useless

Yes, sorry, that's all I had. Just added some evidence.

This fails under MSAN:

I've added a repro case to the original review thread: D105380

Adrian has reverted this commit for me. Here is a reproduction case for the issue that is triggered by this change:

That's ok for me. I'd suggest to wait for Aaron's feedback, because IIRC it was his suggestion in the first place to go to declref.

In D84005#2215685, @thakis wrote:

Looks like this breaks check-clangd on Windows: http://45.33.8.238/win/21943/step_9.txt

Rebase before submission

Fix nit

Fix mistake

Add an -ast-print test

Pretty-print VarDecl arguments correctly

For context, this is the backported change, to be applied downstream before landing this review: https://github.com/apple/llvm-project/pull/1565

Fix patch

Simplify code

Rebase

Apply ClangTidy suggestions

Use declaration in diagnostics instead of name

Rebase against master

Store the VarDecl instead of the identifier

Two clarifying questions...

Rename test back to ns_error_enum.m

Fix typo

Address review comments

Rebase

I have updated the attribute documentation to include the additional information provided by Doug. I think adding additional diagnostics would rather be separate changes.

• Address review comments

@milseman, @doug.gregor, could you please help with the open questions on this review?

In D84005#2162433, @aaron.ballman wrote:

It's a bit odd that this attribute has an AST node created for it but nothing is using that AST node elsewhere in the project. Are there other patches expected for making use of this attribute?

Address review comments

• Run test also in C and C++ mode
• Address more review comments

In D84005#2158029, @aaron.ballman wrote:

FWIW, this is *really* hard to review because it's not a diff against the trunk and so it's not immediately clear what the actual changes are.

The change is missing all of its test coverage.

In D84005#2158019, @gribozavr2 wrote:

Did your latest update unintentionally drop the test file clang/test/Analysis/ns_error_enum.m?

Fix diff

• Address review comments

Address review comments.

This is a prerequisite for future changes that I am making. The implementation is supposed to be generic and reusable.

Reverts of a few follow-up changes were necessary as well:

• 79fcd35c688b94becadd162a6c37e9b95df5c084
• 23f29b2fcc5668c51f15809067a1c3503b422c64
• f67f9e86e86e68d4cbc05ef8d6ffd0cb33246d45
• 0f1195a58648998d21bcfa1575a78a4706eaa52c
• 8214eff467f583309e9fbb971862d3c1cdcc65e4

In D80150#2045632, @omjavaid wrote:

This patch breaks lldb unit tests on lldb-arm-ubuntu buildbot.

http://lab.llvm.org:8014/builders/lldb-arm-ubuntu/builds/1697

In D70872#1781703, @sammccall wrote:

Thanks! I'll land this for you.

I think I addressed all review comments. PTAL.

Adress review comments.