Page MenuHomePhabricator

MForster (Michael Forster)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 10 2019, 12:00 AM (45 w, 4 d)

Recent Activity

Aug 13 2020

MForster added a comment to D84005: Introduce ns_error_domain attribute..

Looks like this breaks check-clangd on Windows: http://45.33.8.238/win/21943/step_9.txt

Aug 13 2020, 7:59 AM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Rebase before submission

Aug 13 2020, 4:19 AM · Restricted Project

Aug 10 2020

MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Fix nit

Aug 10 2020, 6:41 AM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Fix mistake

Aug 10 2020, 2:49 AM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Add an -ast-print test

Aug 10 2020, 2:37 AM · Restricted Project

Jul 31 2020

MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Pretty-print VarDecl arguments correctly

Jul 31 2020, 2:50 AM · Restricted Project

Jul 30 2020

MForster added a comment to D84005: Introduce ns_error_domain attribute..

For context, this is the backported change, to be applied downstream before landing this review: https://github.com/apple/llvm-project/pull/1565

Jul 30 2020, 8:08 AM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Fix patch

Jul 30 2020, 7:41 AM · Restricted Project
MForster added inline comments to D84005: Introduce ns_error_domain attribute..
Jul 30 2020, 7:37 AM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Simplify code

Jul 30 2020, 7:36 AM · Restricted Project

Jul 29 2020

MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Rebase

Jul 29 2020, 9:19 PM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Apply ClangTidy suggestions

Jul 29 2020, 6:25 AM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Use declaration in diagnostics instead of name

Jul 29 2020, 6:04 AM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Rebase against master

Jul 29 2020, 5:28 AM · Restricted Project
MForster added inline comments to D84005: Introduce ns_error_domain attribute..
Jul 29 2020, 5:00 AM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Store the VarDecl instead of the identifier

Jul 29 2020, 5:00 AM · Restricted Project

Jul 27 2020

MForster added a comment to D84005: Introduce ns_error_domain attribute..

Two clarifying questions...

Jul 27 2020, 6:43 AM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Rename test back to ns_error_enum.m

Jul 27 2020, 2:46 AM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Fix typo

Jul 27 2020, 2:34 AM · Restricted Project
MForster added inline comments to D84005: Introduce ns_error_domain attribute..
Jul 27 2020, 2:32 AM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Address review comments

Jul 27 2020, 2:32 AM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Rebase

Jul 27 2020, 12:48 AM · Restricted Project
MForster added a comment to D84005: Introduce ns_error_domain attribute..

I have updated the attribute documentation to include the additional information provided by Doug. I think adding additional diagnostics would rather be separate changes.

Jul 27 2020, 12:33 AM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..
  • Address review comments
Jul 27 2020, 12:32 AM · Restricted Project
Herald added a reviewer for D84005: Introduce ns_error_domain attribute.: jdoerfert.
Jul 27 2020, 12:29 AM · Restricted Project

Jul 24 2020

MForster updated subscribers of D84005: Introduce ns_error_domain attribute..

@milseman, @doug.gregor, could you please help with the open questions on this review?

Jul 24 2020, 5:30 AM · Restricted Project
MForster added a comment to D84005: Introduce ns_error_domain attribute..

It's a bit odd that this attribute has an AST node created for it but nothing is using that AST node elsewhere in the project. Are there other patches expected for making use of this attribute?

Jul 24 2020, 5:18 AM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Address review comments

Jul 24 2020, 5:17 AM · Restricted Project

Jul 20 2020

MForster added inline comments to D84005: Introduce ns_error_domain attribute..
Jul 20 2020, 7:14 AM · Restricted Project
MForster added inline comments to D84005: Introduce ns_error_domain attribute..
Jul 20 2020, 6:44 AM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..
  • Run test also in C and C++ mode
  • Address more review comments
Jul 20 2020, 6:43 AM · Restricted Project

Jul 17 2020

MForster added a comment to D84005: Introduce ns_error_domain attribute..

FWIW, this is *really* hard to review because it's not a diff against the trunk and so it's not immediately clear what the actual changes are.

The change is missing all of its test coverage.

Jul 17 2020, 5:06 AM · Restricted Project
MForster added a comment to D84005: Introduce ns_error_domain attribute..

Did your latest update unintentionally drop the test file clang/test/Analysis/ns_error_enum.m?

Jul 17 2020, 5:03 AM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..

Fix diff

Jul 17 2020, 5:02 AM · Restricted Project
MForster added inline comments to D84005: Introduce ns_error_domain attribute..
Jul 17 2020, 4:46 AM · Restricted Project
MForster updated the diff for D84005: Introduce ns_error_domain attribute..
  • Address review comments
Jul 17 2020, 4:38 AM · Restricted Project
MForster updated the summary of D84005: Introduce ns_error_domain attribute..
Jul 17 2020, 1:00 AM · Restricted Project
Herald added a project to D84005: Introduce ns_error_domain attribute.: Restricted Project.
Jul 17 2020, 12:58 AM · Restricted Project

Jul 16 2020

MForster updated the diff for D83887: Add hashing support for std::tuple.
Jul 16 2020, 12:04 AM · Restricted Project

Jul 15 2020

MForster updated the diff for D83887: Add hashing support for std::tuple.
Jul 15 2020, 11:38 PM · Restricted Project
MForster updated the diff for D83887: Add hashing support for std::tuple.
Jul 15 2020, 11:37 PM · Restricted Project
MForster added inline comments to D83887: Add hashing support for std::tuple.
Jul 15 2020, 11:32 PM · Restricted Project
MForster updated the diff for D83887: Add hashing support for std::tuple.

Address review comments.

Jul 15 2020, 11:30 PM · Restricted Project
MForster added a comment to D83887: Add hashing support for std::tuple.

This is a prerequisite for future changes that I am making. The implementation is supposed to be generic and reusable.

Jul 15 2020, 10:18 AM · Restricted Project
Herald added a project to D83887: Add hashing support for std::tuple: Restricted Project.
Jul 15 2020, 10:15 AM · Restricted Project

May 20 2020

MForster added a comment to D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch.

Reverts of a few follow-up changes were necessary as well:

May 20 2020, 4:18 AM · Restricted Project
MForster updated subscribers of D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch.
May 20 2020, 3:12 AM · Restricted Project
MForster updated subscribers of D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch.

This patch breaks lldb unit tests on lldb-arm-ubuntu buildbot.

http://lab.llvm.org:8014/builders/lldb-arm-ubuntu/builds/1697

May 20 2020, 3:12 AM · Restricted Project

Apr 20 2020

MForster created D78487: Explicitly move from llvm::json Array/Object to Value.
Apr 20 2020, 5:53 AM · Restricted Project
MForster retitled D78487: Explicitly move from llvm::json Array/Object to Value from Explicitly move from llvm::json Array to Value to Explicitly move from llvm::json Array/Object to Value.
Apr 20 2020, 5:53 AM · Restricted Project

Jan 30 2020

MForster created D73683: Inline debug variable..
Jan 30 2020, 1:21 AM · Restricted Project

Dec 12 2019

MForster added a comment to D70872: [clangd] Implement "textDocument/documentLink" protocol support.

Thanks! I'll land this for you.

Dec 12 2019, 5:37 AM · Restricted Project

Dec 11 2019

MForster added a comment to D70872: [clangd] Implement "textDocument/documentLink" protocol support.

I think I addressed all review comments. PTAL.

Dec 11 2019, 12:09 PM · Restricted Project
MForster updated the diff for D70872: [clangd] Implement "textDocument/documentLink" protocol support.

Adress review comments.

Dec 11 2019, 12:09 PM · Restricted Project

Nov 30 2019

MForster added inline comments to D70872: [clangd] Implement "textDocument/documentLink" protocol support.
Nov 30 2019, 2:21 PM · Restricted Project
MForster retitled D70872: [clangd] Implement "textDocument/documentLink" protocol support from Advertise documentLink capability to [clangd] Implement "textDocument/documentLink" protocol support.
Nov 30 2019, 2:02 PM · Restricted Project
MForster created D70872: [clangd] Implement "textDocument/documentLink" protocol support.
Nov 30 2019, 2:01 PM · Restricted Project