Page MenuHomePhabricator

LukeZhuang (Zhi Zhuang)
User

Projects

User does not belong to any projects.

User Details

User Since
Tue, May 12, 12:18 PM (1 w, 5 d)

Recent Activity

Thu, May 21

LukeZhuang added a comment to D79830: Add support of __builtin_expect_with_probability.

FYI: I'm more of a clang contributor, so I'm unable to review the LLVM code, hopefully someone will come along who can check on that.

Thu, May 21, 2:38 PM · Restricted Project, Restricted Project
LukeZhuang updated the diff for D79830: Add support of __builtin_expect_with_probability.

Updated: 05/21/2020

  1. add assertion after evaluate probability
  2. remove value dependent check in SemaChecking
  3. add test case handling value-dependent template
Thu, May 21, 2:38 PM · Restricted Project, Restricted Project
LukeZhuang added inline comments to D79830: Add support of __builtin_expect_with_probability.
Thu, May 21, 11:21 AM · Restricted Project, Restricted Project
LukeZhuang added inline comments to D79830: Add support of __builtin_expect_with_probability.
Thu, May 21, 10:15 AM · Restricted Project, Restricted Project

Fri, May 15

LukeZhuang added inline comments to D79830: Add support of __builtin_expect_with_probability.
Fri, May 15, 3:14 PM · Restricted Project, Restricted Project
LukeZhuang updated the diff for D79830: Add support of __builtin_expect_with_probability.

updated 05/15/2020:
(1) add documents about __builtin_expect_with_probability
(2) modify SemaChecking to handle evaluate constant floating-point expression
(3) modify CGBuiltin to evaluate constant floating-point argument before passing it

Fri, May 15, 3:14 PM · Restricted Project, Restricted Project

Thu, May 14

LukeZhuang added inline comments to D79830: Add support of __builtin_expect_with_probability.
Thu, May 14, 12:30 PM · Restricted Project, Restricted Project

Wed, May 13

LukeZhuang added inline comments to D79830: Add support of __builtin_expect_with_probability.
Wed, May 13, 10:19 PM · Restricted Project, Restricted Project
LukeZhuang added inline comments to D79830: Add support of __builtin_expect_with_probability.
Wed, May 13, 4:24 PM · Restricted Project, Restricted Project
LukeZhuang added a comment to D79830: Add support of __builtin_expect_with_probability.

Thanks for working on this.
Please upload patch with full context.

Hi, sorry but I'm not sure what does full context means, is that means I need to show more lines(for example 10 lines) when generating patch or show the whole function? Thank you!

git diff -p -U99999

Wed, May 13, 4:24 PM · Restricted Project, Restricted Project
LukeZhuang updated the diff for D79830: Add support of __builtin_expect_with_probability.
  1. fix code format
  2. move probability type and value check from codegen to semacheck
  3. update patch with full context
Wed, May 13, 4:24 PM · Restricted Project, Restricted Project
LukeZhuang added a comment to D79830: Add support of __builtin_expect_with_probability.

Thanks for working on this.
Please upload patch with full context.

Wed, May 13, 11:57 AM · Restricted Project, Restricted Project

Tue, May 12

LukeZhuang created D79830: Add support of __builtin_expect_with_probability.
Tue, May 12, 5:48 PM · Restricted Project, Restricted Project