Page MenuHomePhabricator

KoviRobi (Kovacsics Robert)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 19 2017, 2:58 AM (148 w, 5 d)

Recent Activity

Aug 3 2017

KoviRobi added a comment to D21292: [mips] Correct ELF format for N32..

After some out-of-band discussions with @Jerryxia32 we've discovered that the problem is that the Mips backend tries to write the 3-in-1 reloc format for N32, but the 32-bit ELF cannot store it all, so it only ends up with the R_MIPS_GPREL16, e.g.
N32 (Clang)

$ ../build/bin/clang -target mips64 -mabi=n32 -mcpu=mips4 -fpic -fPIC -mabicalls -integrated-as -c test.c -o -|../build/bin/llvm-readobj -r -
Aug 3 2017, 4:13 AM

Jul 19 2017

KoviRobi added a comment to D27662: [triple+llc+llvm-mc] Make triple and ABI name consistent.

So some simple testing using gcc -S and

int main(void) {
  x: goto x;
}

as the simplest test-case with labels I could think of, seem to suggest that we should use $label for o32, and .Llabel for n32/n64, which is the current behaviour, but in that case perhaps the test cases should be changed so they align? I have included the way I would change those files, note that it also clarifies the difference between using two adjacent 32-bit floating-point registers, versus using one 64-bit floating-point register that the mips32r2 and newer support.

Jul 19 2017, 6:37 AM
KoviRobi added a comment to D27662: [triple+llc+llvm-mc] Make triple and ABI name consistent.

I'd be interested to see this merged as well, but when I run the tests after applying the patch (onto 0d7672e plus my patch on https://reviews.llvm.org/D21465) I find that the following tests fail:

Jul 19 2017, 4:43 AM
KoviRobi added a comment to D21465: [llc+llvm-mc] Replace the hidden -target-abi option with a -mabi thats visible in --help..

Are there plans to merge this in? I have updated the patch onto 0d7672e (attached), if it is helpful, though it was mostly just s/target-abi[ =]/mabi=/ on the files which failed the tests (and then ran the tests again and nothing failed).

Jul 19 2017, 3:21 AM