Page MenuHomePhabricator

Kokan (Kókai Péter)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 28 2019, 11:59 AM (21 w, 5 d)

Recent Activity

Mar 2 2020

Kokan added a comment to D75425: [docs] Added solutions to slow build under common problems.

Anything like this without an LLD/Gold reference is likely insufficient. In my experience, switching to Gold or LLD has been the biggest benefit so far.

Mar 2 2020, 7:14 AM · Restricted Project

Jan 9 2020

Kokan added a comment to D72402: [build][NFC] limit parallel link to reduce memory usage.

Could we do this the other way around - and "AND LINKER_IS_GNULD"? Because so far as I know gold has reasonable memory usage too (& LD64), etc. I /think/ it's just GNULD that's the outlier here. (I can't speak for SOLARISLD, admittedly)

Jan 9 2020, 10:05 AM · Restricted Project

Jan 8 2020

Kokan created D72402: [build][NFC] limit parallel link to reduce memory usage.
Jan 8 2020, 8:56 AM · Restricted Project

Jan 5 2020

Kokan abandoned D72050: [opt] refactor opt main function.
Jan 5 2020, 2:28 AM · Restricted Project

Jan 2 2020

Kokan accepted D72077: [docs] Improve HowTo commit changes from git.
Jan 2 2020, 8:33 AM · Restricted Project
Kokan accepted D72087: [clang-tools-extra] NFC: Fix trivial typos in comments.
Jan 2 2020, 8:33 AM · Restricted Project

Jan 1 2020

Kokan added a reviewer for D72050: [opt] refactor opt main function: MaskRay.
Jan 1 2020, 8:22 AM · Restricted Project
Kokan created D72050: [opt] refactor opt main function.
Jan 1 2020, 4:03 AM · Restricted Project

Dec 30 2019

Kokan added a comment to D71967: [opt] Fix run-twice crash and detection problem.

I do not have commit rights to the repository, someone please commit this change.

@Kokan git commit --amend --author='what-is-your-<email@address>' ?

Dec 30 2019, 12:34 AM · Restricted Project

Dec 29 2019

Kokan added a comment to D71967: [opt] Fix run-twice crash and detection problem.

I do not have commit rights to the repository, someone please commit this change.

Dec 29 2019, 11:57 PM · Restricted Project
Kokan updated the diff for D71967: [opt] Fix run-twice crash and detection problem.
Dec 29 2019, 1:47 AM · Restricted Project
Kokan added a comment to D71967: [opt] Fix run-twice crash and detection problem.

Tests?

Hello, @xbolva00

Thanks for checkout out my patch, and sorry for the lack of test or explanation beforehand.

Regarding the tests I seek some support. I was thinking about the following test scenarios, but failed to find any of the proper here:

  1. unittests: With proper refactoring of the opt that should be doable, although that would be out of the scope of this current fix.
  2. test-suit[1]: The issue only happens when the output file is a TTY, a bitcode format is requested and -run-twice is used. I could not trigger the failure with llvm-lit test. Please advice.
  3. Creating a negative test for -run-twice, as every Pass should behave the same way after executing multiple time, there is not test that confirms that -run-twice actually could catch different results (just like it does not work now with bitcode format), there could be a dummy Pass created that in fact does reproduce different results with each execution in order to test this.

    Could you or anyone please help with it ?

[1] I am referring to those tests that are executed via llvm-lit

Due to

if (!Force && !NoOutput && !AnalyzeOnly && !OutputAssembly)
  if (CheckBitcodeOutputToConsole(Out->os(), !Quiet))
    NoOutput = true;

This is difficult to test. The bug relies on stdout being a pty.

I think it may be worth defining a variable for !NoOutput && !AnalyzeOnly, because the pattern occurs multiple times.

Dec 29 2019, 1:45 AM · Restricted Project

Dec 28 2019

Kokan added a comment to D71967: [opt] Fix run-twice crash and detection problem.

Tests?

Dec 28 2019, 2:58 PM · Restricted Project
Kokan retitled D71967: [opt] Fix run-twice crash and detection problem from [opt] run-twice crash to [opt] Fix run-twice crash and detection problem.
Dec 28 2019, 1:11 PM · Restricted Project
Kokan created D71967: [opt] Fix run-twice crash and detection problem.
Dec 28 2019, 1:07 PM · Restricted Project