Page MenuHomePhabricator

Kmeakin (Karl Meakin)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 23 2022, 10:19 AM (17 w, 3 d)

Recent Activity

May 12 2022

Kmeakin requested review of D125504: [AArch64] Add `foldCSELOfCSEl` DAG combine.
May 12 2022, 2:47 PM · Restricted Project, Restricted Project
Kmeakin committed rG0298cce257f8: [AArch64] Add `foldADCToCINC` DAG combine. (authored by Kmeakin).
[AArch64] Add `foldADCToCINC` DAG combine.
May 12 2022, 2:22 PM · Restricted Project, Restricted Project
Kmeakin closed D123781: [AArch64] Add `foldADCToCINC` DAG combine.
May 12 2022, 2:22 PM · Restricted Project, Restricted Project
Kmeakin committed rGd29fc6e7d24f: [AArch64] Replace `performANDSCombine` with `performFlagSettingCombine`. (authored by Kmeakin).
[AArch64] Replace `performANDSCombine` with `performFlagSettingCombine`.
May 12 2022, 2:18 PM · Restricted Project, Restricted Project
Kmeakin closed D124464: [AArch64] Replace `performANDSCombine` with `performFlagSettingCombine`..
May 12 2022, 2:17 PM · Restricted Project, Restricted Project

May 11 2022

Kmeakin updated the diff for D124464: [AArch64] Replace `performANDSCombine` with `performFlagSettingCombine`..

Remove ADDS and SUBS cases, since I could not find any test cases where they fire.

May 11 2022, 11:34 AM · Restricted Project, Restricted Project
Kmeakin added inline comments to D124464: [AArch64] Replace `performANDSCombine` with `performFlagSettingCombine`..
May 11 2022, 11:05 AM · Restricted Project, Restricted Project

May 9 2022

Kmeakin added inline comments to D124464: [AArch64] Replace `performANDSCombine` with `performFlagSettingCombine`..
May 9 2022, 9:59 AM · Restricted Project, Restricted Project
Kmeakin accepted D125150: [AArch64] Remove ADDC, ADDE, SUBC, SUBE support, use the CARRY ops instead.

LGTM

May 9 2022, 8:47 AM · Restricted Project, Restricted Project
Kmeakin accepted D125130: [CodeGen] Clarify the semantics of ADDCARRY/SUBCARRY.

Typo in spelling of "semantics". Otherwise seems fine to me.

May 9 2022, 8:46 AM · Restricted Project, Restricted Project

Apr 27 2022

Kmeakin added a comment to D123781: [AArch64] Add `foldADCToCINC` DAG combine.

It's not immediately clear to me what the advantage is to using CINC verses ADC. Sure some of the tests emit less code but for those cases it just looks like we're not making good use of xzr?

Apr 27 2022, 9:26 AM · Restricted Project, Restricted Project

Apr 26 2022

Kmeakin updated the diff for D123781: [AArch64] Add `foldADCToCINC` DAG combine.

Rebase on top of https://reviews.llvm.org/rG13403a70e45b2d22878ba59fc211f8dba3a8deba

Apr 26 2022, 10:04 AM · Restricted Project, Restricted Project
Kmeakin abandoned D123780: [AArch64] Add `removeDeadFlags` DAG combine.

Abandoned in favour of https://reviews.llvm.org/D124464

Apr 26 2022, 9:55 AM · Restricted Project, Restricted Project
Kmeakin added a reviewer for D124464: [AArch64] Replace `performANDSCombine` with `performFlagSettingCombine`.: paulwalker-arm.
Apr 26 2022, 9:55 AM · Restricted Project, Restricted Project
Kmeakin requested review of D124464: [AArch64] Replace `performANDSCombine` with `performFlagSettingCombine`..
Apr 26 2022, 9:54 AM · Restricted Project, Restricted Project
Kmeakin closed D123779: [AArch64] Add `foldOverflowCheck` DAG combine.

Closed by https://reviews.llvm.org/rG81904454f7cdebecedb1185d8112b630a7124350.

Apr 26 2022, 7:07 AM · Restricted Project, Restricted Project

Apr 21 2022

Kmeakin committed rG81904454f7cd: [AArch64] Add `foldOverflowCheck` DAG combine (authored by Kmeakin).
[AArch64] Add `foldOverflowCheck` DAG combine
Apr 21 2022, 6:57 AM · Restricted Project, Restricted Project
Kmeakin committed rG13403a70e45b: [AArch64] Add lowerings for {ADD,SUB}CARRY and S{ADD,SUB}O_CARRY (authored by Kmeakin).
[AArch64] Add lowerings for {ADD,SUB}CARRY and S{ADD,SUB}O_CARRY
Apr 21 2022, 6:57 AM · Restricted Project, Restricted Project
Kmeakin closed D123322: [AArch64] Add lowerings for {ADD,SUB}CARRY and S{ADD,SUB}O_CARRY.
Apr 21 2022, 6:57 AM · Restricted Project, Restricted Project
Kmeakin updated the diff for D123779: [AArch64] Add `foldOverflowCheck` DAG combine.

Merge ifs with same body

Apr 21 2022, 5:22 AM · Restricted Project, Restricted Project

Apr 19 2022

Kmeakin abandoned D120428: [AArch64] Optimize safe integer division.
Apr 19 2022, 8:06 AM · Restricted Project, Restricted Project
Kmeakin added a comment to D120428: [AArch64] Optimize safe integer division.

Abandoning this patch: after some reflection, I have decided that in its current incarnation it would be very niche optimisation that would only fire under very niche conditions (platforms where the if-conversion fires and the NZCV def is not used anywhere else). It may be worth another attempt later down the line, but performed at a different stage in the optimization pipeline (perhaps during lowering from LLVM-IR to SelectionDAG?)

Apr 19 2022, 8:06 AM · Restricted Project, Restricted Project
Kmeakin updated the diff for D123779: [AArch64] Add `foldOverflowCheck` DAG combine.

Remove erroneous transformation of (ADC l r (CMP CSET HI carry) 1)) and (SBC l r (CMP (CSET LS carry) 1))

Apr 19 2022, 4:52 AM · Restricted Project, Restricted Project
Kmeakin updated the diff for D123779: [AArch64] Add `foldOverflowCheck` DAG combine.

Incorporate feedback from reviewers

Apr 19 2022, 4:11 AM · Restricted Project, Restricted Project

Apr 15 2022

Kmeakin added inline comments to D123779: [AArch64] Add `foldOverflowCheck` DAG combine.
Apr 15 2022, 8:44 AM · Restricted Project, Restricted Project

Apr 14 2022

Kmeakin updated the diff for D123322: [AArch64] Add lowerings for {ADD,SUB}CARRY and S{ADD,SUB}O_CARRY.

Fix indentation

Apr 14 2022, 4:20 AM · Restricted Project, Restricted Project
Kmeakin updated the diff for D123322: [AArch64] Add lowerings for {ADD,SUB}CARRY and S{ADD,SUB}O_CARRY.

Update revision according to feedback

Apr 14 2022, 4:13 AM · Restricted Project, Restricted Project
Kmeakin added a reviewer for D123780: [AArch64] Add `removeDeadFlags` DAG combine: paulwalker-arm.
Apr 14 2022, 4:00 AM · Restricted Project, Restricted Project
Kmeakin added a reviewer for D123781: [AArch64] Add `foldADCToCINC` DAG combine: paulwalker-arm.
Apr 14 2022, 4:00 AM · Restricted Project, Restricted Project
Kmeakin requested review of D123781: [AArch64] Add `foldADCToCINC` DAG combine.
Apr 14 2022, 3:59 AM · Restricted Project, Restricted Project
Kmeakin requested review of D123780: [AArch64] Add `removeDeadFlags` DAG combine.
Apr 14 2022, 3:59 AM · Restricted Project, Restricted Project
Kmeakin added a reviewer for D123779: [AArch64] Add `foldOverflowCheck` DAG combine: paulwalker-arm.
Apr 14 2022, 3:54 AM · Restricted Project, Restricted Project
Kmeakin requested review of D123779: [AArch64] Add `foldOverflowCheck` DAG combine.
Apr 14 2022, 3:52 AM · Restricted Project, Restricted Project

Apr 7 2022

Kmeakin added a reviewer for D123322: [AArch64] Add lowerings for {ADD,SUB}CARRY and S{ADD,SUB}O_CARRY: paulwalker-arm.
Apr 7 2022, 10:08 AM · Restricted Project, Restricted Project
Kmeakin requested review of D123322: [AArch64] Add lowerings for {ADD,SUB}CARRY and S{ADD,SUB}O_CARRY.
Apr 7 2022, 10:08 AM · Restricted Project, Restricted Project
Kmeakin abandoned D123021: [AArch64] Add lowerings for {ADD,SUB}CARRY and S{ADD,SUB}O_CARRY.
Apr 7 2022, 10:08 AM · Restricted Project, Restricted Project
Kmeakin committed rG784b9d468acf: [AArch64] Update tests with the `update_llc_test_checks.py` script (NFC) (authored by Kmeakin).
[AArch64] Update tests with the `update_llc_test_checks.py` script (NFC)
Apr 7 2022, 10:06 AM · Restricted Project, Restricted Project
Kmeakin closed D123317: [AArch64] Update tests with the `update_llc_test_checks.py` script (NFC).
Apr 7 2022, 10:06 AM · Restricted Project, Restricted Project
Kmeakin accepted D123317: [AArch64] Update tests with the `update_llc_test_checks.py` script (NFC).
Apr 7 2022, 10:05 AM · Restricted Project, Restricted Project
Kmeakin retitled D123317: [AArch64] Update tests with the `update_llc_test_checks.py` script (NFC) from [AArch64] Update tests with the `update_llc_test_checks.py` script to [AArch64] Update tests with the `update_llc_test_checks.py` script (NFC).
Apr 7 2022, 10:04 AM · Restricted Project, Restricted Project
Kmeakin added a reviewer for D123317: [AArch64] Update tests with the `update_llc_test_checks.py` script (NFC): paulwalker-arm.
Apr 7 2022, 9:45 AM · Restricted Project, Restricted Project
Kmeakin requested review of D123317: [AArch64] Update tests with the `update_llc_test_checks.py` script (NFC).
Apr 7 2022, 9:44 AM · Restricted Project, Restricted Project

Apr 4 2022

Kmeakin added a reviewer for D123021: [AArch64] Add lowerings for {ADD,SUB}CARRY and S{ADD,SUB}O_CARRY: paulwalker-arm.
Apr 4 2022, 8:10 AM · Restricted Project, Restricted Project
Kmeakin updated the summary of D123021: [AArch64] Add lowerings for {ADD,SUB}CARRY and S{ADD,SUB}O_CARRY.
Apr 4 2022, 4:56 AM · Restricted Project, Restricted Project
Kmeakin requested review of D123021: [AArch64] Add lowerings for {ADD,SUB}CARRY and S{ADD,SUB}O_CARRY.
Apr 4 2022, 4:54 AM · Restricted Project, Restricted Project

Mar 17 2022

Herald added a project to D120428: [AArch64] Optimize safe integer division: Restricted Project.
Mar 17 2022, 5:46 AM · Restricted Project, Restricted Project

Mar 5 2022

Kmeakin committed rG1d8093fe1eaf: [AArch64] fix i128-math.ll (authored by Kmeakin).
[AArch64] fix i128-math.ll
Mar 5 2022, 9:53 AM · Restricted Project
Kmeakin committed rGf3e254b3f399: [AArch64] Add test for i128 overflow/saturation ops (NFC) (authored by Kmeakin).
[AArch64] Add test for i128 overflow/saturation ops (NFC)
Mar 5 2022, 9:26 AM · Restricted Project
Kmeakin closed D121013: [AArch64] Add test for i128 overflow/saturation ops (NFC).
Mar 5 2022, 9:26 AM · Restricted Project, Restricted Project

Mar 4 2022

Kmeakin requested review of D121013: [AArch64] Add test for i128 overflow/saturation ops (NFC).
Mar 4 2022, 10:37 AM · Restricted Project, Restricted Project
Kmeakin committed rG43a0016f3dcf: Extend `performANDCSELCombine` to `performANDORCSELCombine` (authored by Kmeakin).
Extend `performANDCSELCombine` to `performANDORCSELCombine`
Mar 4 2022, 7:11 AM · Restricted Project
Kmeakin closed D120422: [AArch64] Optimize comparison chains.
Mar 4 2022, 7:11 AM · Restricted Project, Restricted Project

Mar 2 2022

Kmeakin updated the diff for D120422: [AArch64] Optimize comparison chains.

Inline IsBool, move comment next to tryCombineToEXTR, remove obsolete comments from tests

Mar 2 2022, 8:29 AM · Restricted Project, Restricted Project

Mar 1 2022

Kmeakin updated the diff for D120422: [AArch64] Optimize comparison chains.

Extend performANDORCSELCombine instead of replacing it

Mar 1 2022, 6:19 AM · Restricted Project, Restricted Project
Kmeakin added inline comments to D120428: [AArch64] Optimize safe integer division.
Mar 1 2022, 4:46 AM · Restricted Project, Restricted Project

Feb 24 2022

Kmeakin added inline comments to D120428: [AArch64] Optimize safe integer division.
Feb 24 2022, 2:29 AM · Restricted Project, Restricted Project
Kmeakin added a comment to D120428: [AArch64] Optimize safe integer division.

Is this a part of AArch64MIPeepholeOpt because it relies upon DIV being ifcvt'd?

Feb 24 2022, 2:25 AM · Restricted Project, Restricted Project
Kmeakin added a reviewer for D120428: [AArch64] Optimize safe integer division: dmgreen.
Feb 24 2022, 2:19 AM · Restricted Project, Restricted Project

Feb 23 2022

Kmeakin updated the summary of D120428: [AArch64] Optimize safe integer division.
Feb 23 2022, 12:25 PM · Restricted Project, Restricted Project
Kmeakin retitled D120428: [AArch64] Optimize safe integer division from Remove redundant CSELs when performing safe integer division. to [AArch64] Optimize safe integer division.
Feb 23 2022, 12:19 PM · Restricted Project, Restricted Project
Kmeakin requested review of D120428: [AArch64] Optimize safe integer division.
Feb 23 2022, 12:14 PM · Restricted Project, Restricted Project
Kmeakin updated the summary of D120422: [AArch64] Optimize comparison chains.
Feb 23 2022, 11:06 AM · Restricted Project, Restricted Project
Kmeakin retitled D120422: [AArch64] Optimize comparison chains from Optimize comparison chains on AArch64 to [AArch64] Optimize comparison chains.
Feb 23 2022, 11:04 AM · Restricted Project, Restricted Project
Kmeakin retitled D120422: [AArch64] Optimize comparison chains from rebase ontop of David Green's patch to Optimize comparison chains on AArch64.
Feb 23 2022, 11:00 AM · Restricted Project, Restricted Project
Kmeakin requested review of D120422: [AArch64] Optimize comparison chains.
Feb 23 2022, 10:52 AM · Restricted Project, Restricted Project