Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

KitsuneAlex (Alexander Hinze)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2023, 6:28 AM (16 w, 4 d)

Recent Activity

Jun 11 2023

KitsuneAlex updated the diff for D152443: Add operator style options to clang-format.

Fix broken style in TokenAnnotator.cpp. I don't know how i keep missing these, trying to get better.

Jun 11 2023, 4:05 PM · Restricted Project, Restricted Project, Restricted Project
KitsuneAlex updated the summary of D152443: Add operator style options to clang-format.
Jun 11 2023, 3:31 PM · Restricted Project, Restricted Project, Restricted Project
KitsuneAlex updated the diff for D152443: Add operator style options to clang-format.

Added missing test case for default operator declarations as requested, as well as blank lines between the blocks inside the test functions
as visual separators.

Jun 11 2023, 3:24 PM · Restricted Project, Restricted Project, Restricted Project
KitsuneAlex updated the diff for D152443: Add operator style options to clang-format.

Revamped the formatting logic again and added the requested unit tests.

Jun 11 2023, 3:19 PM · Restricted Project, Restricted Project, Restricted Project
KitsuneAlex retitled D152443: Add operator style options to clang-format from Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format to Add operator style options to clang-format.
Jun 11 2023, 3:16 PM · Restricted Project, Restricted Project, Restricted Project
KitsuneAlex updated the diff for D152443: Add operator style options to clang-format.

This revision of the diff changes the names of the new style options to SpaceAfterOperatorOverload and SpaceAfterOperatorCall, which clarifies their scope a lot better i think.
I also rewrote the logic to apply formatting that fits exactly what their name implies respectively,
the new tests i added should cover all common use cases (except i forgot some again).

Jun 11 2023, 8:48 AM · Restricted Project, Restricted Project, Restricted Project

Jun 9 2023

KitsuneAlex added a comment to D152443: Add operator style options to clang-format.

I had some issues with Git there because i messed up a merge, so the diff was bad. Here's the proper diff.

NOTE: Clang-Format Team Automated Review Comment

keeps you honest right!

Jun 9 2023, 12:22 PM · Restricted Project, Restricted Project, Restricted Project

Jun 8 2023

KitsuneAlex updated the diff for D152443: Add operator style options to clang-format.

Clean up the formatting with clang-format.

Jun 8 2023, 6:53 PM · Restricted Project, Restricted Project, Restricted Project
KitsuneAlex updated the diff for D152443: Add operator style options to clang-format.

I had some issues with Git there because i messed up a merge, so the diff was bad. Here's the proper diff.

Jun 8 2023, 6:21 PM · Restricted Project, Restricted Project, Restricted Project
KitsuneAlex updated the diff for D152443: Add operator style options to clang-format.

Some additional changes because i exceeded the maximum line width on multiple occasions.

NOTE: Clang-Format Team Automated Review Comment
Jun 8 2023, 6:09 PM · Restricted Project, Restricted Project, Restricted Project
KitsuneAlex retitled D152443: Add operator style options to clang-format from Add SpaceAfterOperatorKeyword style option for clang-format to Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format.
Jun 8 2023, 5:15 PM · Restricted Project, Restricted Project, Restricted Project
KitsuneAlex updated the diff for D152443: Add operator style options to clang-format.

Applied all suggested changes and added a suiting option for aformentioned edge-case for call expressions.
Also added the missing release notes to the apropriate section.

Jun 8 2023, 5:14 PM · Restricted Project, Restricted Project, Restricted Project
KitsuneAlex added a comment to D152443: Add operator style options to clang-format.

Can you add a note to the release notes also please?

Jun 8 2023, 3:25 PM · Restricted Project, Restricted Project, Restricted Project
KitsuneAlex updated the diff for D152443: Add operator style options to clang-format.

I took the liberty and extended the unit tests for SpaceAfterTemplateKeyword and SpaceAfterOperator keyword to cover both possible cases, which lead to me discovering that my code was not quite right because of an early-out return path in a calling function.

Jun 8 2023, 9:33 AM · Restricted Project, Restricted Project, Restricted Project
KitsuneAlex updated the diff for D152443: Add operator style options to clang-format.

I removed the redundant anonymous parameter in the unit test source string. Locally all formatting tests passed fine.

Jun 8 2023, 7:31 AM · Restricted Project, Restricted Project, Restricted Project
KitsuneAlex added a comment to D152443: Add operator style options to clang-format.

I made a stupid mistake and messed up the formatting of the anonymous parameter in the unit test code.
Fixing this right now, don't know why it slipped through.

Jun 8 2023, 7:18 AM · Restricted Project, Restricted Project, Restricted Project
KitsuneAlex updated the summary of D152443: Add operator style options to clang-format.
Jun 8 2023, 6:45 AM · Restricted Project, Restricted Project, Restricted Project
KitsuneAlex updated the summary of D152443: Add operator style options to clang-format.
Jun 8 2023, 6:44 AM · Restricted Project, Restricted Project, Restricted Project
KitsuneAlex requested review of D152443: Add operator style options to clang-format.
Jun 8 2023, 6:43 AM · Restricted Project, Restricted Project, Restricted Project