Page MenuHomePhabricator

Kazhuu (Mauri Mustonen)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 20 2020, 11:37 AM (37 w, 5 d)

Recent Activity

Thu, Apr 1

Kazhuu added a comment to D97378: [VPlan] Support to vectorize inner loops with VPlan native path enabled.

ping

Thu, Apr 1, 5:07 AM · Restricted Project

Mar 9 2021

Kazhuu updated the diff for D97136: [VPlan] Support to widen select intructions in VPlan native path.

Rebase to avoid failing tests.

Mar 9 2021, 12:16 AM · Restricted Project

Mar 7 2021

Kazhuu updated the diff for D97136: [VPlan] Support to widen select intructions in VPlan native path.

Rebase

Mar 7 2021, 9:06 PM · Restricted Project

Mar 5 2021

Kazhuu updated the diff for D97378: [VPlan] Support to vectorize inner loops with VPlan native path enabled.

Fix coment.

Mar 5 2021, 12:06 AM · Restricted Project
Kazhuu added a comment to D97136: [VPlan] Support to widen select intructions in VPlan native path.

If the rest of the changes are okay then I need someone to commit this for me. Commit can be made with name Mauri Mustonen and email mauri.mustonen@tuni.fi, thanks!

Mar 5 2021, 12:00 AM · Restricted Project

Mar 4 2021

Kazhuu updated the diff for D97136: [VPlan] Support to widen select intructions in VPlan native path.

Simplify the test case and add more checks to make sure select statement operands and result are used correctly.

Mar 4 2021, 11:57 PM · Restricted Project
Kazhuu added a comment to D97278: [VPlan] Support to widen call intructions in VPlan native path.

Thanks for the review and comments @fhahn. I need someone to submit this patch for me because I don't have commit rights. Commit can be made with name Mauri Mustonen and email of mauri.mustonen@tuni.fi, thanks!

Mar 4 2021, 11:10 PM · Restricted Project

Mar 3 2021

Kazhuu added inline comments to D97378: [VPlan] Support to vectorize inner loops with VPlan native path enabled.
Mar 3 2021, 8:36 PM · Restricted Project
Kazhuu updated subscribers of D97378: [VPlan] Support to vectorize inner loops with VPlan native path enabled.
Mar 3 2021, 8:34 PM · Restricted Project
Kazhuu added inline comments to D97278: [VPlan] Support to widen call intructions in VPlan native path.
Mar 3 2021, 8:29 PM · Restricted Project

Feb 26 2021

Kazhuu added inline comments to D97378: [VPlan] Support to vectorize inner loops with VPlan native path enabled.
Feb 26 2021, 2:27 AM · Restricted Project
Kazhuu updated the diff for D97378: [VPlan] Support to vectorize inner loops with VPlan native path enabled.

Add UseVPlanNative path boolean to inform when to use VPlan native path, removed unnecessary assert modification from earlier and update the test case. Now vectorizing inner loop produces the same vectorized code when VPlan native path flag is enabled and not enabled.

Feb 26 2021, 2:23 AM · Restricted Project

Feb 25 2021

Kazhuu updated the diff for D97136: [VPlan] Support to widen select intructions in VPlan native path.

Add test cases for different select conditions and clean up test to only check relevant widened select lines. I checked other tests that other people have written and some of them also check for the relevant lines only, not all lines generated by the python script. So I did the same. Any opinions is this a preferred way?

Feb 25 2021, 7:29 AM · Restricted Project
Kazhuu added inline comments to D97378: [VPlan] Support to vectorize inner loops with VPlan native path enabled.
Feb 25 2021, 5:56 AM · Restricted Project
Kazhuu updated the diff for D97378: [VPlan] Support to vectorize inner loops with VPlan native path enabled.

Add bare minimum test case that I was able to use to reproduce the issues and it passes when the patch is applied. Also add one more assert fix that I noticed came up when testing this.

Feb 25 2021, 1:45 AM · Restricted Project

Feb 24 2021

Kazhuu added reviewers for D97378: [VPlan] Support to vectorize inner loops with VPlan native path enabled: Florian, gilr, sguggill, Ayal.
Feb 24 2021, 4:30 AM · Restricted Project
Kazhuu requested review of D97378: [VPlan] Support to vectorize inner loops with VPlan native path enabled.
Feb 24 2021, 4:21 AM · Restricted Project

Feb 23 2021

Kazhuu added inline comments to D97136: [VPlan] Support to widen select intructions in VPlan native path.
Feb 23 2021, 11:53 PM · Restricted Project
Kazhuu updated the diff for D97136: [VPlan] Support to widen select intructions in VPlan native path.

Removed use of PredicatedScalarEvolution and use ScalaEvolution instead to clean up diff.

Feb 23 2021, 11:50 PM · Restricted Project
Kazhuu added inline comments to D97136: [VPlan] Support to widen select intructions in VPlan native path.
Feb 23 2021, 9:26 AM · Restricted Project
Kazhuu updated the summary of D97136: [VPlan] Support to widen select intructions in VPlan native path.
Feb 23 2021, 6:10 AM · Restricted Project
Kazhuu added a comment to D97136: [VPlan] Support to widen select intructions in VPlan native path.

Call instruction widening as a separate patch here: https://reviews.llvm.org/D97278

Feb 23 2021, 6:06 AM · Restricted Project
Kazhuu added reviewers for D97278: [VPlan] Support to widen call intructions in VPlan native path: fhahn, rengolin, gilr.
Feb 23 2021, 6:04 AM · Restricted Project
Kazhuu requested review of D97278: [VPlan] Support to widen call intructions in VPlan native path.
Feb 23 2021, 6:03 AM · Restricted Project
Kazhuu updated the diff for D97136: [VPlan] Support to widen select intructions in VPlan native path.

Rebase with latest changes, add support for select instruction widening only in this patch and add test case for it. Add call instruction widening as a separate patch later.

Feb 23 2021, 2:02 AM · Restricted Project

Feb 21 2021

Kazhuu updated the diff for D97136: [VPlan] Support to widen select intructions in VPlan native path.

Fix failing unit tests.

Feb 21 2021, 7:02 AM · Restricted Project
Kazhuu abandoned D97143: [VPlan] Support to widen call and select intructions in VPlan native path.

Accidentally duplicated this with arcanist. Original diff here: https://reviews.llvm.org/D97136

Feb 21 2021, 6:52 AM · Restricted Project
Kazhuu updated the diff for D97143: [VPlan] Support to widen call and select intructions in VPlan native path.

Add support to widen call and select instructions in VPlan native path by using correct recipes when such instruction is encountered. This is already used by inner loop vectorizer. I modified my previously committed VPlan test to also test for the call instruction widening.

Feb 21 2021, 6:50 AM · Restricted Project
Kazhuu requested review of D97143: [VPlan] Support to widen call and select intructions in VPlan native path.
Feb 21 2021, 6:32 AM · Restricted Project

Feb 20 2021

Kazhuu updated the summary of D97136: [VPlan] Support to widen select intructions in VPlan native path.
Feb 20 2021, 11:35 PM · Restricted Project
Kazhuu updated the summary of D97136: [VPlan] Support to widen select intructions in VPlan native path.
Feb 20 2021, 11:27 PM · Restricted Project
Kazhuu requested review of D97136: [VPlan] Support to widen select intructions in VPlan native path.
Feb 20 2021, 11:21 PM · Restricted Project

Oct 6 2020

Kazhuu added a comment to D87564: [VPlan] Add vplan native path vectorization test case for inner loop reduction.

Thank you!

Oct 6 2020, 2:15 AM · Restricted Project

Oct 5 2020

Kazhuu added a comment to D87564: [VPlan] Add vplan native path vectorization test case for inner loop reduction.

Ping! Does someone want to commit this for me with the name Mauri Mustonen and email mauri_mustonen@hotmail.com, thanks!

Oct 5 2020, 11:32 PM · Restricted Project

Sep 19 2020

Kazhuu updated the diff for D87564: [VPlan] Add vplan native path vectorization test case for inner loop reduction.

Squashed diff. And I need someone to commit this change for me. It can be done with the name Mauri Mustonen and email mauri_mustonen@hotmail.com, thanks.

Sep 19 2020, 12:30 AM · Restricted Project

Sep 18 2020

Kazhuu updated the diff for D87564: [VPlan] Add vplan native path vectorization test case for inner loop reduction.

Typed all used LLVM intrinsic functions.

Sep 18 2020, 11:49 AM · Restricted Project

Sep 17 2020

Kazhuu updated the diff for D87564: [VPlan] Add vplan native path vectorization test case for inner loop reduction.

Updated FileCheck to check more detailed about vectorized basic blocks. But I'd still want to get some pointers. Is this now too detailed checking and making the check too brittle for changes?

Sep 17 2020, 11:55 AM · Restricted Project

Sep 12 2020

Kazhuu requested review of D87564: [VPlan] Add vplan native path vectorization test case for inner loop reduction.
Sep 12 2020, 10:28 AM · Restricted Project

Aug 17 2020

Kazhuu added a comment to D86068: [utils] Python utils script extract_vplan.py to extract VPlan digraphs regexp fix.

I need someone else to commit this patch for me. Commit can be made with name Mauri Mustonen and email mauri_mustonen@hotmail.com.

Aug 17 2020, 7:44 AM · Restricted Project
Kazhuu retitled D86068: [utils] Python utils script extract_vplan.py to extract VPlan digraphs regexp fix from Python utils script extract_vplan.py to extract VPlan digraphs regexp fix to [utils] Python utils script extract_vplan.py to extract VPlan digraphs regexp fix.
Aug 17 2020, 6:21 AM · Restricted Project
Kazhuu requested review of D86068: [utils] Python utils script extract_vplan.py to extract VPlan digraphs regexp fix.
Aug 17 2020, 5:49 AM · Restricted Project