- User Since
- Feb 4 2015, 5:34 AM (259 w, 2 d)
Oct 16 2015
Oct 7 2015
Oct 1 2015
Regarding how to reproduce - this problem looks remote target specific only - in my case gdb-remote modules involved.
Sep 30 2015
Test has been marked as XFAILed for Linux (x86_64) case.
Sep 29 2015
I realized what m_events.empty check in Listener::FindNextEventInternal() method returned event collection is NOT empty - probably because list.empty() just compare begin != end pointers, but pointers may be absolutely invalid.
m_lldbResult usage has beed removed in ExecRun::Acknowledge() method, corresponding member removed from cmd class.
Sep 28 2015
Requested changes applied, updated patch uploaded.
Sep 26 2015
Is this patch is fine for you now ?
Sep 25 2015
"CLI" intepreter not used in ExecRun handler in reworked patch.
Patch reworked for suggested "-exec-run --start" manner, no "CLI" interpreter use and check if --start option supported via -list-features.
Sep 24 2015
After more deep investigation I think setting listener for hijacking also looks like workaround. Setting additional listener just change code flow path and buggy path not executed, thus no crash. At top level - crash appeared in Process::m_listener involved - as no hijacked listener was set in Destroy().
Sep 23 2015
As little summary what should be added to existing lldb-mi in context of this review:
I updated patch against actual source in SVN - i.e. with taking into account your change (Halt*->Stop*).
Sep 22 2015
Due to @labath reworked and replaced HaltForDestroyOrDetach to StopHaltForDestroyOrDetach method (see http://reviews.llvm.org/D13056) and his patch already approved by @clayborg and crash still reproducible with just race condition fix patch from @labath I suggest to apply this patch first, then patch for race condition - merge should be fine.
@clayborg, I reworked initial workaround solution, now this is exact fix.
See http://reviews.llvm.org/D12968 also - fix for missed hijacked listener set in Process::HaltForDestroyOrDetach()
Sep 21 2015
Sep 18 2015
Minor initial diff cleanup.
Sep 1 2015
Feb 5 2015
Patch recalled due to concept was not accepted as good enough to apply.
Feb 4 2015
Changes requested in this review were taken into account in reworked patch - see http://reviews.llvm.org/D7409.