Would like to try to draw attention to this patch again, since it seems to have gone under the radar. Can someone review this/help get it integrated? We are still having to work around _Atomic types because we can't get to the underlying value type. Thanks

In D61239#1487406, @aaron.ballman wrote:

In D61239#1486692, @JornVernee wrote:

Also, I don't have committer access. Would you mind committing this?

Happy to do so -- I'll try to get it in this week if I have the time, but it may not happen until early next week.

In D61239#1486634, @aaron.ballman wrote:

LGTM, thank you! That's strange that clang-format would remove the newline from the end of the file. I don't get that behavior when I try it, so it makes me wonder what's different.

Removed spurious newline

• Removed const& QualType and passing by-value instead
• Ran print-type-size.c through clang-format

• Replaced plane predicates with helper methods describing their function.
• Fixed test file indentation

In D61239#1486005, @aaron.ballman wrote:

In D61239#1485994, @JornVernee wrote:

• holding of on adding helper method until hearing back.

My rationale for wanting a helper method is because we already have two places were incompleteness is important but has special cases. It's easier to maintain that with something that's a named function to explain what the predicate is actually doing. My concern is that we add another isIncompleteType() and not think about this issue.

Do we need this in validateFieldParentType()?

Add forgotten newline

• Restructured test source file to put CHECK comments inline
• Removed IAT comments.

hmm, I didn't run into this myself when building (Using VS 2017 through cmake). Looking at the CMakeLists.txt, the file is not actually being used when using MSVC... Sorry about that!

@yvvan Mind taking a look here as well?

No worries! I'm already glad there's someone who picked up the review for this so quickly ;)

Incremented minor version

Fixed the similar problem with clang_Type_getAlignOf since the patch is pretty small any ways.

@yvvan Hows that as a test?

Also, I don't have commit access, so I would need some help with that if this gets accepted :)

This seems to have changed the behaviour w.r.t inline struct or union decls in fields and global variables e.g.