Page MenuHomePhabricator

JornVernee (Jorn Vernee)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 26 2019, 4:56 PM (21 w, 15 h)

Recent Activity

May 2 2019

JornVernee added a comment to D61239: [libclang] Allow field offset lookups in types with incomplete arrays..

Also, I don't have committer access. Would you mind committing this?

Happy to do so -- I'll try to get it in this week if I have the time, but it may not happen until early next week.

May 2 2019, 3:03 AM · Restricted Project

May 1 2019

JornVernee added a comment to D61239: [libclang] Allow field offset lookups in types with incomplete arrays..

LGTM, thank you! That's strange that clang-format would remove the newline from the end of the file. I don't get that behavior when I try it, so it makes me wonder what's different.

May 1 2019, 1:16 PM · Restricted Project
JornVernee updated the diff for D61239: [libclang] Allow field offset lookups in types with incomplete arrays..

Removed spurious newline

May 1 2019, 10:12 AM · Restricted Project
JornVernee updated the diff for D61239: [libclang] Allow field offset lookups in types with incomplete arrays..
  • Removed const& QualType and passing by-value instead
  • Ran print-type-size.c through clang-format
May 1 2019, 8:25 AM · Restricted Project
JornVernee updated the diff for D61239: [libclang] Allow field offset lookups in types with incomplete arrays..
  • Replaced plane predicates with helper methods describing their function.
  • Fixed test file indentation
May 1 2019, 7:24 AM · Restricted Project
JornVernee added a comment to D61239: [libclang] Allow field offset lookups in types with incomplete arrays..
  • holding of on adding helper method until hearing back.

My rationale for wanting a helper method is because we already have two places were incompleteness is important but has special cases. It's easier to maintain that with something that's a named function to explain what the predicate is actually doing. My concern is that we add another isIncompleteType() and not think about this issue.

Do we need this in validateFieldParentType()?

May 1 2019, 7:05 AM · Restricted Project
JornVernee updated the diff for D61239: [libclang] Allow field offset lookups in types with incomplete arrays..

Add forgotten newline

May 1 2019, 6:03 AM · Restricted Project
JornVernee updated the diff for D61239: [libclang] Allow field offset lookups in types with incomplete arrays..
  • Restructured test source file to put CHECK comments inline
  • Removed IAT comments.
May 1 2019, 5:59 AM · Restricted Project

Apr 29 2019

JornVernee added a comment to rL359453: [libclang] Add missing export for clang_Cursor_isAnonymousRecordDecl.

hmm, I didn't run into this myself when building (Using VS 2017 through cmake). Looking at the CMakeLists.txt, the file is not actually being used when using MSVC... Sorry about that!

Apr 29 2019, 8:45 AM
JornVernee added a comment to D61239: [libclang] Allow field offset lookups in types with incomplete arrays..

@yvvan Mind taking a look here as well?

Apr 29 2019, 6:58 AM · Restricted Project
JornVernee added a reviewer for D61239: [libclang] Allow field offset lookups in types with incomplete arrays.: yvvan.
Apr 29 2019, 6:58 AM · Restricted Project

Apr 28 2019

JornVernee added a comment to D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour.

No worries! I'm already glad there's someone who picked up the review for this so quickly ;)

Apr 28 2019, 2:03 PM · Restricted Project, Restricted Project
JornVernee updated the diff for D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour.

Incremented minor version

Apr 28 2019, 2:03 PM · Restricted Project, Restricted Project
JornVernee updated the diff for D61239: [libclang] Allow field offset lookups in types with incomplete arrays..

Fixed the similar problem with clang_Type_getAlignOf since the patch is pretty small any ways.

Apr 28 2019, 6:37 AM · Restricted Project
JornVernee created D61239: [libclang] Allow field offset lookups in types with incomplete arrays..
Apr 28 2019, 6:19 AM · Restricted Project
JornVernee updated the diff for D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour.
Apr 28 2019, 4:20 AM · Restricted Project, Restricted Project
JornVernee updated the diff for D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour.
Apr 28 2019, 4:15 AM · Restricted Project, Restricted Project

Apr 27 2019

JornVernee added a comment to D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour.

@yvvan Hows that as a test?

Apr 27 2019, 1:35 PM · Restricted Project, Restricted Project
JornVernee updated the diff for D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour.
Apr 27 2019, 1:26 PM · Restricted Project, Restricted Project
JornVernee added a comment to D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour.

Also, I don't have commit access, so I would need some help with that if this gets accepted :)

Apr 27 2019, 12:10 PM · Restricted Project, Restricted Project
JornVernee created D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour.
Apr 27 2019, 12:06 PM · Restricted Project, Restricted Project
Herald added a project to D54996: [libclang] Fix clang_Cursor_isAnonymous: Restricted Project.

This seems to have changed the behaviour w.r.t inline struct or union decls in fields and global variables e.g.

Apr 27 2019, 6:38 AM · Restricted Project