- User Since
- May 15 2022, 8:58 AM (7 w, 23 h)
Fri, Jun 17
Thanks for taking care of this Roy and helping me out through the process!
Thu, Jun 16
For referente, I run the tests without this change on commit:
commit 94d1692aa155adf3b69609d142762b8c696e0710 (upstream/main, upstream/HEAD) Author: Fangrui Song <firstname.lastname@example.org> Date: Tue Jun 14 21:25:56 2022 -0700
I had the same failures with and without this change. It looks like these tests are already broken upstream.
I did try this locally and the built test binaries seem to crash with a segmentation fault. I run one of them in lldb to check the error and I got this backtrace:
Tue, Jun 14
Rebase on main
Thanks again for having another look at the changes! I do not have commit access since this is my first change to LLVM. I would appreciate if you could merge it. here's my username and email:
Javier Alvarez <email@example.com>
Address review feedback
Mon, Jun 13
Thanks for the review! Indeed this looks like it implements the defect report dr2171. I didn't realize there was a defect report about this, thanks for bringing it up. I am not sure If this behavior should also change for move constructors, but clang currently cannot declare defaulted move constructors with arguments other than T&& (so basically they are not trivial anyway because they are simply not allowed to be defaulted) and it seems GCC also does not allow it. In my opinion that should be fine as is, given const T&& is not quite sensible.
- Preseve ABI when clang is invoked with -fclang-abi-compat <= 14.
- Add test for defect report in clang/test/CXX/drs/dr21xx.cpp.
- Refactor ConstArg to remove if condition.
Sun, Jun 12
Fix clang-tidy tests and run clang-format