Page MenuHomePhabricator

Javier-varez (Javier Alvarez)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2022, 8:58 AM (7 w, 23 h)

Recent Activity

Fri, Jun 17

Javier-varez added a comment to D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator.

Thanks for taking care of this Roy and helping me out through the process!

Fri, Jun 17, 12:58 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 16

Javier-varez added a comment to D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator.

For referente, I run the tests without this change on commit:

commit 94d1692aa155adf3b69609d142762b8c696e0710 (upstream/main, upstream/HEAD)
Author: Fangrui Song <i@maskray.me>
Date:   Tue Jun 14 21:25:56 2022 -0700
Thu, Jun 16, 1:48 PM · Restricted Project, Restricted Project, Restricted Project
Javier-varez added a comment to D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator.

I had the same failures with and without this change. It looks like these tests are already broken upstream.

Thu, Jun 16, 1:46 PM · Restricted Project, Restricted Project, Restricted Project
Javier-varez added a comment to D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator.

I did try this locally and the built test binaries seem to crash with a segmentation fault. I run one of them in lldb to check the error and I got this backtrace:

Thu, Jun 16, 12:47 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 14

Javier-varez updated the diff for D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator.

Rebase on main

Tue, Jun 14, 9:43 PM · Restricted Project, Restricted Project, Restricted Project
Javier-varez added a comment to D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator.

Thanks again for having another look at the changes! I do not have commit access since this is my first change to LLVM. I would appreciate if you could merge it. here's my username and email:
Javier Alvarez <javier.alvarez@allthingsembedded.net>

Tue, Jun 14, 11:45 AM · Restricted Project, Restricted Project, Restricted Project
Javier-varez updated the diff for D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator.

Address review feedback

Tue, Jun 14, 11:42 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 13

Javier-varez added a comment to D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator.

Thanks for the review! Indeed this looks like it implements the defect report dr2171. I didn't realize there was a defect report about this, thanks for bringing it up. I am not sure If this behavior should also change for move constructors, but clang currently cannot declare defaulted move constructors with arguments other than T&& (so basically they are not trivial anyway because they are simply not allowed to be defaulted) and it seems GCC also does not allow it. In my opinion that should be fine as is, given const T&& is not quite sensible.

Mon, Jun 13, 12:41 PM · Restricted Project, Restricted Project, Restricted Project
Javier-varez updated the diff for D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator.
  • Preseve ABI when clang is invoked with -fclang-abi-compat <= 14.
  • Add test for defect report in clang/test/CXX/drs/dr21xx.cpp.
  • Refactor ConstArg to remove if condition.
Mon, Jun 13, 12:34 PM · Restricted Project, Restricted Project, Restricted Project

Sun, Jun 12

Javier-varez updated the diff for D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator.

Fix clang-tidy tests and run clang-format

Sun, Jun 12, 4:24 AM · Restricted Project, Restricted Project, Restricted Project
Javier-varez requested review of D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator.
Sun, Jun 12, 3:22 AM · Restricted Project, Restricted Project, Restricted Project