Page MenuHomePhabricator
People JMazurkiewicz

JMazurkiewicz (Jakub Mazurkiewicz)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 23 2022, 3:06 PM (35 w, 5 d)

Recent Activity
View All

Thu, May 18

JMazurkiewicz added a comment to D150183: [Clang][clang-cl] Implement `__builtin_FUNCSIG`.

Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution?

Yes, my name and email: "Jakub Mazurkiewicz <mazkuba3@gmail.com>".

I can fix up the release notes when I land, so you don't have to upload a new patch.

Thank you in advance.

Thu, May 18, 8:31 AM · Restricted Project, Restricted Project
JMazurkiewicz updated the diff for D150183: [Clang][clang-cl] Implement `__builtin_FUNCSIG`.
  • Address comments (thanks for the review @aaron.ballman!),
  • Remove clang-format changes (CI might fail),
  • Add extra tests in clang/test/Preprocessor/feature_tests.cpp.
Thu, May 18, 6:56 AM · Restricted Project, Restricted Project

Wed, May 17

JMazurkiewicz updated the diff for D150183: [Clang][clang-cl] Implement `__builtin_FUNCSIG`.

Try to fix formatting in ParseExpr.cpp.

Wed, May 17, 9:35 AM · Restricted Project, Restricted Project

Fri, May 12

JMazurkiewicz added inline comments to D144742: [libc++][format] Improves fill character..
Fri, May 12, 4:39 PM · Restricted Project, Restricted Project

Tue, May 9

JMazurkiewicz updated the diff for D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.

Rebase; fix CI.

Tue, May 9, 6:44 AM · Restricted Project, Restricted Project
JMazurkiewicz updated the diff for D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.

Rebase; try to fix CI.

Tue, May 9, 3:55 AM · Restricted Project, Restricted Project
JMazurkiewicz requested review of D150183: [Clang][clang-cl] Implement `__builtin_FUNCSIG`.
Tue, May 9, 2:05 AM · Restricted Project, Restricted Project

Apr 25 2023

JMazurkiewicz set the repository for D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by` to rG LLVM Github Monorepo.
Apr 25 2023, 12:07 PM · Restricted Project, Restricted Project
JMazurkiewicz updated the diff for D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.
  • Test all added assertions,
  • Rebase,
  • Fix CI?

TODO: transitive includes

Apr 25 2023, 7:41 AM · Restricted Project, Restricted Project

Apr 18 2023

JMazurkiewicz added inline comments to D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.
Apr 18 2023, 5:35 AM · Restricted Project, Restricted Project

Apr 17 2023

JMazurkiewicz updated the diff for D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.

Fix CI

Apr 17 2023, 6:39 AM · Restricted Project, Restricted Project
JMazurkiewicz updated the diff for D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.
  • Address some of @Mordante's comments
  • Rename iterator directory to range.chunk.by.iter
Apr 17 2023, 5:50 AM · Restricted Project, Restricted Project

Mar 22 2023

JMazurkiewicz updated the diff for D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.

Fix CI.

Mar 22 2023, 5:56 AM · Restricted Project, Restricted Project
JMazurkiewicz updated the diff for D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.

Rebase

Mar 22 2023, 2:16 AM · Restricted Project, Restricted Project

Mar 12 2023

JMazurkiewicz added a comment to D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.

Thank you, @fsb4000!

Mar 12 2023, 1:55 AM · Restricted Project, Restricted Project

Mar 11 2023

JMazurkiewicz updated the diff for D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.

Fix CI

Mar 11 2023, 1:56 PM · Restricted Project, Restricted Project

Mar 10 2023

JMazurkiewicz updated the diff for D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.

Update transitive includes manually.

Mar 10 2023, 4:19 PM · Restricted Project, Restricted Project

Mar 2 2023

JMazurkiewicz updated the diff for D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.

Fix formatting.

Mar 2 2023, 6:36 AM · Restricted Project, Restricted Project

Mar 1 2023

JMazurkiewicz updated the diff for D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.

Improve test coverage.
I haven't fixed the problem with transitive includes yet - does anyone know what might be the reason of this failure? (I've marked problematic includes with FIXME transitive include comment)

Mar 1 2023, 4:36 PM · Restricted Project, Restricted Project

Feb 24 2023

JMazurkiewicz updated the diff for D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.

Fix CI (add missing includes), and update release notes.

Feb 24 2023, 7:09 PM · Restricted Project, Restricted Project
JMazurkiewicz updated the diff for D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.

Try to fix CI.

Feb 24 2023, 5:12 PM · Restricted Project, Restricted Project
JMazurkiewicz set the repository for D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by` to rG LLVM Github Monorepo.
Feb 24 2023, 5:09 PM · Restricted Project, Restricted Project
JMazurkiewicz updated subscribers of D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.
Feb 24 2023, 4:32 PM · Restricted Project, Restricted Project
JMazurkiewicz requested review of D144767: [libc++][ranges] Implement P2443R1: `views::chunk_by`.
Feb 24 2023, 4:31 PM · Restricted Project, Restricted Project

Feb 23 2023

JMazurkiewicz added inline comments to D144629: [libc++] Implement LWG-3204 sub_match::swap only swaps the base class.
Feb 23 2023, 6:51 AM · Restricted Project, Restricted Project

Jan 22 2023

JMazurkiewicz added inline comments to D142302: [libc++][format] Fixes usage of contiguous ranges..
Jan 22 2023, 6:03 AM · Restricted Project, Restricted Project