Page MenuHomePhabricator

GeorgeARM (Georgios Pinitas)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 12 2022, 11:15 AM (10 w, 6 d)

Recent Activity

Mon, Jun 6

GeorgeARM added a comment to D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.

Hello all.
Any more comments on this? @jpienaar @rsuderman @stellaraccident

Mon, Jun 6, 12:33 PM · Restricted Project, Restricted Project

Wed, Jun 1

GeorgeARM updated the diff for D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.

Rename pass to TosaLayerwiseConstantFoldPass as per RFC suggestions.

Wed, Jun 1, 10:31 AM · Restricted Project, Restricted Project

Sun, May 29

GeorgeARM added a comment to D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.

Generally LGTM, although we may want to further constrain this in a follow-up. In general, I am pro having optimization passes and having them be truly optional. I would be tempted to name this "TensorDataConstantOptimizationPass".

Sun, May 29, 12:46 AM · Restricted Project, Restricted Project

May 24 2022

GeorgeARM added a comment to D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.

Can you clarify the revision description? You refer to some "unbound computation" which isn't clear to me. I think the whole motivation and rationale could be better spelled out.

(also remove the Change-Id: I7ec0f8b15ca6bc9aa2116488dcf6c684c9826ddd part which seems a leftover of some other system?)

May 24 2022, 4:11 PM · Restricted Project, Restricted Project
GeorgeARM updated the diff for D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.

Update commit message

May 24 2022, 4:09 PM · Restricted Project, Restricted Project
GeorgeARM updated the diff for D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.

Reworks commit message:

  • Description simplification
  • Remove unneeded Change-Id
May 24 2022, 4:01 PM · Restricted Project, Restricted Project
GeorgeARM added inline comments to D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.
May 24 2022, 11:27 AM · Restricted Project, Restricted Project
GeorgeARM added a comment to D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.

@rsuderman @jpienaar any further updates needed?
thank you in advance

May 24 2022, 7:20 AM · Restricted Project, Restricted Project

May 16 2022

GeorgeARM added a comment to D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.

Good point about potentially expensive operations here, I wonder: why is/was this a canonicalization pattern rather than fold implementation?

Not sure @jpienaar why this was registered as a canonicalization originally. Can comment though that have noticed this being quite expensive. Moreover, a similar folding step takes place at Linalg level from what I recall.

May 16 2022, 12:27 PM · Restricted Project, Restricted Project
GeorgeARM updated the diff for D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.

Address review comments.

May 16 2022, 12:12 PM · Restricted Project, Restricted Project

May 4 2022

GeorgeARM added inline comments to D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.
May 4 2022, 9:43 AM · Restricted Project, Restricted Project

Apr 29 2022

GeorgeARM requested review of D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.
Apr 29 2022, 10:13 AM · Restricted Project, Restricted Project