Page MenuHomePhabricator

Flow (Florian Schmaus)
User

Projects

User does not belong to any projects.

User Details

User Since
May 7 2020, 6:59 AM (58 w, 4 h)

Recent Activity

Feb 22 2021

Flow added a comment to D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy.

LGTM! thanks for fixing.

I am unable to commit this myself. The latest version of this change can be found in the install-run-clang-tidy-into-bin on my LLVM fork.

Noticed this is a little stale, Do you still want this landing?

Feb 22 2021, 10:09 PM · Restricted Project, Restricted Project

Dec 10 2020

Flow added a comment to D92490: [msan] Do not use 77 as exit code, instead use 1.

LGTM

Dec 10 2020, 10:21 AM · Restricted Project
Flow requested review of D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy.

LGTM! thanks for fixing.

Dec 10 2020, 10:09 AM · Restricted Project, Restricted Project

Dec 2 2020

Flow added a comment to D92490: [msan] Do not use 77 as exit code, instead use 1.

What is going to be the default?

Dec 2 2020, 11:07 PM · Restricted Project
Flow added reviewers for D92490: [msan] Do not use 77 as exit code, instead use 1: vitalybuka, eugenis.
Dec 2 2020, 9:13 AM · Restricted Project
Flow requested review of D92490: [msan] Do not use 77 as exit code, instead use 1.
Dec 2 2020, 9:12 AM · Restricted Project

Nov 7 2020

Flow updated the diff for D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy.

Use backticks in ReleaseNotes

Nov 7 2020, 7:57 AM · Restricted Project, Restricted Project
Flow abandoned D91001: [clang-tidy] Install run-clang-tidy.py as run-clang-tidy.

All changes introduced by this are now done in https://reviews.llvm.org/D90972

Nov 7 2020, 6:23 AM · Restricted Project, Restricted Project
Flow updated the summary of D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy.
Nov 7 2020, 6:21 AM · Restricted Project, Restricted Project
Flow updated the diff for D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy.
Nov 7 2020, 6:21 AM · Restricted Project, Restricted Project
Flow added a comment to D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy.

By the way, while you are working on it, why not removing the python extension when installing? We don't need to know that it is Python code.

Nov 7 2020, 4:25 AM · Restricted Project, Restricted Project
Flow added reviewers for D91001: [clang-tidy] Install run-clang-tidy.py as run-clang-tidy: alexfh, sylvestre.ledru, Eugene.Zelenko.
Nov 7 2020, 4:24 AM · Restricted Project, Restricted Project
Flow requested review of D91001: [clang-tidy] Install run-clang-tidy.py as run-clang-tidy.
Nov 7 2020, 4:23 AM · Restricted Project, Restricted Project
Flow added reviewers for D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy: alexfh, sylvestre.ledru, Eugene.Zelenko.

Adding involved persons from https://reviews.llvm.org/D12700 as reviewers, which was the change introducing share/clang/ as install location.

Nov 7 2020, 12:42 AM · Restricted Project, Restricted Project

Nov 6 2020

Flow requested review of D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy.
Nov 6 2020, 2:06 PM · Restricted Project, Restricted Project

May 20 2020

Flow added a comment to D79575: Extend Compilation Database by an optional field for compiler arguments.

Hi, thanks for sending this! I'm sympathetic to wanting this fixed but a bit skeptical about changing it :-) It would be good to discuss the tradeoffs, and in any case document whether we expect this problem to be solved by build systems, consuming tools, or in the format.

May 20 2020, 1:34 AM
Flow updated the diff for D79575: Extend Compilation Database by an optional field for compiler arguments.

Instead of repeating the complete string of compiler arguments in the new optional field, simply have them provide an index into the respective 'command' or 'arguments' field values.

May 20 2020, 1:02 AM

May 7 2020

Flow added a reviewer for D79575: Extend Compilation Database by an optional field for compiler arguments: silvas.
May 7 2020, 7:20 AM
Flow created D79575: Extend Compilation Database by an optional field for compiler arguments.
May 7 2020, 7:20 AM
Flow updated the summary of D79575: Extend Compilation Database by an optional field for compiler arguments.
May 7 2020, 7:20 AM