Page MenuHomePhabricator

FederAndInk (Ludovic Jozeau)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 17 2021, 5:38 PM (9 w, 2 d)

Linux, C++ and open source enthusiast.

Recent Activity

Fri, Sep 24

FederAndInk retitled D108765: [docs][clang-format] use yaml types style from [docs] Fix documentation of clang-format BasedOnStyle type to [docs][clang-format] use yaml types style.
Fri, Sep 24, 3:15 AM · Restricted Project, Restricted Project
FederAndInk added a comment to D108765: [docs][clang-format] use yaml types style.

Also, don't we want to change the title and summary of the commit/revision? Because it does not reflect the real changes now in the repo

Fri, Sep 24, 2:10 AM · Restricted Project, Restricted Project
FederAndInk added a comment to D108765: [docs][clang-format] use yaml types style.

Thanks for the merge, I now understand more how this all works and what we want from these scripts.

Fri, Sep 24, 1:58 AM · Restricted Project, Restricted Project

Sep 9 2021

FederAndInk added a comment to D108765: [docs][clang-format] use yaml types style.

@MyDeveloperDay is it all good? I'm sorry for all the misunderstanding,

Sep 9 2021, 4:55 PM · Restricted Project, Restricted Project

Sep 6 2021

FederAndInk updated the diff for D108765: [docs][clang-format] use yaml types style.

only print info on generated plurals if there is a new plural

Sep 6 2021, 12:13 PM · Restricted Project, Restricted Project
FederAndInk updated the diff for D108765: [docs][clang-format] use yaml types style.

remove one print l17, tell me if we don't want the second print (now l17)

Sep 6 2021, 11:02 AM · Restricted Project, Restricted Project
FederAndInk added inline comments to D108765: [docs][clang-format] use yaml types style.
Sep 6 2021, 5:39 AM · Restricted Project, Restricted Project
FederAndInk updated the diff for D108765: [docs][clang-format] use yaml types style.

rebase main

Sep 6 2021, 3:26 AM · Restricted Project, Restricted Project

Sep 5 2021

FederAndInk added a comment to D108765: [docs][clang-format] use yaml types style.

Ok, so I removed git invocation and I tell the user what are their options, at least warnings are emitted for new plurals, and they will be shown in git status/diff and in revisions.

Sep 5 2021, 7:14 AM · Restricted Project, Restricted Project
FederAndInk updated the diff for D108765: [docs][clang-format] use yaml types style.

remove git invocation and user input, tell the user what the plurals are used for

Sep 5 2021, 7:00 AM · Restricted Project, Restricted Project

Sep 4 2021

FederAndInk added inline comments to D108765: [docs][clang-format] use yaml types style.
Sep 4 2021, 1:03 PM · Restricted Project, Restricted Project
FederAndInk updated the diff for D108765: [docs][clang-format] use yaml types style.

use correct python assignment from tuple, ask the user if they want to invoke git, use call instead of check_call to allow testing

Sep 4 2021, 11:37 AM · Restricted Project, Restricted Project

Aug 31 2021

FederAndInk updated FederAndInk.
Aug 31 2021, 3:49 AM
FederAndInk added a comment to D108765: [docs][clang-format] use yaml types style.
error: pathspec './plurals.txt' did not match any file(s) known to git
Traceback (most recent call last):
  File "./dump_format_style.py", line 18, in <module>
    subprocess.check_call(['git', 'checkout', '--', PLURAL_FILE])
  File "/usr/lib/python3.8/subprocess.py", line 364, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'checkout', '--', './plurals.txt']' returned non-zero exit status 1.
Aug 31 2021, 3:40 AM · Restricted Project, Restricted Project

Aug 30 2021

FederAndInk updated the diff for D108765: [docs][clang-format] use yaml types style.

add common plural rules, use python3 explicitly, reorder imports

Aug 30 2021, 12:23 PM · Restricted Project, Restricted Project
FederAndInk added inline comments to D108765: [docs][clang-format] use yaml types style.
Aug 30 2021, 12:21 PM · Restricted Project, Restricted Project
FederAndInk added inline comments to D108765: [docs][clang-format] use yaml types style.
Aug 30 2021, 12:06 PM · Restricted Project, Restricted Project
FederAndInk added inline comments to D108765: [docs][clang-format] use yaml types style.
Aug 30 2021, 9:25 AM · Restricted Project, Restricted Project
FederAndInk updated the diff for D108765: [docs][clang-format] use yaml types style.

generate plurals, for now supporting -y ending (-y to -ies/-ys), track generated plurals and show new ones to be checked

Aug 30 2021, 6:14 AM · Restricted Project, Restricted Project
FederAndInk added a comment to D108765: [docs][clang-format] use yaml types style.

Ok, here is my proposal for plurals, I have some ideas, I think the safest/most complete would be to have a file tracking generated plurals and tell the user of the script to check newly generated plurals then add them to git, this would also allow reviewers to see new plurals generated. I'll put the updated revision of my idea soon.

Aug 30 2021, 6:14 AM · Restricted Project, Restricted Project

Aug 27 2021

FederAndInk added inline comments to D108765: [docs][clang-format] use yaml types style.
Aug 27 2021, 3:42 PM · Restricted Project, Restricted Project
FederAndInk added a comment to D108765: [docs][clang-format] use yaml types style.

look at the html

Aug 27 2021, 6:56 AM · Restricted Project, Restricted Project
FederAndInk added a comment to D108765: [docs][clang-format] use yaml types style.

For now, I handle plural manually, but it can be changed, I also kept Unsigned, what are your thoughts?

Aug 27 2021, 5:57 AM · Restricted Project, Restricted Project
FederAndInk updated the diff for D108765: [docs][clang-format] use yaml types style.

Use yaml type style for clang-format documentation (String, Integer, List of Strings, ...) instead of c++ types.

Aug 27 2021, 5:49 AM · Restricted Project, Restricted Project
FederAndInk added a comment to D108765: [docs][clang-format] use yaml types style.

Ok, well, the reason I proposed this patch in the first place was that I have been working on a .clang-format schema (https://json-schema.org/) :) and I spotted the inconsistency. I checked, and clang-format reports an error if we give a negative value to an option expecting an unsigned. In the schema I am able to specify a minimum and I think it's appropriate to give the information to the user that it expect a positive/unsigned integer, what do you think?

Aug 27 2021, 5:42 AM · Restricted Project, Restricted Project

Aug 26 2021

FederAndInk added a comment to D108765: [docs][clang-format] use yaml types style.

What about: unsigned? And enum or struct types such as BracketAlignmentStyle, ArrayInitializerAlignmentStyle, ...? Should we add something like: Enum BracketAlignmentStyle and Dictionnary BraceWrapping?

Aug 26 2021, 1:35 PM · Restricted Project, Restricted Project
FederAndInk added a comment to D108765: [docs][clang-format] use yaml types style.

Thank you for your explanations, I understand now.

Aug 26 2021, 8:30 AM · Restricted Project, Restricted Project
FederAndInk requested review of D108765: [docs][clang-format] use yaml types style.
Aug 26 2021, 7:31 AM · Restricted Project, Restricted Project
FederAndInk updated FederAndInk.
Aug 26 2021, 6:55 AM

Aug 17 2021

FederAndInk awarded D33029: [clang-format] add option for dangling parenthesis a Love token.
Aug 17 2021, 5:38 PM · Restricted Project, Restricted Project