Page MenuHomePhabricator

FMarno (Finlay Marno)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 7 2022, 7:46 AM (12 w, 1 d)

Recent Activity

Dec 13 2022

FMarno added a comment to D137652: Remove mandatory define of optional features macros for OpenCL C 3.0.

Thank you for your comments. Unfortunately I won't be able to implement these changes because of time constraints in the current project, sorry if I've wasted your time.
On the bright side I feel like I've learned something so thank you for that. I hope I can make a proper contribution in the future.

Dec 13 2022, 8:56 AM · Restricted Project, Restricted Project

Nov 29 2022

FMarno added a comment to D137652: Remove mandatory define of optional features macros for OpenCL C 3.0.

@Anastasia I feel like I am following the guidance you quoted here. The defines I've deleted in opencl-c-base.h are blocking the possibility of -cl-ext working and would also get in the way of undefine preprocessor symbols working.
If there is a problem with the additions to OpenCLExtensions.def then we'll need to rework how InitializeOpenCLFeatureTestMacros in initPreprocessor.cpp works.

Nov 29 2022, 7:56 AM · Restricted Project, Restricted Project

Nov 8 2022

FMarno requested review of D137652: Remove mandatory define of optional features macros for OpenCL C 3.0.
Nov 8 2022, 9:14 AM · Restricted Project, Restricted Project