Page MenuHomePhabricator
People EgorBo

EgorBo (Egor Bogatov)
User

Projects

User does not belong to any projects.

User Details

User Since
May 1 2020, 3:40 PM (26 w, 1 d)

Recent Activity
View All

Jun 10 2020

EgorBo added a comment to D79369: [InstCombine] "X - (X / C) * C == 0" to "X & C-1 == 0".
In D79369#2085994, @lebedev.ri wrote:

LGTM, thanks you.
If you need help committing this, do specify the "name <e@ma.il>" to be used.

Jun 10 2020, 3:35 PM · Restricted Project
EgorBo updated the diff for D79369: [InstCombine] "X - (X / C) * C == 0" to "X & C-1 == 0".

@lebedev.ri I am so sorry for this huge delay, totally forgot about this pr and broke my notifications, I promise I'll respond without delays in future :-) Addressed your feedback I beleive.

Jun 10 2020, 12:46 PM · Restricted Project

May 7 2020

EgorBo added a comment to D79369: [InstCombine] "X - (X / C) * C == 0" to "X & C-1 == 0".

@lebedev.ri can you please re-review? do you want me to add more tests?

May 7 2020, 10:14 AM · Restricted Project
EgorBo updated the diff for D79369: [InstCombine] "X - (X / C) * C == 0" to "X & C-1 == 0".

Add more tests (undef, negative, non-splat vectors)

May 7 2020, 10:14 AM · Restricted Project

May 5 2020

EgorBo updated the diff for D79369: [InstCombine] "X - (X / C) * C == 0" to "X & C-1 == 0".

Add more tests (TODO: non-splat vectors)

May 5 2020, 6:22 PM · Restricted Project
EgorBo updated the diff for D79369: [InstCombine] "X - (X / C) * C == 0" to "X & C-1 == 0".

Add more tests (TODO: add non-splat vectors)

May 5 2020, 6:22 PM · Restricted Project
EgorBo added a comment to D79369: [InstCombine] "X - (X / C) * C == 0" to "X & C-1 == 0".

@lebedev.ri Thanks for review!
I've moved the transformation to "InstCombiner::visitAdd"

May 5 2020, 4:48 AM · Restricted Project
EgorBo updated the diff for D79369: [InstCombine] "X - (X / C) * C == 0" to "X & C-1 == 0".

Moved to InstCombiner::visitAdd

May 5 2020, 4:48 AM · Restricted Project

May 4 2020

EgorBo updated the diff for D79369: [InstCombine] "X - (X / C) * C == 0" to "X & C-1 == 0".

Fix test name

May 4 2020, 4:09 PM · Restricted Project
EgorBo created D79369: [InstCombine] "X - (X / C) * C == 0" to "X & C-1 == 0".
May 4 2020, 3:05 PM · Restricted Project
EgorBo updated the summary of D79369: [InstCombine] "X - (X / C) * C == 0" to "X & C-1 == 0".
May 4 2020, 3:05 PM · Restricted Project
EgorBo added reviewers for D79369: [InstCombine] "X - (X / C) * C == 0" to "X & C-1 == 0": lebedev.ri, spatel.
May 4 2020, 3:05 PM · Restricted Project