Page MenuHomePhabricator

E5ten (Ethan Sommer)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 24 2018, 10:35 AM (33 w, 2 d)

Recent Activity

May 21 2019

E5ten added a comment to D61909: Add Clang shared library with C++ exports.

@beanz But if libclang_shared is intended to be a shippable binary and BUILD_SHARED_LIBS is only intended to be an option used in developer builds, and libclang_shared while not causing conflicts (thanks for the info on how that works by the way) would be redundant in a local developer build one would see BUILD_SHARED_LIBS enabled in wouldn't it? And also to me it doesn't really make sense to enable the intended shippable binary in a build that is specifically enabling a developer option, and so is obviously not intended for shipment (I get that in the arch case it is intended for shipment but that case is them using an option they shouldn't not the option being one that should be used when the built products are intended for redistribution).

May 21 2019, 2:41 PM · Restricted Project
E5ten added a comment to D61909: Add Clang shared library with C++ exports.

@beanz Well I took libclang_shared as effectively an equivalent to the libLLVM.so that's created with that dylib option, and when BUILD_SHARED_LIBS is enabled that library is not created, in fact the option to create that library conflicts with BUILD_SHARED_LIBS. Also when the libs are built shared and also as object libraries that are linked into libclang_shared would that not cause the same libraries to be linked into executables twice, once through the shared libraries and once through libclang_shared?

May 21 2019, 2:22 PM · Restricted Project
E5ten added a comment to D61909: Add Clang shared library with C++ exports.

@beanz Wouldn't fixing this by adding OR BUILD_SHARED_LIBS to if(ARG_SHARED) in AddClang.cmake and to if (NOT LLVM_ENABLE_PIC) in clang-shlib/CMakeLists.txt to prevent making libclang_shared when BUILD_SHARED_LIBS is enabled make more sense?

May 21 2019, 12:20 PM · Restricted Project
E5ten added a comment to D61909: Add Clang shared library with C++ exports.

I might be doing something wrong but this seems to have broken BUILD_SHARED_LIBS for me in that even with that enabled clang is built as a bunch of static libraries linked into a shared one like this patch is supposed to make it do, while I thought that BUILD_SHARED_LIBS was supposed to make it create a bunch of shared libraries as it did before with libclang and still does with libLLVM.

May 21 2019, 6:11 AM · Restricted Project

Apr 4 2019

Herald updated subscribers of D55550: [LLD][ELF] - Fix the different behavior of the linker script symbols on different platforms..
Apr 4 2019, 6:10 PM · Restricted Project

Mar 13 2019

E5ten added inline comments to D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux.
Mar 13 2019, 5:33 AM · Restricted Project, Restricted Project

Mar 9 2019

E5ten added inline comments to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.
Mar 9 2019, 1:24 PM · Restricted Project, Restricted Project