Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Discookie (Discookie)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 27 2022, 6:49 PM (74 w, 6 d)

Recent Activity

Thu, Sep 28

Discookie added a comment to D158156: [analyzer] Add C++ array delete checker.

Ran the checker on a couple larger projects, but no real-world reports found so far (same as DeleteWithNonVirtualDtor). Can't tell if it's an engine limitation or just the bug being uncommon in general.

Thu, Sep 28, 4:06 AM · Restricted Project, Restricted Project
Discookie updated the diff for D158156: [analyzer] Add C++ array delete checker.
Thu, Sep 28, 3:58 AM · Restricted Project, Restricted Project
Discookie updated the diff for D158156: [analyzer] Add C++ array delete checker.

Replaced backticks with single quotes.

Thu, Sep 28, 3:55 AM · Restricted Project, Restricted Project

Tue, Sep 26

Discookie added a comment to D158156: [analyzer] Add C++ array delete checker.

@steakhal gentle ping for one last round of reviews

Tue, Sep 26, 12:27 AM · Restricted Project, Restricted Project

Mon, Sep 18

Discookie added inline comments to D158156: [analyzer] Add C++ array delete checker.
Mon, Sep 18, 1:42 AM · Restricted Project, Restricted Project
Discookie added inline comments to D158156: [analyzer] Add C++ array delete checker.
Mon, Sep 18, 1:40 AM · Restricted Project, Restricted Project
Discookie updated the diff for D158156: [analyzer] Add C++ array delete checker.

Updated the visitor to track all conversions, and have type names for clarity.

Mon, Sep 18, 1:32 AM · Restricted Project, Restricted Project

Mon, Sep 11

Discookie added inline comments to D158156: [analyzer] Add C++ array delete checker.
Mon, Sep 11, 1:29 AM · Restricted Project, Restricted Project
Discookie updated the diff for D158156: [analyzer] Add C++ array delete checker.

Added a test for taking last upcast only for the note tag. For now the visitor matches all explicit casts, because there are too many edge cases to count for now wrt. explicit upcasting.

Mon, Sep 11, 1:28 AM · Restricted Project, Restricted Project

Tue, Sep 5

Discookie added a comment to D158156: [analyzer] Add C++ array delete checker.

Fixed the formatting issues as well.

Tue, Sep 5, 1:50 AM · Restricted Project, Restricted Project
Discookie updated the diff for D158156: [analyzer] Add C++ array delete checker.

Refactored the checkers to use a shared base class, otherwise I kept the same functionality.

Tue, Sep 5, 1:27 AM · Restricted Project, Restricted Project

Aug 21 2023

Discookie planned changes to D158156: [analyzer] Add C++ array delete checker.

Indeed it would make more sense to separate checkers into their own classes, but using a shared base. This checker doesn't have quite as advanced logic as MallocChecker, so there's not that much of a need for a single class managing everything. I'll change the checker to that system.

Aug 21 2023, 2:58 AM · Restricted Project, Restricted Project

Aug 17 2023

Discookie requested review of D158156: [analyzer] Add C++ array delete checker.
Aug 17 2023, 1:14 AM · Restricted Project, Restricted Project

Mar 23 2023

Discookie requested review of D146712: [clang-tidy] Add portability-non-portable-integer-constant check.
Mar 23 2023, 5:16 AM · Restricted Project, Restricted Project