Page MenuHomePhabricator

CoelacanthusHex (Celeste Liu)
User

Projects

User does not belong to any projects.

User Details

User Since
May 6 2021, 3:39 AM (91 w, 5 d)

Recent Activity

Jul 29 2022

CoelacanthusHex added a comment to D130560: [RISCV] Handle register spill in branch relaxation.

There seems to be a problem here: if we perform only some operations on registers without sd after a jump (which can easily happen if only a few short instructions are executed between jumps), we then jump to another place. If we still restore immediately in this case, we are actually wasting resources.

Yes. We can construct a loop with a few instructions executed and a long jump at each iteration, making the jump scratch register saved/restored frequently. Maybe we can add a TODO in BranchRelaxation.cpp for future improvements?

Jul 29 2022, 1:10 AM · Restricted Project, Restricted Project

Jul 28 2022

CoelacanthusHex added a comment to D130560: [RISCV] Handle register spill in branch relaxation.

There seems to be a problem here: if we perform only some operations on registers without sd after a jump (which can easily happen if only a few short instructions are executed between jumps), we then jump to another place. If we still restore immediately in this case, we are actually wasting resources.

Jul 28 2022, 6:20 AM · Restricted Project, Restricted Project

Jun 17 2022

CoelacanthusHex updated subscribers of D127581: [ELF] Relax R_RISCV_ALIGN.
Jun 17 2022, 1:30 AM · Restricted Project, Restricted Project

May 23 2022

CoelacanthusHex updated subscribers of D126188: [RISCV] Make old JIT ExecutionEngine tests unsupported.
May 23 2022, 3:02 AM · Restricted Project, Restricted Project

Jan 14 2022

CoelacanthusHex committed rG1dab5f6c83a7: [LLDB][NFC] Fix a typo in comment (authored by CoelacanthusHex).
[LLDB][NFC] Fix a typo in comment
Jan 14 2022, 6:01 AM
CoelacanthusHex closed D117288: [LLDB][NFC] Fix a typo in comment.
Jan 14 2022, 6:01 AM · Restricted Project
CoelacanthusHex added a reviewer for D117288: [LLDB][NFC] Fix a typo in comment: uweigand.
Jan 14 2022, 12:33 AM · Restricted Project
CoelacanthusHex added a reviewer for D117288: [LLDB][NFC] Fix a typo in comment: danilashtefan.
Jan 14 2022, 12:32 AM · Restricted Project
CoelacanthusHex added a reviewer for D117288: [LLDB][NFC] Fix a typo in comment: wallace.
Jan 14 2022, 12:31 AM · Restricted Project
CoelacanthusHex requested review of D117288: [LLDB][NFC] Fix a typo in comment.
Jan 14 2022, 12:29 AM · Restricted Project

Nov 26 2021

CoelacanthusHex updated CoelacanthusHex.
Nov 26 2021, 1:37 AM

May 6 2021

CoelacanthusHex committed rGe6cf3d64412c: [TableGen] Use range-based for loops (NFC) (authored by CoelacanthusHex).
[TableGen] Use range-based for loops (NFC)
May 6 2021, 10:34 PM
CoelacanthusHex closed D101994: [TableGen] Use range-based for loops (NFC).
May 6 2021, 10:34 PM · Restricted Project
CoelacanthusHex updated the diff for D101994: [TableGen] Use range-based for loops (NFC).
May 6 2021, 8:49 PM · Restricted Project
CoelacanthusHex updated the diff for D101994: [TableGen] Use range-based for loops (NFC).
May 6 2021, 8:47 PM · Restricted Project
CoelacanthusHex updated the diff for D101994: [TableGen] Use range-based for loops (NFC).
May 6 2021, 9:07 AM · Restricted Project
CoelacanthusHex added a comment to D101994: [TableGen] Use range-based for loops (NFC).

I guess you should capitalize all the range iterator variables.

May 6 2021, 8:16 AM · Restricted Project
CoelacanthusHex updated the diff for D101994: [TableGen] Use range-based for loops (NFC).
May 6 2021, 7:58 AM · Restricted Project
CoelacanthusHex updated the diff for D101994: [TableGen] Use range-based for loops (NFC).
May 6 2021, 7:43 AM · Restricted Project
CoelacanthusHex added a reviewer for D101994: [TableGen] Use range-based for loops (NFC): Paul-C-Anagnostopoulos.
May 6 2021, 7:00 AM · Restricted Project
CoelacanthusHex requested review of D101994: [TableGen] Use range-based for loops (NFC).
May 6 2021, 6:34 AM · Restricted Project