Page MenuHomePhabricator

CJ-Johnson (CJ Johnson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 2 2020, 8:06 AM (93 w, 2 d)

Recent Activity

Thu, Sep 30

CJ-Johnson abandoned D110842: [NFC][AMDGPU] Improve cost model tests coverage..
Thu, Sep 30, 8:27 AM · Restricted Project
CJ-Johnson requested review of D110842: [NFC][AMDGPU] Improve cost model tests coverage..
Thu, Sep 30, 8:26 AM · Restricted Project

Mon, Sep 27

CJ-Johnson abandoned D110574: Test diff, please ignore.
Mon, Sep 27, 12:17 PM · Restricted Project
CJ-Johnson requested review of D110574: Test diff, please ignore.
Mon, Sep 27, 12:11 PM · Restricted Project
CJ-Johnson abandoned D110559: Test branch commit, please ignore.
Mon, Sep 27, 9:28 AM · Restricted Project
CJ-Johnson abandoned D110562: Test diff, please ignore. Trying for a third time!.
Mon, Sep 27, 9:27 AM · Restricted Project
CJ-Johnson updated the diff for D110562: Test diff, please ignore. Trying for a third time!.

Now with code! Will it run the tests?

Mon, Sep 27, 9:25 AM · Restricted Project
CJ-Johnson updated the diff for D110562: Test diff, please ignore. Trying for a third time!.

Amended commit??

Mon, Sep 27, 9:20 AM · Restricted Project
CJ-Johnson added inline comments to D110562: Test diff, please ignore. Trying for a third time!.
Mon, Sep 27, 9:20 AM · Restricted Project
CJ-Johnson requested review of D110562: Test diff, please ignore. Trying for a third time!.
Mon, Sep 27, 9:19 AM · Restricted Project
CJ-Johnson updated the diff for D110559: Test branch commit, please ignore.

Trying again but with a branch to see if that helps

Mon, Sep 27, 8:30 AM · Restricted Project
CJ-Johnson added inline comments to D110559: Test branch commit, please ignore.
Mon, Sep 27, 8:28 AM · Restricted Project
CJ-Johnson requested review of D110559: Test branch commit, please ignore.
Mon, Sep 27, 8:27 AM · Restricted Project
CJ-Johnson abandoned D110554: Test arc diff message, please ignore.
Mon, Sep 27, 8:16 AM · Restricted Project
CJ-Johnson updated the diff for D110554: Test arc diff message, please ignore.

Test update message, please ignore

Mon, Sep 27, 8:09 AM · Restricted Project
CJ-Johnson added a comment to D110554: Test arc diff message, please ignore.

Test top-level comment, please ignore

Mon, Sep 27, 8:06 AM · Restricted Project
CJ-Johnson requested review of D110554: Test arc diff message, please ignore.
Mon, Sep 27, 8:04 AM · Restricted Project

Nov 16 2020

CJ-Johnson added a comment to D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..

Please modify the commit subject and add a proper message.

Nov 16 2020, 3:35 PM · Restricted Project, Restricted Project
CJ-Johnson retitled D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments. from [CodeGen] Apply 'nonnull' to 'this' pointer arguments. to [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..
Nov 16 2020, 3:35 PM · Restricted Project, Restricted Project
CJ-Johnson updated the diff for D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..
Nov 16 2020, 2:49 PM · Restricted Project, Restricted Project

Nov 7 2020

CJ-Johnson added inline comments to D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..
Nov 7 2020, 9:05 AM · Restricted Project, Restricted Project
CJ-Johnson updated the diff for D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..
Nov 7 2020, 9:04 AM · Restricted Project, Restricted Project

Nov 2 2020

CJ-Johnson added a comment to D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..

Thanks! We should also have a test for the behavior when targeting the MS ABI, where we sometimes don't emit the nonnull dereferenceable because the "this" pointer might actually point outside the object, but otherwise I think this is ready to go.

Please can you also put together a patch for the release notes? This seems worth mentioning there.

Nov 2 2020, 3:12 AM · Restricted Project, Restricted Project
CJ-Johnson updated the diff for D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..
Nov 2 2020, 3:11 AM · Restricted Project, Restricted Project

Oct 31 2020

CJ-Johnson added a comment to D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..

The new tests can be found in this-nonnull.cpp: https://reviews.llvm.org/differential/changeset/?ref=2242268

Oct 31 2020, 11:18 AM · Restricted Project, Restricted Project
CJ-Johnson updated the diff for D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..
Oct 31 2020, 11:17 AM · Restricted Project, Restricted Project
CJ-Johnson added inline comments to D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..
Oct 31 2020, 9:49 AM · Restricted Project, Restricted Project

Oct 12 2020

CJ-Johnson added inline comments to D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..
Oct 12 2020, 11:57 AM · Restricted Project, Restricted Project
CJ-Johnson updated the diff for D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..

Apply dereferenceable even if null is a valid address

Oct 12 2020, 11:53 AM · Restricted Project, Restricted Project
CJ-Johnson added inline comments to D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..
Oct 12 2020, 11:29 AM · Restricted Project, Restricted Project
CJ-Johnson added inline comments to D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..
Oct 12 2020, 11:24 AM · Restricted Project, Restricted Project
CJ-Johnson updated the diff for D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..

Update with full diff context

Oct 12 2020, 11:22 AM · Restricted Project, Restricted Project
CJ-Johnson updated the diff for D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..

Update diff with full context

Oct 12 2020, 11:19 AM · Restricted Project, Restricted Project
CJ-Johnson added a comment to D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..

Can you please upload again with full context?

Oct 12 2020, 11:15 AM · Restricted Project, Restricted Project
CJ-Johnson updated the diff for D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..

Rebasing on head, removing flag changes since that was added in https://reviews.llvm.org/D47894 and fixing broken tests

Oct 12 2020, 11:01 AM · Restricted Project, Restricted Project
CJ-Johnson commandeered D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..

The patch is ready! Commandeering this change :)

Oct 12 2020, 10:53 AM · Restricted Project, Restricted Project

Oct 9 2020

CJ-Johnson added a comment to D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..

After chatting with bkramer, I'm working on rebasing this diff so that it can be landed.

Oct 9 2020, 7:17 AM · Restricted Project, Restricted Project
CJ-Johnson added inline comments to D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..
Oct 9 2020, 7:06 AM · Restricted Project, Restricted Project
CJ-Johnson updated the summary of D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..
Oct 9 2020, 7:06 AM · Restricted Project, Restricted Project

Jul 20 2020

CJ-Johnson added a comment to D32198: [TySan] A Type Sanitizer (LLVM).

@fhahn We don't currently enable -fstrict-aliasing at Google. I was exploring what it would take for us to get strict-aliasing clean. Unfortunately, after running some of our internal benchmarks, I found that there was little to no performance benefit.

Jul 20 2020, 9:16 PM

Jul 16 2020

CJ-Johnson added a comment to D32199: [TySan] A Type Sanitizer (Clang).

Hello to everyone following along! My apologies for the lack of activity; I should have made a comment sooner.

Jul 16 2020, 5:28 AM · Restricted Project
CJ-Johnson added a comment to D32198: [TySan] A Type Sanitizer (LLVM).

Hello to everyone following along! My apologies for the lack of activity; I should have made a comment sooner.

Jul 16 2020, 5:28 AM

Jan 2 2020

CJ-Johnson updated the diff for D32199: [TySan] A Type Sanitizer (Clang).

Fixing rebase

Jan 2 2020, 2:10 PM · Restricted Project
CJ-Johnson updated the diff for D32199: [TySan] A Type Sanitizer (Clang).

Rebase on head

Jan 2 2020, 2:00 PM · Restricted Project
CJ-Johnson commandeered D32199: [TySan] A Type Sanitizer (Clang).

After discussing things with Hal, I'm going to take over these diffs and try to update them to the new pass manager :)

Jan 2 2020, 8:14 AM · Restricted Project
CJ-Johnson commandeered D32197: [TySan] A Type Sanitizer (Runtime Library).

After discussing things with Hal, I'm going to take over these diffs and try to update them to the new pass manager :)

Jan 2 2020, 8:14 AM
CJ-Johnson commandeered D32198: [TySan] A Type Sanitizer (LLVM).

After discussing things with Hal, I'm going to take over these diffs and try to update them to the new pass manager :)

Jan 2 2020, 8:14 AM