Page MenuHomePhabricator

Bouska (Pablo Martin-Gomez)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 14 2019, 4:06 AM (49 w, 6 d)

Recent Activity

Jun 21 2020

Bouska added a comment to D81808: [clang-format] [PR45338] AllowShortIfStatementsOnASingleLine: WithoutElse follows the documented behaviour.

Are all the cases from the summary contained in the unit tests?

Jun 21 2020, 6:21 AM · Restricted Project, Unknown Object (Project)

Jun 14 2020

Bouska added inline comments to D81808: [clang-format] [PR45338] AllowShortIfStatementsOnASingleLine: WithoutElse follows the documented behaviour.
Jun 14 2020, 11:45 AM · Restricted Project, Unknown Object (Project)
Bouska created D81808: [clang-format] [PR45338] AllowShortIfStatementsOnASingleLine: WithoutElse follows the documented behaviour.
Jun 14 2020, 9:36 AM · Restricted Project, Unknown Object (Project)

Jun 7 2020

Bouska added a comment to D71512: [clang-format] Fix short block when braking after control statement.

@MyDeveloperDay I don't have commit rights, could you land this change for me please?

Jun 7 2020, 8:29 AM · Restricted Project, Unknown Object (Project)

Mar 28 2020

Bouska updated the diff for D71512: [clang-format] Fix short block when braking after control statement.

Do not touch current tests.

Mar 28 2020, 11:49 AM · Restricted Project, Unknown Object (Project)

Jan 24 2020

Bouska added a comment to D73354: clang-format: insert trailing commas into containers..

I have an issue with this change. Currently (at least for C++), the presence of a trailing comma is used as a formatting hint to put all the element in one line or one per line as below:

Jan 24 2020, 8:31 AM · Unknown Object (Project), Restricted Project
Bouska added a comment to D73354: clang-format: insert trailing commas into containers..
Jan 24 2020, 8:23 AM · Unknown Object (Project), Restricted Project

Jan 20 2020

Bouska added inline comments to D71512: [clang-format] Fix short block when braking after control statement.
Jan 20 2020, 9:58 AM · Restricted Project, Unknown Object (Project)
Bouska added inline comments to D71512: [clang-format] Fix short block when braking after control statement.
Jan 20 2020, 9:11 AM · Restricted Project, Unknown Object (Project)

Jan 11 2020

Bouska added a comment to D71512: [clang-format] Fix short block when braking after control statement.

Ping @MyDeveloperDay @klimek

Jan 11 2020, 5:07 AM · Restricted Project, Unknown Object (Project)
Bouska added inline comments to D72216: [clang-format] [PR44189] Remove space between identifier and scope resolution operator unless the identifier is a macro.
Jan 11 2020, 5:07 AM · Restricted Project, Unknown Object (Project)

Jan 7 2020

Bouska added inline comments to D72216: [clang-format] [PR44189] Remove space between identifier and scope resolution operator unless the identifier is a macro.
Jan 7 2020, 3:14 PM · Restricted Project, Unknown Object (Project)
Bouska added inline comments to D72216: [clang-format] [PR44189] Remove space between identifier and scope resolution operator unless the identifier is a macro.
Jan 7 2020, 2:48 PM · Restricted Project, Unknown Object (Project)

Jan 5 2020

Bouska added a comment to D72216: [clang-format] [PR44189] Remove space between identifier and scope resolution operator unless the identifier is a macro.

is #44192 the correct bug?

Jan 5 2020, 11:28 AM · Restricted Project, Unknown Object (Project)
Bouska added inline comments to D72216: [clang-format] [PR44189] Remove space between identifier and scope resolution operator unless the identifier is a macro.
Jan 5 2020, 11:27 AM · Restricted Project, Unknown Object (Project)
Bouska updated the summary of D72216: [clang-format] [PR44189] Remove space between identifier and scope resolution operator unless the identifier is a macro.
Jan 5 2020, 9:26 AM · Restricted Project, Unknown Object (Project)

Jan 4 2020

Bouska created D72216: [clang-format] [PR44189] Remove space between identifier and scope resolution operator unless the identifier is a macro.
Jan 4 2020, 3:09 PM · Restricted Project, Unknown Object (Project)
Bouska updated the diff for D71512: [clang-format] Fix short block when braking after control statement.

Updated unittest to check under the column limit and over the column limit.

Jan 4 2020, 10:05 AM · Restricted Project, Unknown Object (Project)

Dec 30 2019

Bouska accepted D71939: clang-format: fix conflict between FormatStyle::BWACS_MultiLine and BeforeCatch/BeforeElse.
Dec 30 2019, 5:27 PM · Restricted Project

Dec 28 2019

Bouska added a comment to D71939: clang-format: fix conflict between FormatStyle::BWACS_MultiLine and BeforeCatch/BeforeElse.

I'm not sure creating a special case for else/catch is the best idea. I would seem better to change the control statement @ line 309 to add it the case where we break before else or catch (add a new || test in the middle condition). I'm really new to this code too, so I don't know if it's better to check that previous line as a right curly brace and that BeforeElse/Catch is true and that first token of the line is else or catch or if just checking that the first token of the line is else or catch (or a mix in between). I'll let a more senior reviewer advise on this.

Dec 28 2019, 4:31 AM · Restricted Project

Dec 27 2019

Bouska added a comment to D71659: [clang-format] Added new option to allow setting spaces before and after the operator.

Is there a reason why this option adds space before and after the tok::arrow token but not the tok::arrowstar token? That seems inconsistent to me.

Dec 27 2019, 3:50 PM · Restricted Project, Unknown Object (Project)
Bouska requested changes to D71939: clang-format: fix conflict between FormatStyle::BWACS_MultiLine and BeforeCatch/BeforeElse.

So, you are trying to fix the issue at the wrong place. Contrary from what we should expect from a UnwrappedLine, BWACS_Multiline works by always wrapping the brace in UnwrappedLineParser, and afterwards in UnwrappedLineFormatter merging it back to the control statement if it's not in multi-line. The bug is on the control statement @ line 308 on UnwrappedLineFormatter.cpp. That's the block that merge the brace back to its control statement if it is not a multiline and it's executed only with a line with a else or a catch that begins with right curly brace.

Dec 27 2019, 3:32 PM · Restricted Project
Bouska added a comment to D71939: clang-format: fix conflict between FormatStyle::BWACS_MultiLine and BeforeCatch/BeforeElse.

Your code still breaks MultiLine

Dec 27 2019, 12:28 PM · Restricted Project
Bouska updated the diff for D71512: [clang-format] Fix short block when braking after control statement.

Set line length to column limit + 1 (41) in tests

Dec 27 2019, 10:25 AM · Restricted Project, Unknown Object (Project)

Dec 21 2019

Bouska added inline comments to D71512: [clang-format] Fix short block when braking after control statement.
Dec 21 2019, 8:37 AM · Restricted Project, Unknown Object (Project)

Dec 14 2019

Bouska created D71512: [clang-format] Fix short block when braking after control statement.
Dec 14 2019, 6:10 AM · Restricted Project, Unknown Object (Project)