Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Bhramar.vatsa (Bhramar Vatsa)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2020, 5:47 AM (160 w, 2 d)

Recent Activity

Jun 8 2023

Bhramar.vatsa added inline comments to rG877a9f9abec6: [FuncSpec] Make the Function Specializer part of the IPSCCP pass..
Jun 8 2023, 11:19 PM · Restricted Project, Restricted Project

Mar 27 2023

Bhramar.vatsa added inline comments to rG0af3e6a22da2: [InstCombine] Sink instructions with multiple users in a successor block..
Mar 27 2023, 6:26 AM · Restricted Project

Mar 10 2023

Bhramar.vatsa added a comment to D130466: [LICM] - Add option to force thread model single.

Yes, it looks like the similar conditions are triggered by the code shown in that issue, but perhaps the reason isn't that indvars simplification pass couldn't really deduce the the value from last but one iteration (as seen in the example I shared: https://godbolt.org/z/5xhY1EcGb), but maybe the code structure introduced by this change?

Mar 10 2023, 3:47 AM · Restricted Project, Restricted Project

Mar 7 2023

Bhramar.vatsa added a comment to D130466: [LICM] - Add option to force thread model single.

We see that for a single-threaded system or with option '-mllvm -licm-force-thread-model-single', the generated code quality worsens for a very simple example: https://godbolt.org/z/5xhY1EcGb.

Mar 7 2023, 3:44 AM · Restricted Project, Restricted Project

Feb 11 2022

Bhramar.vatsa added a comment to D119051: Extend the C++03 definition of POD to include defaulted functions.

Sorry, but I can only add a bit more confusion: https://godbolt.org/z/fT19KTh34
There are two cases, only differing in terms of user-defined constructor.

Feb 11 2022, 6:38 AM · Restricted Project, Restricted Project

Feb 5 2022

Bhramar.vatsa added inline comments to D119051: Extend the C++03 definition of POD to include defaulted functions.
Feb 5 2022, 6:43 AM · Restricted Project, Restricted Project

Feb 3 2022

Bhramar.vatsa added a comment to D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs.

@dblaikie
The condition FieldClass->isPOD() returns false for the following case (when considering field 'struct foo t' of 'struct foo1') :

Feb 3 2022, 10:15 PM · Restricted Project, Restricted Project

Nov 18 2020

Bhramar.vatsa updated the diff for D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.

Apologies for wrong patch (repeat of previous). I have now put up the latest patch. Please review and accept.

Nov 18 2020, 8:46 PM · Restricted Project
Bhramar.vatsa updated the diff for D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.

Restructured the code as suggested by @jeroen.dobbelaere

Nov 18 2020, 6:52 AM · Restricted Project
Bhramar.vatsa added inline comments to D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.
Nov 18 2020, 6:51 AM · Restricted Project
Bhramar.vatsa updated the diff for D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.

Added the missing computation of Known bits for the case Instruction::AShr. This should result in no change of functionality except when intended.

Nov 18 2020, 5:59 AM · Restricted Project

Nov 17 2020

Bhramar.vatsa added inline comments to D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.
Nov 17 2020, 10:42 PM · Restricted Project
Bhramar.vatsa added inline comments to D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.
Nov 17 2020, 12:35 AM · Restricted Project
Bhramar.vatsa updated the diff for D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.

Modified the comment as suggested by @lebedev.ri

Nov 17 2020, 12:09 AM · Restricted Project

Nov 16 2020

Bhramar.vatsa updated the diff for D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.

I have adapted the code as per @spatel's suggestion. This also solves the comments given on earlier version by @RKSimon.

Nov 16 2020, 7:43 AM · Restricted Project

Nov 12 2020

Bhramar.vatsa added reviewers for D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend: craig.topper, lebedev.ri.
Nov 12 2020, 6:10 AM · Restricted Project
Bhramar.vatsa requested review of D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.
Nov 12 2020, 6:06 AM · Restricted Project