Page MenuHomePhabricator
People Bhramar.vatsa

Bhramar.vatsa (Bhramar Vatsa)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2020, 5:47 AM (84 w, 4 d)

Recent Activity
View All

Feb 11 2022

Bhramar.vatsa added a comment to D119051: Extend the C++03 definition of POD to include defaulted functions.

Sorry, but I can only add a bit more confusion: https://godbolt.org/z/fT19KTh34
There are two cases, only differing in terms of user-defined constructor.

Feb 11 2022, 6:38 AM · Restricted Project, Restricted Project

Feb 5 2022

Bhramar.vatsa added inline comments to D119051: Extend the C++03 definition of POD to include defaulted functions.
Feb 5 2022, 6:43 AM · Restricted Project, Restricted Project

Feb 3 2022

Bhramar.vatsa added a comment to D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs.

@dblaikie
The condition FieldClass->isPOD() returns false for the following case (when considering field 'struct foo t' of 'struct foo1') :

Feb 3 2022, 10:15 PM · Restricted Project, Restricted Project

Nov 18 2020

Bhramar.vatsa updated the diff for D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.

Apologies for wrong patch (repeat of previous). I have now put up the latest patch. Please review and accept.

Nov 18 2020, 8:46 PM · Restricted Project
Bhramar.vatsa updated the diff for D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.

Restructured the code as suggested by @jeroen.dobbelaere

Nov 18 2020, 6:52 AM · Restricted Project
Bhramar.vatsa added inline comments to D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.
Nov 18 2020, 6:51 AM · Restricted Project
Bhramar.vatsa updated the diff for D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.

Added the missing computation of Known bits for the case Instruction::AShr. This should result in no change of functionality except when intended.

Nov 18 2020, 5:59 AM · Restricted Project

Nov 17 2020

Bhramar.vatsa added inline comments to D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.
Nov 17 2020, 10:42 PM · Restricted Project
Bhramar.vatsa added inline comments to D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.
Nov 17 2020, 12:35 AM · Restricted Project
Bhramar.vatsa updated the diff for D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.

Modified the comment as suggested by @lebedev.ri

Nov 17 2020, 12:09 AM · Restricted Project

Nov 16 2020

Bhramar.vatsa updated the diff for D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.

I have adapted the code as per @spatel's suggestion. This also solves the comments given on earlier version by @RKSimon.

Nov 16 2020, 7:43 AM · Restricted Project

Nov 12 2020

Bhramar.vatsa added reviewers for D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend: craig.topper, lebedev.ri.
Nov 12 2020, 6:10 AM · Restricted Project
Bhramar.vatsa requested review of D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.
Nov 12 2020, 6:06 AM · Restricted Project