- User Since
- Mar 8 2021, 11:11 AM (14 w, 5 d)
Thu, Jun 10
I don't think that I have write access. I read https://llvm.org/docs/Phabricator.html#committing-a-change but it's not very clear to me. As far as I can see all I can do here is write this message asking if someone can submit for me? I don't see something else than this free-text field to input to (so is this process dependent on contributors freely browsing open reviews for ones that need submitting?)
Wed, Jun 9
one more review comment
one more whitespace fix
one last review comment
addressed ftynse's review comments
Addressed review comments. Predicates now implemented using CPred.
May 14 2021
There is one of your comments which I haven't applied yet. It's the one about writing a TODO about the handling of these reshapes. Part of the problem is I didn't understand 100% of what you were saying, and part is that this topic is going to get more subtle still in the following commit, adding the lowering from vector.contract, which will involve a broadcast to map the contract to the flavor of SDOT that we have here, which (as said in the other comment) is actually 4 separate vector dot products. So if you're OK, I would suggest to do nothing about this in this CL, discuss with you next week, decide something for the next commit.
Please take a look - nontrivial enough changes that I'd like your opinion again.
Applied review comments
Mar 10 2021
Rebased following D98096