Page MenuHomePhabricator

BenjaminTrapani (Benjamin Trapani)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 5 2020, 5:23 PM (178 w, 4 d)

Recent Activity

Nov 26 2020

BenjaminTrapani added inline comments to D72240: Implement C++20 std::atomic_ref and test.
Nov 26 2020, 2:49 PM · Restricted Project, Restricted Project
BenjaminTrapani updated the diff for D72240: Implement C++20 std::atomic_ref and test.

Pull in original portion of patch

Nov 26 2020, 2:44 PM · Restricted Project, Restricted Project
BenjaminTrapani updated the diff for D72240: Implement C++20 std::atomic_ref and test.

Remove C11 atomic path from atomic header. Update tests to check for specific errors. Other style fixes.

Nov 26 2020, 2:31 PM · Restricted Project, Restricted Project
BenjaminTrapani removed a reviewer for D92196: C++20 comments: Restricted Project.
Nov 26 2020, 2:23 PM
BenjaminTrapani updated the diff for D92196: C++20 comments.

Further rebases

Nov 26 2020, 2:21 PM
BenjaminTrapani updated the diff for D92196: C++20 comments.

Rebase master

Nov 26 2020, 2:04 PM
BenjaminTrapani requested review of D92196: C++20 comments.
Nov 26 2020, 1:59 PM
BenjaminTrapani added inline comments to D72240: Implement C++20 std::atomic_ref and test.
Nov 26 2020, 10:29 AM · Restricted Project, Restricted Project

Apr 5 2020

Herald added a reviewer for D72240: Implement C++20 std::atomic_ref and test: Restricted Project.

For those that are interested in testing out this change, here is a release build of clang 10 with these changes: https://skytopsoftware.ddns.net/binaries/compilers/llvm/llvm_10_release_linux_amd64.tar.gz

Apr 5 2020, 1:21 PM · Restricted Project, Restricted Project

Jan 24 2020

BenjaminTrapani added a comment to D72240: Implement C++20 std::atomic_ref and test.

Any update on this?

Jan 24 2020, 5:46 AM · Restricted Project, Restricted Project

Jan 12 2020

BenjaminTrapani updated the diff for D72240: Implement C++20 std::atomic_ref and test.

Provide only two versions of __cxx_atomic_pointer_to_data that perform different cast operations. Get rid of type-specific versions by extracting original type qualifiers and re-annoting atomic type.

Jan 12 2020, 9:35 AM · Restricted Project, Restricted Project

Jan 11 2020

BenjaminTrapani updated the diff for D72240: Implement C++20 std::atomic_ref and test.

Remove redundant namespace qualifiers

Jan 11 2020, 7:56 PM · Restricted Project, Restricted Project
BenjaminTrapani updated the diff for D72240: Implement C++20 std::atomic_ref and test.

Get rid of duplication across __cxx_atomic_* functions by using a traits class and SFINAE to check types and select overrides when required. Static assert that template type is always lock free when built using builtin only mode.

Jan 11 2020, 6:35 PM · Restricted Project, Restricted Project

Jan 5 2020

BenjaminTrapani created D72240: Implement C++20 std::atomic_ref and test.
Jan 5 2020, 5:57 PM · Restricted Project, Restricted Project