Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People Arsenic

Arsenic (Ankur Saini)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 12 2022, 11:44 PM (89 w, 5 d)

Recent Activity
View All

Sun, Sep 10

Arsenic added a comment to D158646: [clang-tools-extra][ExtractAPI] create clang-symbolgraph-merger.
In D158646#4639599, @dang wrote:

As per https://discourse.llvm.org/t/pull-request-migration-schedule/71595 we should move this review to GitHub to make sure we don't lose track of it.

Sun, Sep 10, 4:55 AM · Restricted Project, Restricted Project

Aug 26 2023

Arsenic updated the diff for D157810: [clang][ExtractAPI] Create extractapi::RecordLocation.
  • Move creation of DocComment in it's own separate function
  • Update the Underlying DataType used by RecordLocation
  • Update the patch to account for new C++ APIRecords
Aug 26 2023, 7:07 AM · Restricted Project, Restricted Project

Aug 23 2023

Arsenic requested review of D158646: [clang-tools-extra][ExtractAPI] create clang-symbolgraph-merger.
Aug 23 2023, 10:58 AM · Restricted Project, Restricted Project
Arsenic updated the diff for D157810: [clang][ExtractAPI] Create extractapi::RecordLocation.
  • Create function to directly get DocComments from Decl
  • Update the way RecordLocation holds filename
  • Update changes to use RecordLocation with new C++ APIRecords
Aug 23 2023, 10:46 AM · Restricted Project, Restricted Project

Aug 13 2023

Arsenic updated the diff for D157810: [clang][ExtractAPI] Create extractapi::RecordLocation.

Fix minor typo in code comments

Aug 13 2023, 2:57 AM · Restricted Project, Restricted Project
Arsenic requested review of D157810: [clang][ExtractAPI] Create extractapi::RecordLocation.
Aug 13 2023, 2:27 AM · Restricted Project, Restricted Project

Jul 3 2023

Arsenic committed rG8e9145e43142: [clang][ExtractAPI] Add --emit-symbol-graph option (authored by Arsenic).
[clang][ExtractAPI] Add --emit-symbol-graph option
Jul 3 2023, 5:08 AM · Restricted Project, Restricted Project
Arsenic closed D152356: [clang][ExtractAPI] Add --emit-symbol-graph option.
Jul 3 2023, 5:07 AM · Restricted Project, Restricted Project

Jun 28 2023

Arsenic updated the diff for D152356: [clang][ExtractAPI] Add --emit-symbol-graph option.

Changes majorly include fixing issues pointed out by review comments :

  • Remove WrappingExtractAPIAction::prepareToExecuteAction()
  • Move knownInputFiles from Base action to ExtractAPIFrontendAction
  • Fix naming of MacroCallback and symbolGraphConsumer
  • Fix minor typos
  • Remove BasicExtractAPIVisitor, directly use ExtractAPIVisitor instead
Jun 28 2023, 10:46 PM · Restricted Project, Restricted Project

Jun 16 2023

Arsenic published D152356: [clang][ExtractAPI] Add --emit-symbol-graph option for review.
Jun 16 2023, 9:18 AM · Restricted Project, Restricted Project

Mar 13 2023

Arsenic committed rG58825d2cf947: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores (authored by Arsenic).
[clang][ExtractAPI] Add multiple file support to --extract-api-ignores
Mar 13 2023, 5:39 AM · Restricted Project, Restricted Project
Arsenic closed D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores.
Mar 13 2023, 5:39 AM · Restricted Project, Restricted Project
Arsenic updated the diff for D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores.

fix test

Mar 13 2023, 4:40 AM · Restricted Project, Restricted Project
Arsenic updated the diff for D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores.

Update clang/test/ExtractAPI/ignored-symbols-multifile.c :
Shuffle the order of ignored symbols in test to check the sorting behaviour of APIIgnoresList

Mar 13 2023, 4:20 AM · Restricted Project, Restricted Project

Mar 12 2023

Arsenic added a reviewer for D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores: zixuw.
Mar 12 2023, 6:09 AM · Restricted Project, Restricted Project
Arsenic requested review of D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores.
Mar 12 2023, 6:07 AM · Restricted Project, Restricted Project

Feb 28 2023

Arsenic abandoned D144964: [clang][ExtractAPI] Handle platform specific unavailability correctly.

duplicate of https://reviews.llvm.org/D144940

Feb 28 2023, 8:05 AM · Restricted Project, Restricted Project
Arsenic updated the diff for D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly.

Add test to check platform specific unavailability

Feb 28 2023, 8:04 AM · Restricted Project, Restricted Project
Arsenic added a reviewer for D144964: [clang][ExtractAPI] Handle platform specific unavailability correctly: zixuw.
Feb 28 2023, 6:56 AM · Restricted Project, Restricted Project
Arsenic requested review of D144964: [clang][ExtractAPI] Handle platform specific unavailability correctly.
Feb 28 2023, 6:53 AM · Restricted Project, Restricted Project
Arsenic added a comment to D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly.
In D144940#4158020, @dang wrote:

Nice! glad to see this getting fixed. You should add a lit test to ensure we don't regress this behavior in the future.

Feb 28 2023, 4:46 AM · Restricted Project, Restricted Project

Feb 27 2023

Arsenic published D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly for review.
Feb 27 2023, 9:11 PM · Restricted Project, Restricted Project