Page MenuHomePhabricator

ArnaudBienner (Arnaud Bienner)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 25 2018, 7:00 AM (58 w, 15 h)

Recent Activity

Jun 28 2019

ArnaudBienner updated subscribers of D56366: New warning call-to-virtual-from-ctor-dtor when calling a virtual function from a constructor or a destructor.

Thanks @xbolva00 for adding reviewers and @rjmccall for reviewing!

Jun 28 2019, 10:04 AM · Restricted Project

Jun 19 2019

ArnaudBienner added inline comments to D63082: [Diagnostics] Added support for -Wint-in-bool-context.
Jun 19 2019, 3:06 PM · Restricted Project

Jan 6 2019

ArnaudBienner updated the summary of D56366: New warning call-to-virtual-from-ctor-dtor when calling a virtual function from a constructor or a destructor.
Jan 6 2019, 1:19 PM · Restricted Project
ArnaudBienner created D56366: New warning call-to-virtual-from-ctor-dtor when calling a virtual function from a constructor or a destructor.
Jan 6 2019, 1:06 PM · Restricted Project

Jan 3 2019

ArnaudBienner added a comment to D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds.

OK, thanks Serge! :)

Jan 3 2019, 9:52 AM
ArnaudBienner updated the diff for D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds.

Make -Wstring-plus-int warns even if when the result is not out of bounds

Jan 3 2019, 7:31 AM

Dec 18 2018

ArnaudBienner added a comment to D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds.

Fixed two tests broken by this change:

  • test_diagnostics.py: AFAICT we are not testing all warnings here, but just that warnings are emitted correctly. The "+1" didn't seem to be useful, since the warning triggered was about the const char* being converted to an int (and this warning still applies)
  • test/SemaCXX/constant-expression-cxx1y.cpp: is a false positive for -Wstring-plus-int so use the preferred, equivalent syntax
Dec 18 2018, 1:51 AM
ArnaudBienner reopened D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds.

Reopening since this broke some tests.

Dec 18 2018, 1:47 AM
ArnaudBienner updated the diff for D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds.

Update tests broken by this change

Dec 18 2018, 1:47 AM

Dec 14 2018

ArnaudBienner added a comment to D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds.

Really sorry about breaking the build :( Thanks for reverting it.
Actually, I think we could fix that test by removing the " +1": AFAICT this test is checking that warnings are correctly emitted from clang, but not testing all the warnings. So the conversion from const char* to int is enough: no need to have an extra +1 at the end.
I will update my patch to update the test accordingly.

Dec 14 2018, 7:21 AM

Dec 13 2018

ArnaudBienner added a comment to D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds.

Thanks for the archeological work and finding the conversation related to the initial patch :)
Interesting that the last case you mentioned is exactly the bug I had in my project (though in your case this would have been intended).

Dec 13 2018, 8:12 AM

Dec 12 2018

ArnaudBienner added a comment to D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds.

So I built Firefox with my patched version of clang and the only place it found a warning was in ffmpeg [1], a case you already reported in [2] when you implemented that patch, so no new positive AFAICT.
Do you also want to try on Chromium and see how it goes? Or is Firefox enough? (it's a pretty big C++ codebase, so I would assume that's enough)

Dec 12 2018, 1:40 AM

Dec 7 2018

ArnaudBienner added a comment to D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds.

I found the commit: [1] which links to a related discussion [2] but there isn't much details. I wasn't sure if there was other discussions.
I will try to build Firefox with this change, and see how it goes (just need to find some time to do it).
I'll keep you posted.

Dec 7 2018, 1:15 AM

Dec 6 2018

ArnaudBienner added a comment to D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds.

Nico: I've added you as reviewer since you originally implemented this warning (thanks for this BTW :) as said, it's really helpful), but feel free to delegate to someone else.

Dec 6 2018, 1:01 PM
ArnaudBienner added a comment to D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds.

I found this warning to be really useful but was confused that it is not always triggered.
I initially discovered -Wstring-plus-char (and fixed some issues in the projects I work on where sometimes developers didn't realized the "+" wasn't doing to do concatenation because it was applied on char and char*).
Then I also activated -Werror=string-plus-int to reduce the risk of developers doing mistakes in our codebase.

Dec 6 2018, 1:01 PM
ArnaudBienner added reviewers for D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds: sylvestre.ledru, thakis.
Dec 6 2018, 12:39 PM
ArnaudBienner created D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds.
Dec 6 2018, 12:38 PM

Nov 19 2018

ArnaudBienner added a comment to D53807: Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ctor_dtor, so it can be turned into an error using Werror.

Thanks for the review! :)
Could someone please land the patch for me? I don't have commit access.

Nov 19 2018, 2:36 PM

Nov 15 2018

ArnaudBienner added a comment to D53807: Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ctor_dtor, so it can be turned into an error using Werror.

@rsmith do you have any thoughts about this change?

Nov 15 2018, 5:31 AM

Oct 29 2018

ArnaudBienner added a reviewer for D53807: Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ctor_dtor, so it can be turned into an error using Werror: davide.

Hi Davide,

Oct 29 2018, 8:10 AM
ArnaudBienner updated the diff for D53807: Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ctor_dtor, so it can be turned into an error using Werror.

Update tests

Oct 29 2018, 8:04 AM
ArnaudBienner created D53807: Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ctor_dtor, so it can be turned into an error using Werror.
Oct 29 2018, 3:13 AM