Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Ariel-Burton (Ariel Burton)
User

Projects

User does not belong to any projects.

User Details

User Since
May 27 2022, 3:57 PM (69 w, 7 h)

Recent Activity

Jan 23 2023

Ariel-Burton added reviewers for D142048: [Phabricator] Fix __ptr32 arguments passed to builtins: rnk, akhuang.
Jan 23 2023, 7:56 AM · Restricted Project, Restricted Project

Jan 19 2023

Ariel-Burton updated the diff for D142048: [Phabricator] Fix __ptr32 arguments passed to builtins.
  • Adjust formatting to conform to git-clang-format
Jan 19 2023, 9:55 AM · Restricted Project, Restricted Project

Jan 18 2023

Ariel-Burton added reviewers for D142048: [Phabricator] Fix __ptr32 arguments passed to builtins: tstellar, jfb, hliao, arichardson, mibintc.
Jan 18 2023, 11:25 AM · Restricted Project, Restricted Project
Ariel-Burton requested review of D142048: [Phabricator] Fix __ptr32 arguments passed to builtins.
Jan 18 2023, 11:13 AM · Restricted Project, Restricted Project

Nov 30 2022

Ariel-Burton added a comment to D133376: Allow epilogue_begin to be emitted when generating DWARF.

As one might expect, the section that grew is .debug_line. I see an increases of about 2%. However, the overall size of just the debug info increases by considerably less, about 0.3%. The increase of the overall file size is even less, at about 0,2%.

Under what build configuration/example target? These numbers can vary pretty widely depending on compression, split dwarf, optimized/unoptimized, etc. Might be good to have a few scenarios covered, at least with clang or something similarly large-ish from the LLVM project.

Nov 30 2022, 4:24 PM · debug-info, Restricted Project, Restricted Project

Nov 4 2022

Ariel-Burton added a comment to D133376: Allow epilogue_begin to be emitted when generating DWARF.

ping for approval

Nov 4 2022, 8:43 AM · debug-info, Restricted Project, Restricted Project

Sep 28 2022

Ariel-Burton added a comment to D133376: Allow epilogue_begin to be emitted when generating DWARF.

I think this is a reasonable feature to support. As @MatzeB pointed out, it may not be useful in optimized code. Are you primarily targeting optimized or unoptimized code? How much does the debug info size grow in % if you build, e.g., clang?

Sep 28 2022, 7:19 PM · debug-info, Restricted Project, Restricted Project

Sep 6 2022

Ariel-Burton added a comment to D133376: Allow epilogue_begin to be emitted when generating DWARF.

What is this epilogue information going to be used for?

Generally I find the notion of "epilogue" a bit sketchy, since you can easily imagine the scheduler mixing CSR restore instructions (and whatever else you consider epilogue) with normal computation so you'll have epilogue and non-epilogue code mixed together so a notion of "epilogue starts here" doesn't really mean much...

Sep 6 2022, 3:31 PM · debug-info, Restricted Project, Restricted Project
Ariel-Burton added reviewers for D133376: Allow epilogue_begin to be emitted when generating DWARF: MatzeB, probinson, rnk.
Sep 6 2022, 2:12 PM · debug-info, Restricted Project, Restricted Project
Ariel-Burton requested review of D133376: Allow epilogue_begin to be emitted when generating DWARF.
Sep 6 2022, 2:05 PM · debug-info, Restricted Project, Restricted Project

Aug 8 2022

Ariel-Burton updated the diff for D130123: Extend ptr32 support to be applied on typedef.
  • Add case to deal with ElaboratedTypes.
Aug 8 2022, 3:42 PM · Restricted Project, Restricted Project

Aug 4 2022

Ariel-Burton added a comment to D130123: Extend ptr32 support to be applied on typedef.

Just to make sure that we're on the same page, you'd like to see a test that confirms that clang is rejecting the template<typename T> void f(T __ptr32 a) example, and possibly one that checks that my example is accepted. Is that correct?

Yep, exactly that. Sorry for the delay, the code looks good.

Aug 4 2022, 3:49 PM · Restricted Project, Restricted Project
Ariel-Burton updated the diff for D130123: Extend ptr32 support to be applied on typedef.

Recover original changes, and commit with new C++ __ptr32 test.

Aug 4 2022, 3:47 PM · Restricted Project, Restricted Project
Ariel-Burton updated the diff for D130123: Extend ptr32 support to be applied on typedef.

Added C++ tests for __ptr32.

Aug 4 2022, 3:42 PM · Restricted Project, Restricted Project

Aug 3 2022

Ariel-Burton added a comment to D130123: Extend ptr32 support to be applied on typedef.

What is your expectation for your template code fragment? MSVC does not accept it.

Yes, I checked, MSVC rejects it, so clang should have test expectations to confirm that. It seems interesting or surprising, to me at least, that MSVC really only accepts __ptr32 on pointers and typedefs of them.

On the other hand, MSVC does accept this:

template <typename T>
void f(T  a) {
  (*a) += sizeof(a);
}
void g(int *p) {
  f(p);
}
void h(int *__ptr32 p) {
    f(p);
}

Right, this makes sense to me. MSVC's diagnostics say something about the __ptr32 qualifier needing to appear after a *, so this extension must be implemented at a pretty low-level, with some exception for typedefs, just like what you have.

Aug 3 2022, 7:27 PM · Restricted Project, Restricted Project
Ariel-Burton added a comment to D130123: Extend ptr32 support to be applied on typedef.

That sounds reasonable to me, I confirmed that MSVC really only lets you apply these attributes directly to pointer types and to typedefs.

Can you add a test for the other most common type sugar node, the template parameter? It looks like this:

template <typename T>
void f(T __ptr32 a) {
    (*a) += 1;
}
void g(int *p) {
    f(p);
}

If there isn't already a C++ test for __ptr32 & co, go ahead and make one.

Aug 3 2022, 9:22 AM · Restricted Project, Restricted Project

Jul 20 2022

Ariel-Burton added inline comments to D130123: Extend ptr32 support to be applied on typedef.
Jul 20 2022, 4:49 PM · Restricted Project, Restricted Project

Jul 19 2022

Ariel-Burton added inline comments to D130123: Extend ptr32 support to be applied on typedef.
Jul 19 2022, 7:22 PM · Restricted Project, Restricted Project
Ariel-Burton retitled D130123: Extend ptr32 support to be applied on typedef from [Phabricator] extend ptr32 support to be applied on typedef to Extend ptr32 support to be applied on typedef.
Jul 19 2022, 2:04 PM · Restricted Project, Restricted Project
Ariel-Burton requested review of D130123: Extend ptr32 support to be applied on typedef.
Jul 19 2022, 1:42 PM · Restricted Project, Restricted Project